[PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation

[PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation

[Luca Weiss]

The LPG node doesn't use reg, so adjust the documentation to match that.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 6a3e3ede1ede..16ade0fa2d33 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -94,6 +94,10 @@ properties:
     type: object
     $ref: /schemas/regulator/qcom-labibb-regulator.yaml#
 
+  pwm:
+    type: object
+    $ref: /schemas/leds/leds-qcom-lpg.yaml#
+
   regulators:
     type: object
     $ref: /schemas/regulator/qcom,spmi-regulator.yaml#
@@ -123,10 +127,6 @@ patternProperties:
     type: object
     $ref: /schemas/power/reset/qcom,pon.yaml#
 
-  "pwm@[0-9a-f]+$":
-    type: object
-    $ref: /schemas/leds/leds-qcom-lpg.yaml#
-
   "^rtc@[0-9a-f]+$":
     type: object
     $ref: /schemas/rtc/qcom-pm8xxx-rtc.yaml#
-- 
2.37.3

[PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types

[Luca Weiss]

* 'adc@' is either spmi-iadc or spmi-vadc
* 'charger@' is either pm8941-charger or pm8941-coincell
* 'dcdc@' is usb-vbus-regulator

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml    | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 16ade0fa2d33..e54fb5d64ef8 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -105,7 +105,9 @@ properties:
 patternProperties:
   "^adc@[0-9a-f]+$":
     type: object
-    $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml#
+    oneOf:
+      - $ref: /schemas/iio/adc/qcom,spmi-iadc.yaml#
+      - $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml#
 
   "^adc-tm@[0-9a-f]+$":
     type: object
@@ -115,6 +117,16 @@ patternProperties:
     type: object
     additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet
 
+  "charger@[0-9a-f]+$":
+    type: object
+    oneOf:
+      - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
+      - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
+
+  "^dcdc@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/regulator/qcom,usb-vbus-regulator.yaml#
+
   "extcon@[0-9a-f]+$":
     type: object
     $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
-- 
2.37.3

Re: [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types

[Krzysztof Kozlowski]

On 25/09/2022 23:17, Luca Weiss wrote:

Thank you for your patch. There is something to discuss/improve.

>      additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet
>  
> +  "charger@[0-9a-f]+$":
> +    type: object
> +    oneOf:
> +      - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
> +      - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
> +
> +  "^dcdc@[0-9a-f]+$":
> +    type: object

How about renaming this one to usb-vbus-regulator?

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types

[Luca Weiss]

On Montag, 26. September 2022 10:51:45 CEST Krzysztof Kozlowski wrote:
> On 25/09/2022 23:17, Luca Weiss wrote:
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> >      additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec
> >      binding not converted yet> 
> > +  "charger@[0-9a-f]+$":
> > +    type: object
> > +    oneOf:
> > +      - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
> > +      - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
> > +
> > +  "^dcdc@[0-9a-f]+$":
> > +    type: object
> 
> How about renaming this one to usb-vbus-regulator?

Sounds good to me. I was actually hoping somebody would suggest a better name.

Should I wait a bit to see if anybody else has a better suggestion or send a 
v2 now?

Regards
Luca

> 
> Best regards,
> Krzysztof

Re: [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation

[Krzysztof Kozlowski]

On 25/09/2022 23:17, Luca Weiss wrote:
> The LPG node doesn't use reg, so adjust the documentation to match that.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----

Already sent:

https://lore.kernel.org/all/20220828132648.3624126-2-bryan.odonoghue@linaro.org/

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation

[Luca Weiss]

On Montag, 26. September 2022 10:49:11 CEST Krzysztof Kozlowski wrote:
> On 25/09/2022 23:17, Luca Weiss wrote:
> > The LPG node doesn't use reg, so adjust the documentation to match that.
> > 
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> > 
> >  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
> 
> Already sent:
> 
> https://lore.kernel.org/all/20220828132648.3624126-2-bryan.odonoghue@linaro.
> org/

Thanks for spotting! I retract my patch then :)

Any idea who will merge the other patch then? It's been a month since sending 
and it hasn't been applied yet / not in linux-next yet.

Regards
Luca

> 
> Best regards,
> Krzysztof