From: Jingyi Wang <quic_jingyw@quicinc.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, <quic_tengfan@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: add base QCS8300 RIDE board
Date: Fri, 29 Nov 2024 10:18:40 +0800 [thread overview]
Message-ID: <48b27eeb-fe75-43c6-b5f2-930610cf4c0c@quicinc.com> (raw)
In-Reply-To: <fe332b12-d62e-442d-906b-7f3a72165b85@lunn.ch>
On 11/29/2024 12:49 AM, Andrew Lunn wrote:
> On Thu, Nov 28, 2024 at 04:44:46PM +0800, Jingyi Wang wrote:
>> Add initial support for Qualcomm QCS8300 RIDE board which enables DSPs,
>> UFS and booting to shell with uart console.
>>
>> Written with help from Tingguo Cheng (added rpmhpd nodes) and Xin Liu
>> (added ufs, adsp and gpdsp nodes).
>>
>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 2 +-
>> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 267 ++++++++++++++++++++++++++++++
>> 2 files changed, 268 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index 9bb8b191aeb5..d9545743606a 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -114,7 +114,7 @@ dtb-$(CONFIG_ARCH_QCOM) += qcm6490-shift-otter.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb
>> -dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb
>> +dtb-$(CONFIG_ARCH_QCOM) += qcs8300-ride.dtb
>
> It would be good to add a comment to the commit message about why you
> are removing qcs8550-aim300-aiot.dtb from the Makefile.
>
> Andrew
sorry it was a typo, will fix that
Thanks,
Jingyi
prev parent reply other threads:[~2024-11-29 2:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 8:44 [PATCH v3 0/4] Add initial support for QCS8300 SoC and QCS8300 RIDE board Jingyi Wang
2024-11-28 8:44 ` [PATCH v3 1/4] dt-bindings: arm: qcom: document QCS8300 SoC and reference board Jingyi Wang
2024-11-28 8:44 ` [PATCH v3 2/4] arm64: defconfig: enable clock controller, interconnect and pinctrl for QCS8300 Jingyi Wang
2024-11-28 13:12 ` Dmitry Baryshkov
2024-11-29 2:20 ` Jingyi Wang
2024-11-28 8:44 ` [PATCH v3 3/4] arm64: dts: qcom: add QCS8300 platform Jingyi Wang
2024-11-28 20:14 ` Konrad Dybcio
2024-12-02 9:54 ` Xin Liu
2024-12-02 10:00 ` Jingyi Wang
2024-11-28 8:44 ` [PATCH v3 4/4] arm64: dts: qcom: add base QCS8300 RIDE board Jingyi Wang
2024-11-28 13:29 ` Dmitry Baryshkov
2024-11-29 3:13 ` Tingwei Zhang
2024-11-30 1:46 ` Dmitry Baryshkov
2024-11-28 16:49 ` Andrew Lunn
2024-11-28 17:40 ` Krzysztof Kozlowski
2024-11-29 2:18 ` Jingyi Wang
2024-11-29 2:18 ` Jingyi Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48b27eeb-fe75-43c6-b5f2-930610cf4c0c@quicinc.com \
--to=quic_jingyw@quicinc.com \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_tengfan@quicinc.com \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox