public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/6] arm64: dts: qcom: sm8[456]50: Add missing CX power domain to GCC
@ 2026-04-24  9:07 Neil Armstrong
  2026-04-24  9:07 ` [PATCH 1/6] dt-bindings: clock: qcom: gcc-sm8450: Add missing power-domains property Neil Armstrong
                   ` (5 more replies)
  0 siblings, 6 replies; 16+ messages in thread
From: Neil Armstrong @ 2026-04-24  9:07 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Abel Vesa,
	Konrad Dybcio, Sai Prakash Ranjan
  Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel,
	Krzysztof Kozlowski, Neil Armstrong

Recently, on Eliza & Milos, the CX has been tied up to the GCC,
but this is valid for most platforms including sm8[456]50.
So tie the CX power domain to the GCC as well, for the
same exact reasons as on Eliza & Milos.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Neil Armstrong (6):
      dt-bindings: clock: qcom: gcc-sm8450: Add missing power-domains property
      dt-bindings: clock: qcom: sm8550-gcc: Add missing power-domains property
      dt-bindings: clock: qcom: sm8650-gcc: Add missing power-domains property
      arm64: dts: qcom: sm8450: Add missing CX power domain to GCC
      arm64: dts: qcom: sm8550: Add missing CX power domain to GCC
      arm64: dts: qcom: sm8650: Add missing CX power domain to GCC

 Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml | 5 +++++
 Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml | 5 +++++
 Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml | 5 +++++
 arch/arm64/boot/dts/qcom/sm8450.dtsi                         | 1 +
 arch/arm64/boot/dts/qcom/sm8550.dtsi                         | 1 +
 arch/arm64/boot/dts/qcom/sm8650.dtsi                         | 2 ++
 6 files changed, 19 insertions(+)
---
base-commit: 4c406406070d57dbefeaad149181785330c23f92
change-id: 20260424-topic-sm8x50-tie-gcc-to-cx-e756afa72bb8

Best regards,
--  
Neil Armstrong <neil.armstrong@linaro.org>


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 1/6] dt-bindings: clock: qcom: gcc-sm8450: Add missing power-domains property
  2026-04-24  9:07 [PATCH 0/6] arm64: dts: qcom: sm8[456]50: Add missing CX power domain to GCC Neil Armstrong
@ 2026-04-24  9:07 ` Neil Armstrong
  2026-04-24 10:46   ` Rob Herring (Arm)
  2026-04-24  9:07 ` [PATCH 2/6] dt-bindings: clock: qcom: sm8550-gcc: " Neil Armstrong
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 16+ messages in thread
From: Neil Armstrong @ 2026-04-24  9:07 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Abel Vesa,
	Konrad Dybcio, Sai Prakash Ranjan
  Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel,
	Krzysztof Kozlowski, Neil Armstrong

In order for the GCC votes on the GDSCs it provides to be propagated
to CX, CX needs to be declared as power domain of the GCC.

Document the missing power-domains property to that purpose.

Fixes: 72a0ca203ca7 ("dt-bindings: clock: Add SM8450 GCC clock bindings")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml
index 3169ac05e1d8..16fd5a42f3a0 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml
@@ -47,10 +47,15 @@ properties:
       - const: usb3_phy_wrapper_gcc_usb30_pipe_clk # Optional clock
     minItems: 2
 
+  power-domains:
+    items:
+      - description: CX domain
+
 required:
   - compatible
   - clocks
   - clock-names
+  - power-domains
   - '#power-domain-cells'
 
 allOf:

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 2/6] dt-bindings: clock: qcom: sm8550-gcc: Add missing power-domains property
  2026-04-24  9:07 [PATCH 0/6] arm64: dts: qcom: sm8[456]50: Add missing CX power domain to GCC Neil Armstrong
  2026-04-24  9:07 ` [PATCH 1/6] dt-bindings: clock: qcom: gcc-sm8450: Add missing power-domains property Neil Armstrong
@ 2026-04-24  9:07 ` Neil Armstrong
  2026-04-24 10:46   ` Rob Herring (Arm)
  2026-04-24  9:07 ` [PATCH 3/6] dt-bindings: clock: qcom: sm8650-gcc: " Neil Armstrong
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 16+ messages in thread
From: Neil Armstrong @ 2026-04-24  9:07 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Abel Vesa,
	Konrad Dybcio, Sai Prakash Ranjan
  Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel,
	Krzysztof Kozlowski, Neil Armstrong

In order for the GCC votes on the GDSCs it provides to be propagated
to CX, CX needs to be declared as power domain of the GCC.

Document the missing power-domains property to that purpose.

Fixes: 47ba9c50bbeb ("dt-bindings: clock: Add SM8550 GCC clocks")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml
index c4e9b9bb63f5..8c40e93bf336 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml
@@ -31,9 +31,14 @@ properties:
       - description: UFS Phy Tx symbol 0 clock source
       - description: USB3 Phy wrapper pipe clock source
 
+  power-domains:
+    items:
+      - description: CX domain
+
 required:
   - compatible
   - clocks
+  - power-domains
   - '#power-domain-cells'
 
 allOf:

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 3/6] dt-bindings: clock: qcom: sm8650-gcc: Add missing power-domains property
  2026-04-24  9:07 [PATCH 0/6] arm64: dts: qcom: sm8[456]50: Add missing CX power domain to GCC Neil Armstrong
  2026-04-24  9:07 ` [PATCH 1/6] dt-bindings: clock: qcom: gcc-sm8450: Add missing power-domains property Neil Armstrong
  2026-04-24  9:07 ` [PATCH 2/6] dt-bindings: clock: qcom: sm8550-gcc: " Neil Armstrong
@ 2026-04-24  9:07 ` Neil Armstrong
  2026-04-24 10:46   ` Rob Herring (Arm)
  2026-04-24  9:07 ` [PATCH 4/6] arm64: dts: qcom: sm8450: Add missing CX power domain to GCC Neil Armstrong
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 16+ messages in thread
From: Neil Armstrong @ 2026-04-24  9:07 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Abel Vesa,
	Konrad Dybcio, Sai Prakash Ranjan
  Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel,
	Krzysztof Kozlowski, Neil Armstrong

In order for the GCC votes on the GDSCs it provides to be propagated
to CX, CX needs to be declared as power domain of the GCC.

Document the missing power-domains property to that purpose.

Fixes: b69d932154dc ("dt-bindings: clock: qcom: document the SM8650 General Clock Controller")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml
index c7143e2abc80..43b06e0abd1d 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml
@@ -32,9 +32,14 @@ properties:
       - description: UFS Phy Tx symbol 0 clock source
       - description: USB3 Phy wrapper pipe clock source
 
+  power-domains:
+    items:
+      - description: CX domain
+
 required:
   - compatible
   - clocks
+  - power-domains
   - '#power-domain-cells'
 
 allOf:

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 4/6] arm64: dts: qcom: sm8450: Add missing CX power domain to GCC
  2026-04-24  9:07 [PATCH 0/6] arm64: dts: qcom: sm8[456]50: Add missing CX power domain to GCC Neil Armstrong
                   ` (2 preceding siblings ...)
  2026-04-24  9:07 ` [PATCH 3/6] dt-bindings: clock: qcom: sm8650-gcc: " Neil Armstrong
@ 2026-04-24  9:07 ` Neil Armstrong
  2026-04-24  9:57   ` Konrad Dybcio
  2026-04-24 10:31   ` Abel Vesa
  2026-04-24  9:07 ` [PATCH 5/6] arm64: dts: qcom: sm8550: " Neil Armstrong
  2026-04-24  9:08 ` [PATCH 6/6] arm64: dts: qcom: sm8650: " Neil Armstrong
  5 siblings, 2 replies; 16+ messages in thread
From: Neil Armstrong @ 2026-04-24  9:07 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Abel Vesa,
	Konrad Dybcio, Sai Prakash Ranjan
  Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel,
	Krzysztof Kozlowski, Neil Armstrong

Unless CX is declared as the power-domain of GCC, votes (power and
performance) on the GDSCs it provides will not propagate to the CX,
which might result in under-voltage conditions.

Add the missing power-domains property to associate GCC with RPMHPD_CX.

Fixes: 5188049c9b36 ("arm64: dts: qcom: Add base SM8450 DTSI")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 03bf30b53f28..5aba162a952e 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -935,6 +935,7 @@ soc: soc@0 {
 		gcc: clock-controller@100000 {
 			compatible = "qcom,gcc-sm8450";
 			reg = <0x0 0x00100000 0x0 0x1f4200>;
+			power-domains = <&rpmhpd RPMHPD_CX>;
 			#clock-cells = <1>;
 			#reset-cells = <1>;
 			#power-domain-cells = <1>;

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 5/6] arm64: dts: qcom: sm8550: Add missing CX power domain to GCC
  2026-04-24  9:07 [PATCH 0/6] arm64: dts: qcom: sm8[456]50: Add missing CX power domain to GCC Neil Armstrong
                   ` (3 preceding siblings ...)
  2026-04-24  9:07 ` [PATCH 4/6] arm64: dts: qcom: sm8450: Add missing CX power domain to GCC Neil Armstrong
@ 2026-04-24  9:07 ` Neil Armstrong
  2026-04-24  9:58   ` Konrad Dybcio
  2026-04-24 10:31   ` Abel Vesa
  2026-04-24  9:08 ` [PATCH 6/6] arm64: dts: qcom: sm8650: " Neil Armstrong
  5 siblings, 2 replies; 16+ messages in thread
From: Neil Armstrong @ 2026-04-24  9:07 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Abel Vesa,
	Konrad Dybcio, Sai Prakash Ranjan
  Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel,
	Krzysztof Kozlowski, Neil Armstrong

Unless CX is declared as the power-domain of GCC, votes (power and
performance) on the GDSCs it provides will not propagate to the CX,
which might result in under-voltage conditions.

Add the missing power-domains property to associate GCC with RPMHPD_CX.

Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 912525e9bca6..bc97259b378a 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -826,6 +826,7 @@ soc: soc@0 {
 		gcc: clock-controller@100000 {
 			compatible = "qcom,sm8550-gcc";
 			reg = <0 0x00100000 0 0x1f4200>;
+			power-domains = <&rpmhpd RPMHPD_CX>;
 			#clock-cells = <1>;
 			#reset-cells = <1>;
 			#power-domain-cells = <1>;

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 6/6] arm64: dts: qcom: sm8650: Add missing CX power domain to GCC
  2026-04-24  9:07 [PATCH 0/6] arm64: dts: qcom: sm8[456]50: Add missing CX power domain to GCC Neil Armstrong
                   ` (4 preceding siblings ...)
  2026-04-24  9:07 ` [PATCH 5/6] arm64: dts: qcom: sm8550: " Neil Armstrong
@ 2026-04-24  9:08 ` Neil Armstrong
  2026-04-24 10:31   ` Abel Vesa
  2026-04-27 10:19   ` Konrad Dybcio
  5 siblings, 2 replies; 16+ messages in thread
From: Neil Armstrong @ 2026-04-24  9:08 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Abel Vesa,
	Konrad Dybcio, Sai Prakash Ranjan
  Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel,
	Krzysztof Kozlowski, Neil Armstrong

Unless CX is declared as the power-domain of GCC, votes (power and
performance) on the GDSCs it provides will not propagate to the CX,
which might result in under-voltage conditions.

Add the missing power-domains property to associate GCC with RPMHPD_CX.

Fixes: d2350377997f ("arm64: dts: qcom: add initial SM8650 dtsi")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8650.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
index 1604bc8cff37..adfb737afefe 100644
--- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
@@ -1963,6 +1963,8 @@ gcc: clock-controller@100000 {
 				 <&ufs_mem_phy 2>,
 				 <&usb_dp_qmpphy QMP_USB43DP_USB3_PIPE_CLK>;
 
+			power-domains = <&rpmhpd RPMHPD_CX>;
+
 			#clock-cells = <1>;
 			#reset-cells = <1>;
 			#power-domain-cells = <1>;

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH 4/6] arm64: dts: qcom: sm8450: Add missing CX power domain to GCC
  2026-04-24  9:07 ` [PATCH 4/6] arm64: dts: qcom: sm8450: Add missing CX power domain to GCC Neil Armstrong
@ 2026-04-24  9:57   ` Konrad Dybcio
  2026-04-24 10:31   ` Abel Vesa
  1 sibling, 0 replies; 16+ messages in thread
From: Konrad Dybcio @ 2026-04-24  9:57 UTC (permalink / raw)
  To: Neil Armstrong, Bjorn Andersson, Michael Turquette, Stephen Boyd,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Vinod Koul,
	Abel Vesa, Konrad Dybcio, Sai Prakash Ranjan
  Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel,
	Krzysztof Kozlowski

On 4/24/26 11:07 AM, Neil Armstrong wrote:
> Unless CX is declared as the power-domain of GCC, votes (power and
> performance) on the GDSCs it provides will not propagate to the CX,
> which might result in under-voltage conditions.
> 
> Add the missing power-domains property to associate GCC with RPMHPD_CX.
> 
> Fixes: 5188049c9b36 ("arm64: dts: qcom: Add base SM8450 DTSI")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 5/6] arm64: dts: qcom: sm8550: Add missing CX power domain to GCC
  2026-04-24  9:07 ` [PATCH 5/6] arm64: dts: qcom: sm8550: " Neil Armstrong
@ 2026-04-24  9:58   ` Konrad Dybcio
  2026-04-24 10:31   ` Abel Vesa
  1 sibling, 0 replies; 16+ messages in thread
From: Konrad Dybcio @ 2026-04-24  9:58 UTC (permalink / raw)
  To: Neil Armstrong, Bjorn Andersson, Michael Turquette, Stephen Boyd,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Vinod Koul,
	Abel Vesa, Konrad Dybcio, Sai Prakash Ranjan
  Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel,
	Krzysztof Kozlowski

On 4/24/26 11:07 AM, Neil Armstrong wrote:
> Unless CX is declared as the power-domain of GCC, votes (power and
> performance) on the GDSCs it provides will not propagate to the CX,
> which might result in under-voltage conditions.
> 
> Add the missing power-domains property to associate GCC with RPMHPD_CX.
> 
> Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 6/6] arm64: dts: qcom: sm8650: Add missing CX power domain to GCC
  2026-04-24  9:08 ` [PATCH 6/6] arm64: dts: qcom: sm8650: " Neil Armstrong
@ 2026-04-24 10:31   ` Abel Vesa
  2026-04-27 10:19   ` Konrad Dybcio
  1 sibling, 0 replies; 16+ messages in thread
From: Abel Vesa @ 2026-04-24 10:31 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Bjorn Andersson, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Abel Vesa,
	Konrad Dybcio, Sai Prakash Ranjan, linux-arm-msm, linux-clk,
	devicetree, linux-kernel, Krzysztof Kozlowski

On 26-04-24 11:08:00, Neil Armstrong wrote:
> Unless CX is declared as the power-domain of GCC, votes (power and
> performance) on the GDSCs it provides will not propagate to the CX,
> which might result in under-voltage conditions.
> 
> Add the missing power-domains property to associate GCC with RPMHPD_CX.
> 
> Fixes: d2350377997f ("arm64: dts: qcom: add initial SM8650 dtsi")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 5/6] arm64: dts: qcom: sm8550: Add missing CX power domain to GCC
  2026-04-24  9:07 ` [PATCH 5/6] arm64: dts: qcom: sm8550: " Neil Armstrong
  2026-04-24  9:58   ` Konrad Dybcio
@ 2026-04-24 10:31   ` Abel Vesa
  1 sibling, 0 replies; 16+ messages in thread
From: Abel Vesa @ 2026-04-24 10:31 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Bjorn Andersson, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Abel Vesa,
	Konrad Dybcio, Sai Prakash Ranjan, linux-arm-msm, linux-clk,
	devicetree, linux-kernel, Krzysztof Kozlowski

On 26-04-24 11:07:59, Neil Armstrong wrote:
> Unless CX is declared as the power-domain of GCC, votes (power and
> performance) on the GDSCs it provides will not propagate to the CX,
> which might result in under-voltage conditions.
> 
> Add the missing power-domains property to associate GCC with RPMHPD_CX.
> 
> Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 4/6] arm64: dts: qcom: sm8450: Add missing CX power domain to GCC
  2026-04-24  9:07 ` [PATCH 4/6] arm64: dts: qcom: sm8450: Add missing CX power domain to GCC Neil Armstrong
  2026-04-24  9:57   ` Konrad Dybcio
@ 2026-04-24 10:31   ` Abel Vesa
  1 sibling, 0 replies; 16+ messages in thread
From: Abel Vesa @ 2026-04-24 10:31 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Bjorn Andersson, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Abel Vesa,
	Konrad Dybcio, Sai Prakash Ranjan, linux-arm-msm, linux-clk,
	devicetree, linux-kernel, Krzysztof Kozlowski

On 26-04-24 11:07:58, Neil Armstrong wrote:
> Unless CX is declared as the power-domain of GCC, votes (power and
> performance) on the GDSCs it provides will not propagate to the CX,
> which might result in under-voltage conditions.
> 
> Add the missing power-domains property to associate GCC with RPMHPD_CX.
> 
> Fixes: 5188049c9b36 ("arm64: dts: qcom: Add base SM8450 DTSI")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/6] dt-bindings: clock: qcom: gcc-sm8450: Add missing power-domains property
  2026-04-24  9:07 ` [PATCH 1/6] dt-bindings: clock: qcom: gcc-sm8450: Add missing power-domains property Neil Armstrong
@ 2026-04-24 10:46   ` Rob Herring (Arm)
  0 siblings, 0 replies; 16+ messages in thread
From: Rob Herring (Arm) @ 2026-04-24 10:46 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Conor Dooley, Bjorn Andersson, linux-clk, linux-arm-msm,
	Abel Vesa, Michael Turquette, devicetree, Krzysztof Kozlowski,
	linux-kernel, Stephen Boyd, Konrad Dybcio, Sai Prakash Ranjan,
	Vinod Koul, Krzysztof Kozlowski


On Fri, 24 Apr 2026 11:07:55 +0200, Neil Armstrong wrote:
> In order for the GCC votes on the GDSCs it provides to be propagated
> to CX, CX needs to be declared as power domain of the GCC.
> 
> Document the missing power-domains property to that purpose.
> 
> Fixes: 72a0ca203ca7 ("dt-bindings: clock: Add SM8450 GCC clock bindings")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.example.dtb: clock-controller@100000 (qcom,gcc-sm8450): 'power-domains' is a required property
	from schema $id: http://devicetree.org/schemas/clock/qcom,gcc-sm8450.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260424-topic-sm8x50-tie-gcc-to-cx-v1-1-4b6e09d532ce@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 2/6] dt-bindings: clock: qcom: sm8550-gcc: Add missing power-domains property
  2026-04-24  9:07 ` [PATCH 2/6] dt-bindings: clock: qcom: sm8550-gcc: " Neil Armstrong
@ 2026-04-24 10:46   ` Rob Herring (Arm)
  0 siblings, 0 replies; 16+ messages in thread
From: Rob Herring (Arm) @ 2026-04-24 10:46 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Konrad Dybcio, Stephen Boyd, Conor Dooley, Sai Prakash Ranjan,
	linux-arm-msm, Bjorn Andersson, Michael Turquette,
	Krzysztof Kozlowski, Vinod Koul, Krzysztof Kozlowski,
	linux-kernel, Abel Vesa, linux-clk, devicetree


On Fri, 24 Apr 2026 11:07:56 +0200, Neil Armstrong wrote:
> In order for the GCC votes on the GDSCs it provides to be propagated
> to CX, CX needs to be declared as power domain of the GCC.
> 
> Document the missing power-domains property to that purpose.
> 
> Fixes: 47ba9c50bbeb ("dt-bindings: clock: Add SM8550 GCC clocks")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.example.dtb: clock-controller@100000 (qcom,sm8550-gcc): 'power-domains' is a required property
	from schema $id: http://devicetree.org/schemas/clock/qcom,sm8550-gcc.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260424-topic-sm8x50-tie-gcc-to-cx-v1-2-4b6e09d532ce@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/6] dt-bindings: clock: qcom: sm8650-gcc: Add missing power-domains property
  2026-04-24  9:07 ` [PATCH 3/6] dt-bindings: clock: qcom: sm8650-gcc: " Neil Armstrong
@ 2026-04-24 10:46   ` Rob Herring (Arm)
  0 siblings, 0 replies; 16+ messages in thread
From: Rob Herring (Arm) @ 2026-04-24 10:46 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Vinod Koul, Abel Vesa, linux-kernel, Krzysztof Kozlowski,
	linux-arm-msm, Sai Prakash Ranjan, Conor Dooley, linux-clk,
	Stephen Boyd, Bjorn Andersson, Michael Turquette, Konrad Dybcio,
	Krzysztof Kozlowski, devicetree


On Fri, 24 Apr 2026 11:07:57 +0200, Neil Armstrong wrote:
> In order for the GCC votes on the GDSCs it provides to be propagated
> to CX, CX needs to be declared as power domain of the GCC.
> 
> Document the missing power-domains property to that purpose.
> 
> Fixes: b69d932154dc ("dt-bindings: clock: qcom: document the SM8650 General Clock Controller")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.example.dtb: clock-controller@100000 (qcom,sm8650-gcc): 'power-domains' is a required property
	from schema $id: http://devicetree.org/schemas/clock/qcom,sm8650-gcc.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260424-topic-sm8x50-tie-gcc-to-cx-v1-3-4b6e09d532ce@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 6/6] arm64: dts: qcom: sm8650: Add missing CX power domain to GCC
  2026-04-24  9:08 ` [PATCH 6/6] arm64: dts: qcom: sm8650: " Neil Armstrong
  2026-04-24 10:31   ` Abel Vesa
@ 2026-04-27 10:19   ` Konrad Dybcio
  1 sibling, 0 replies; 16+ messages in thread
From: Konrad Dybcio @ 2026-04-27 10:19 UTC (permalink / raw)
  To: Neil Armstrong, Bjorn Andersson, Michael Turquette, Stephen Boyd,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Vinod Koul,
	Abel Vesa, Konrad Dybcio, Sai Prakash Ranjan
  Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel,
	Krzysztof Kozlowski

On 4/24/26 11:08 AM, Neil Armstrong wrote:
> Unless CX is declared as the power-domain of GCC, votes (power and
> performance) on the GDSCs it provides will not propagate to the CX,
> which might result in under-voltage conditions.
> 
> Add the missing power-domains property to associate GCC with RPMHPD_CX.
> 
> Fixes: d2350377997f ("arm64: dts: qcom: add initial SM8650 dtsi")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2026-04-27 10:19 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-24  9:07 [PATCH 0/6] arm64: dts: qcom: sm8[456]50: Add missing CX power domain to GCC Neil Armstrong
2026-04-24  9:07 ` [PATCH 1/6] dt-bindings: clock: qcom: gcc-sm8450: Add missing power-domains property Neil Armstrong
2026-04-24 10:46   ` Rob Herring (Arm)
2026-04-24  9:07 ` [PATCH 2/6] dt-bindings: clock: qcom: sm8550-gcc: " Neil Armstrong
2026-04-24 10:46   ` Rob Herring (Arm)
2026-04-24  9:07 ` [PATCH 3/6] dt-bindings: clock: qcom: sm8650-gcc: " Neil Armstrong
2026-04-24 10:46   ` Rob Herring (Arm)
2026-04-24  9:07 ` [PATCH 4/6] arm64: dts: qcom: sm8450: Add missing CX power domain to GCC Neil Armstrong
2026-04-24  9:57   ` Konrad Dybcio
2026-04-24 10:31   ` Abel Vesa
2026-04-24  9:07 ` [PATCH 5/6] arm64: dts: qcom: sm8550: " Neil Armstrong
2026-04-24  9:58   ` Konrad Dybcio
2026-04-24 10:31   ` Abel Vesa
2026-04-24  9:08 ` [PATCH 6/6] arm64: dts: qcom: sm8650: " Neil Armstrong
2026-04-24 10:31   ` Abel Vesa
2026-04-27 10:19   ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox