Re: [PATCH 2/2] arm64: dts: allwinner: h6: Add OrangePi 3 LTS DTS

["Jernej Škrabec" <jernej.skrabec@gmail.com>]

Dne ponedeljek, 28. april 2025 ob 14:37:48 Srednjeevropski poletni čas je Andrew Lunn napisal(a):
> On Sat, Apr 26, 2025 at 08:00:49PM +0200, Jernej Škrabec wrote:
> > Dne petek, 25. april 2025 ob 17:34:14 Srednjeevropski poletni čas je Andrew Lunn napisal(a):
> > > > > +&emac {
> > > > > +	pinctrl-names = "default";
> > > > > +	pinctrl-0 = <&ext_rgmii_pins>;
> > > > > +	phy-mode = "rgmii-rxid";
> > > > 
> > > > So relating to what Andrew said earlier today, should this read rgmii-id
> > > > instead? Since the strap resistors just set some boot-up value, but we
> > > > want the PHY driver to enable both RX and TX delay programmatically?
> > > 
> > > Yes.
> > > 
> > > There is a checkpatch.pl patch working its way through the system
> > > which will add warning about any rgmii value other than rgmii-id. Such
> > > values need a comment that the PCB has extra long clock
> > > lines. Hopefully that will make people actually stop and think about
> > > this, rather than just copy broken vendor code.
> > 
> > I spent quite some time working on ethernet support for this board. Once
> > I've found PHY datasheet, I confirmed that there is added delay. So this
> > particular board needs "rgmii-rxid" mode.
> 
> There have been numerous discussions about what these rgmii modes
> mean, because DT developers frequently get them wrong.
> 
> Does the PCB have an extra long clock line in the TX direction? That
> is what rgmii-rxid means, the PCB is providing the TX delay, the
> MAC/PHY pair needs to add the RX delay.

While schematic is accessible, AFAIK PCB/gerbers are not, so I can't really
tell how long it is. But without this extra delay, ethernet doesn't work.

> 
> Ignore strapping. That is just a power on default which gets over
> ridden once the PHY driver is running.
> 
> What PHY is this?

Motorcomm YT8531C.

Best regards,
Jernej

> 
> 	Andrew
>