[PATCH v2 0/3] arm64: dts: qcom: sa8775p: Update memory map for derived IOT boards

[PATCH v2 0/3] arm64: dts: qcom: sa8775p: Update memory map for derived IOT boards

[Pratyush Brahma]

IOT boards derived from SA8775P have a slightly different
memory map compared to SA8775P. This series applies the
updated memory map to those boards.

One of the patches in this series depends on Wasim Nazir's
patches [1] to introduce the qcs9075* boards.

[1] https://lore.kernel.org/all/20241229152332.3068172-1-quic_wasimn@quicinc.com/

Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
---
Changes in v2:
- Moved duplicate entries to a new dtsi as per Dmitry's suggestions
- Removed hyp_tz_reserved_mem as well
- Link to v1: https://lore.kernel.org/all/20241119092501.31111-1-quic_pbrahma@quicinc.com

---
Pratyush Brahma (3):
      arm64: dts: qcom: sa8775p-iot: Introduce new memory map
      arm64: dts: qcom: qcs9100: Update memory map
      arm64: dts: qcom: qcs9075: Update memory map

 arch/arm64/boot/dts/qcom/qcs9075-rb8.dts     |   1 +
 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts |   1 +
 arch/arm64/boot/dts/qcom/qcs9075-ride.dts    |   1 +
 arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts |   2 +
 arch/arm64/boot/dts/qcom/qcs9100-ride.dts    |   2 +
 arch/arm64/boot/dts/qcom/sa8775p-iot.dtsi    | 105 +++++++++++++++++++++++++++
 6 files changed, 112 insertions(+)
---
base-commit: 9e06a6867520aed8a65718fd06464b9d2ff397fe
change-id: 20250113-sa8775p-iot-memory-map-0ca991c818c1

Best regards,
-- 
Pratyush Brahma <quic_pbrahma@quicinc.com>

[PATCH v2 1/3] arm64: dts: qcom: sa8775p-iot: Introduce new memory map

[Pratyush Brahma]

SA8775P has a memory map which caters to the auto specific requirements.
IOT boards (viz. QCS9100*, QCS9075*) which inherit the memory map of
SA8775P require a slightly different memory map as compared to
SA8775P auto parts. This dtsi describes the updated memory map
applicable for all the IOT boards which inherit the initial SA8775P
memory map. This is not applicable for non-IOT boards.

Some new carveouts (viz. gunyah_md and a few pil dtb carveouts) have been
introduced and the size and base addresses have been updated for
a few of existing carveouts compared to SA8775P. Also, tz_ffi_mem carveout
and its corresponding scm reference has been removed as it is not required
for these boards. Incorporate these changes in the updated memory map.

Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sa8775p-iot.dtsi | 105 ++++++++++++++++++++++++++++++
 1 file changed, 105 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p-iot.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-iot.dtsi
new file mode 100644
index 0000000000000000000000000000000000000000..6252294ff7c32be1a0a9c4f7ed3d4422e99f98df
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sa8775p-iot.dtsi
@@ -0,0 +1,105 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/delete-node/ &pil_adsp_mem;
+/delete-node/ &pil_gdsp0_mem;
+/delete-node/ &pil_gdsp1_mem;
+/delete-node/ &pil_cdsp0_mem;
+/delete-node/ &pil_gpu_mem;
+/delete-node/ &pil_cdsp1_mem;
+/delete-node/ &pil_cvp_mem;
+/delete-node/ &pil_video_mem;
+/delete-node/ &audio_mdf_mem;
+/delete-node/ &hyptz_reserved_mem;
+/delete-node/ &trusted_apps_mem;
+
+/ {
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		gunyah_md_mem: gunyah-md@91a80000 {
+			reg = <0x0 0x91a80000 0x0 0x80000>;
+			no-map;
+		};
+
+		pil_adsp_mem: pil-adsp@95900000 {
+			reg = <0x0 0x95900000 0x0 0x1e00000>;
+			no-map;
+		};
+
+		q6_adsp_dtb_mem: q6-adsp-dtb@97700000 {
+			reg = <0x0 0x97700000 0x0 0x80000>;
+			no-map;
+		};
+
+		q6_gdsp0_dtb_mem: q6-gdsp0-dtb@97780000 {
+			reg = <0x0 0x97780000 0x0 0x80000>;
+			no-map;
+		};
+
+		pil_gdsp0_mem: pil-gdsp0@97800000 {
+			reg = <0x0 0x97800000 0x0 0x1e00000>;
+			no-map;
+		};
+
+		pil_gdsp1_mem: pil-gdsp1@99600000 {
+			reg = <0x0 0x99600000 0x0 0x1e00000>;
+			no-map;
+		};
+
+		q6_gdsp1_dtb_mem: q6-gdsp1-dtb@9b400000 {
+			reg = <0x0 0x9b400000 0x0 0x80000>;
+			no-map;
+		};
+
+		q6_cdsp0_dtb_mem: q6-cdsp0-dtb@9b480000 {
+			reg = <0x0 0x9b480000 0x0 0x80000>;
+			no-map;
+		};
+
+		pil_cdsp0_mem: pil-cdsp0@9b500000 {
+			reg = <0x0 0x9b500000 0x0 0x1e00000>;
+			no-map;
+		};
+
+		pil_gpu_mem: pil-gpu@9d300000 {
+			reg = <0x0 0x9d300000 0x0 0x2000>;
+			no-map;
+		};
+
+		q6_cdsp1_dtb_mem: q6-cdsp1-dtb@9d380000 {
+			reg = <0x0 0x9d380000 0x0 0x80000>;
+			no-map;
+		};
+
+		pil_cdsp1_mem: pil-cdsp1@9d400000 {
+			reg = <0x0 0x9d400000 0x0 0x1e00000>;
+			no-map;
+		};
+
+		pil_cvp_mem: pil-cvp@9f200000 {
+			reg = <0x0 0x9f200000 0x0 0x700000>;
+			no-map;
+		};
+
+		pil_video_mem: pil-video@9f900000 {
+			reg = <0x0 0x9f900000 0x0 0x1000000>;
+			no-map;
+		};
+
+		trusted_apps_mem: trusted-apps@d1900000 {
+			reg = <0x0 0xd1900000 0x0 0x1c00000>;
+			no-map;
+		};
+	};
+
+	firmware {
+		scm {
+			/delete-property/ memory-region;
+		};
+	};
+};

-- 
2.22.0

[PATCH v2 2/3] arm64: dts: qcom: qcs9100: Update memory map

[Pratyush Brahma]

Update the iot specific memory map for qcs9100* boards.

Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++
 arch/arm64/boot/dts/qcom/qcs9100-ride.dts    | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
index 759d1ec694b20e9cead674c1bd61c6a6627eeb27..06e57239bbe975b9c0b939d438095692243e39cf 100644
--- a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
+++ b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
@@ -5,6 +5,8 @@
 /dts-v1/;
 
 #include "sa8775p-ride-r3.dts"
+#include "sa8775p-iot.dtsi"
+
 / {
 	model = "Qualcomm QCS9100 Ride Rev3";
 	compatible = "qcom,qcs9100-ride-r3", "qcom,qcs9100", "qcom,sa8775p";
diff --git a/arch/arm64/boot/dts/qcom/qcs9100-ride.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride.dts
index 979462dfec30ecbe6c437fd676c3da2d4386ff8e..27d5461acbf070d696cdad0c068f4e031f2beb67 100644
--- a/arch/arm64/boot/dts/qcom/qcs9100-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs9100-ride.dts
@@ -5,6 +5,8 @@
 /dts-v1/;
 
 #include "sa8775p-ride.dts"
+#include "sa8775p-iot.dtsi"
+
 / {
 	model = "Qualcomm QCS9100 Ride";
 	compatible = "qcom,qcs9100-ride", "qcom,qcs9100", "qcom,sa8775p";

-- 
2.22.0

Re: [PATCH v2 2/3] arm64: dts: qcom: qcs9100: Update memory map

[Krzysztof Kozlowski]

On 13/01/2025 13:13, Pratyush Brahma wrote:
> Update the iot specific memory map for qcs9100* boards.
> 
> Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++
>  arch/arm64/boot/dts/qcom/qcs9100-ride.dts    | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> index 759d1ec694b20e9cead674c1bd61c6a6627eeb27..06e57239bbe975b9c0b939d438095692243e39cf 100644
> --- a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> @@ -5,6 +5,8 @@
>  /dts-v1/;
>  
>  #include "sa8775p-ride-r3.dts"
> +#include "sa8775p-iot.dtsi"

No. Either this is car or iot. Cannot be both.

In other threads I already complained you add some artificial split of
DTS/DTSI and not describing the hardware. This is another example of
that - you claim you have automotive board, which is derived from
automotive board, but it is not automotive and instead it is iot.

Decide about all this and come with DTS/DTSI structure reflecting actual
hardware, not how you want to organize your device nodes.

Best regards,
Krzysztof

Re: [PATCH v2 2/3] arm64: dts: qcom: qcs9100: Update memory map

[Krzysztof Kozlowski]

On 13/01/2025 13:13, Pratyush Brahma wrote:
> Update the iot specific memory map for qcs9100* boards.

Why?

Every single time. Don't say what, we see it easily. Say why.

> 
> Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++
>  arch/arm64/boot/dts/qcom/qcs9100-ride.dts    | 2 ++
>  2 files changed, 4 insertions(+)
> 

Best regards,
Krzysztof

Re: [PATCH v2 2/3] arm64: dts: qcom: qcs9100: Update memory map

[Pratyush Brahma]

On 1/13/2025 5:50 PM, Krzysztof Kozlowski wrote:
> On 13/01/2025 13:13, Pratyush Brahma wrote:
>> Update the iot specific memory map for qcs9100* boards.
> Why?
>
> Every single time. Don't say what, we see it easily. Say why.
I assumed incorrectly it would be perhaps enough to have mentioned
this in patch 1 of this series and the cover letter, so didn't mention here.

Can you please review the memory map changes in patch 1 as well?
Once the strategy for the dts changes are baked in internally with the
current reviews, I will send out another series incorporating the comments
with the memory map changes.
>> Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++
>>   arch/arm64/boot/dts/qcom/qcs9100-ride.dts    | 2 ++
>>   2 files changed, 4 insertions(+)
>>
> Best regards,
> Krzysztof

-- 
Thanks and Regards
Pratyush Brahma

Re: [PATCH v2 2/3] arm64: dts: qcom: qcs9100: Update memory map

[Dmitry Baryshkov]

On Mon, Jan 13, 2025 at 06:08:26PM +0530, Pratyush Brahma wrote:
> 
> On 1/13/2025 5:50 PM, Krzysztof Kozlowski wrote:
> > On 13/01/2025 13:13, Pratyush Brahma wrote:
> > > Update the iot specific memory map for qcs9100* boards.
> > Why?
> > 
> > Every single time. Don't say what, we see it easily. Say why.
> I assumed incorrectly it would be perhaps enough to have mentioned
> this in patch 1 of this series and the cover letter, so didn't mention here.

You wrote it in the patch 1, so it covered SA8775P-Ride boards. This
patch concerns QCS9100 boards. So it is a completely separate topic.

> Can you please review the memory map changes in patch 1 as well?
> Once the strategy for the dts changes are baked in internally with the

Please. Please. s/internally/externally/. Start discussing things on the
MLs rather than baking the solution internally and then being surprised
when the bakery isn't being accepted by the community.

> current reviews, I will send out another series incorporating the comments
> with the memory map changes.
> > > Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
> > > ---
> > >   arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++
> > >   arch/arm64/boot/dts/qcom/qcs9100-ride.dts    | 2 ++
> > >   2 files changed, 4 insertions(+)
> > > 
> > Best regards,
> > Krzysztof
> 
> -- 
> Thanks and Regards
> Pratyush Brahma
> 

-- 
With best wishes
Dmitry

[PATCH v2 3/3] arm64: dts: qcom: qcs9075: Update memory map

[Pratyush Brahma]

Update the iot specific memory map for qcs9075* boards.

This depends on Wasim Nazir's patches [1] to introduce
qcs9075 boards.

[1] https://lore.kernel.org/all/20241229152332.3068172-1-quic_wasimn@quicinc.com/

Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs9075-rb8.dts     | 1 +
 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 1 +
 arch/arm64/boot/dts/qcom/qcs9075-ride.dts    | 1 +
 3 files changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs9075-rb8.dts b/arch/arm64/boot/dts/qcom/qcs9075-rb8.dts
index 3ab6deeaacf18eb4d5859f1bbb80c244bf8f224c..4458e2db2f3f2b222376b92e5c46c6557a1583b3 100644
--- a/arch/arm64/boot/dts/qcom/qcs9075-rb8.dts
+++ b/arch/arm64/boot/dts/qcom/qcs9075-rb8.dts
@@ -10,6 +10,7 @@
 #include "sa8775p.dtsi"
 #include "sa8775p-pmics.dtsi"
 #include "qcs9075-thermal.dtsi"
+#include "sa8775p-iot.dtsi"
 
 / {
 	model = "Qualcomm Technologies, Inc. Robotics RB8";
diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts
index 5f2d9f4166172a85f8d69f6cd8813d4469de5bd3..231c1e3f73eb3e11dc50bbebb1773e31a0c71723 100644
--- a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts
+++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts
@@ -6,6 +6,7 @@
 
 #include "sa8775p-ride.dtsi"
 #include "qcs9075-thermal.dtsi"
+#include "sa8775p-iot.dtsi"
 
 / {
 	model = "Qualcomm Technologies, Inc. QCS9075 Ride Rev3";
diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride.dts
index 10ce48e7ba2f53a6daef8beba4d29d2907990baf..3d85a7636adb2d9462308d48cf0431e266807af7 100644
--- a/arch/arm64/boot/dts/qcom/qcs9075-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs9075-ride.dts
@@ -6,6 +6,7 @@
 
 #include "sa8775p-ride.dtsi"
 #include "qcs9075-thermal.dtsi"
+#include "sa8775p-iot.dtsi"
 
 / {
 	model = "Qualcomm Technologies, Inc. QCS9075 Ride";

-- 
2.22.0