Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Acer Swift Go Pro AI (SFA14-11)

[Kaipeng Zeng <kaipeng94@gmail.com>]

On 7/2/26 17:32, Krzysztof Kozlowski wrote:
> On 02/07/2026 11:29, Konrad Dybcio wrote:
>> On 7/2/26 8:27 AM, Krzysztof Kozlowski wrote:
>>> On 02/07/2026 08:31, Kaipeng Zeng wrote:
>>>> Add compatible values for the Acer Swift Go Pro AI (SFA14-11),
>>>> using "acer,sfa14-11".
>>>
>>> "Add Acer Swift Go Pro AI (SFA14-11), a laptop based on the Snapdragon X
>>> Elite (X1E78100) SoC."
>>>
>>> That's it. Don't add unnecessary boilerplate.
>>>
>>>
>>>>
>>>> The laptop is based on the Snapdragon X Elite (X1E78100) SoC.
>>>>
>>>> Signed-off-by: Kaipeng Zeng <kaipeng94@gmail.com>
>>>> ---
>>>>   Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>> index 50cc18a6ec5e..6b997d615bad 100644
>>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>> @@ -1142,6 +1142,7 @@ properties:
>>>>   
>>>>         - items:
>>>>             - enum:
>>>> +              - acer,sfa14-11
>>>
>>> Why no user-recognizable name is used? Look at other consumer products:
>>> lenovo,thinkpad-x13s, lenovo,flex-5g, microsoft,surface-prox,
>>> lenovo,thinkpad-t14s-lcd, tuxedo,elite14gen1, microsoft,denali,
>>> asus,vivobook-s15... and so on.
>>
>> We have a good mix of both. I tend to dislike relying on marketing
>> names, as they may be similar (or identical) across wholly different
>> products.
>>
>> e.g. microsoft,denali that you mentioned is a MS codename for the
>> Surface Pro something something
> 
> I am fine with mixing (swift-go-sfa14-11), but the model number alone is
> very hard to parse by humans.
> 
> Best regards,
> Krzysztof

Initially, I chose the model number because Acer has several QCOM 
powered laptops with similar product names:
  - Acer Swift Go Pro AI (SFA14-11)
  - Acer Swift Go 14 AI (SFG14-*)
  - Acer Swift Spin 14 AI (SFSP14-Q51T)
  - Acer Swift 14 AI (SF14-11*)

Using the product name directly here can be confusing.
I think using a mixed name (swift-go-sfa14-11) is better, too.