Devicetree
 help / color / mirror / Atom feed
From: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
To: "krzk@kernel.org" <krzk@kernel.org>
Cc: Djordje Todorovic <Djordje.Todorovic@htecgroup.com>,
	Aleksa Paunovic <aleksa.paunovic@htecgroup.com>,
	"alex@ghiti.fr" <alex@ghiti.fr>,
	"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
	"cfu@mips.com" <cfu@mips.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"conor.dooley@microchip.com" <conor.dooley@microchip.com>,
	"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"jstultz@google.com" <jstultz@google.com>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	"palmer@dabbelt.com" <palmer@dabbelt.com>,
	"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
	"pjw@kernel.org" <pjw@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"sboyd@kernel.org" <sboyd@kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"wangruikang@iscas.ac.cn" <wangruikang@iscas.ac.cn>
Subject: Re: [PATCH v8 1/3] dt-bindings: timer: mips,p8700-gcru
Date: Thu, 11 Jun 2026 11:51:14 +0000	[thread overview]
Message-ID: <7027c47b-7890-4850-976f-50a1c8cfbeca@htecgroup.com> (raw)
In-Reply-To: <a2b5c9b4-5fc0-4507-a221-8695ed9574d8@kernel.org>

On 6/11/26 09:50, Krzysztof Kozlowski wrote:
> On 11/06/2026 09:39, Aleksa Paunovic wrote:
>> Hi Krzysztof,
>>
>>
>> On 6/11/26 08:54, Krzysztof Kozlowski wrote:
>>> On 11/06/2026 08:51, Krzysztof Kozlowski wrote:
>>>> On 10/06/2026 10:22, Aleksa Paunovic via B4 Relay wrote:
>>>>> From: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
>>>>>
>>>>> Add dt-bindings for the GCR.U memory mapped timer device for RISC-V
>>>>> platforms. The GCR.U memory region contains shadow copies of the RISC-V
>>>>> mtime register and the hrtime Global Configuration Register.
>>>>>
>>>>> Signed-off-by: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
>>>> You keep ignoring reviews you received (14th May!) and sending same mistake.
>>>>
>>>> Can you address the emails?
>> I wasn't really sure what the etiquette was for replying to Sashiko reviews, so I decided to
>> address the comments for other patches and send a v8 without replying.
>>
>> As for this patch, the GCR.U itself does start at 0x7F000, but the first
>> actual register (mtime) is at 0x7F050 [1].
>> I'm not seeing any warnings when running dt_binding_check.
> It's still a warning which you can easily reproduce on W=1 on dts. You
> CANNOT have mismatch. If block starts at 0x7f000, first register CANNOT
> start at different address or it completely does not matter where the
> register is. It's contradictory. The block start address defines
> where... does it start.

You are right: I just checked by manually running dtc and the warning's clearly there.
Will fix the alignment in v9. Thanks!
 

Best regards,
Aleksa 

  reply	other threads:[~2026-06-11 11:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10  8:22 [PATCH v8 0/3] riscv: Use GCR.U timer device as clocksource Aleksa Paunovic via B4 Relay
2026-06-10  8:22 ` [PATCH v8 1/3] dt-bindings: timer: mips,p8700-gcru Aleksa Paunovic via B4 Relay
2026-06-10  8:26   ` sashiko-bot
2026-06-10 16:18     ` Conor Dooley
2026-06-11  6:51   ` Krzysztof Kozlowski
2026-06-11  6:54     ` Krzysztof Kozlowski
2026-06-11  7:39       ` Aleksa Paunovic
2026-06-11  7:50         ` Krzysztof Kozlowski
2026-06-11 11:51           ` Aleksa Paunovic [this message]
2026-06-10  8:22 ` [PATCH v8 2/3] riscv: clocksource: Add readq options to clocksource mmio Aleksa Paunovic via B4 Relay
2026-06-10  8:22 ` [PATCH v8 3/3] riscv: clocksource: Add p8700-gcru driver Aleksa Paunovic via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7027c47b-7890-4850-976f-50a1c8cfbeca@htecgroup.com \
    --to=aleksa.paunovic@htecgroup.com \
    --cc=Djordje.Todorovic@htecgroup.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=cfu@mips.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jstultz@google.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wangruikang@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox