[PATCH 0/6] drm/v3d: Fix GPU reset issues on the Raspberry Pi 5

[PATCH 0/6] drm/v3d: Fix GPU reset issues on the Raspberry Pi 5

[Maíra Canal]

This series addresses GPU reset issues reported in [1], where running a
long compute job would trigger repeated GPU resets, leading to a UI
freeze.

Patches #1 and #2 prevent the same faulty job from being resubmitted in a
loop, mitigating the first cause of the issue.

However, the issue isn't entirely solved. Even with only a single GPU
reset, the UI still freezes on the Raspberry Pi 5, indicating a GPU hang.
Patches #3 to #5 address this by properly configuring the V3D_SMS
registers, which are required for power management and resets in V3D 7.1.

Patch #6 updates the DT maintainership, replacing Emma with the current
v3d driver maintainer.

[1] https://github.com/raspberrypi/linux/issues/6660

Best Regards,
- Maíra

---
Maíra Canal (6):
      drm/v3d: Don't run jobs that have errors flagged in its fence
      drm/v3d: Set job pointer to NULL when the job's fence has an error
      drm/v3d: Associate a V3D tech revision to all supported devices
      dt-bindings: gpu: v3d: Add SMS to the registers' list
      drm/v3d: Use V3D_SMS registers for power on/off and reset on V3D 7.x
      dt-bindings: gpu: Add V3D driver maintainer as DT maintainer

 .../devicetree/bindings/gpu/brcm,bcm-v3d.yaml      |  8 +--
 drivers/gpu/drm/v3d/v3d_drv.c                      | 58 ++++++++++++++++++++--
 drivers/gpu/drm/v3d/v3d_drv.h                      | 18 +++++++
 drivers/gpu/drm/v3d/v3d_gem.c                      | 17 +++++++
 drivers/gpu/drm/v3d/v3d_regs.h                     | 26 ++++++++++
 drivers/gpu/drm/v3d/v3d_sched.c                    | 23 +++++++--
 6 files changed, 140 insertions(+), 10 deletions(-)
---
base-commit: 099b79f94366f3110783301e20d8136d762247f8
change-id: 20250224-v3d-gpu-reset-fixes-2d21fc70711d

[PATCH 4/6] dt-bindings: gpu: v3d: Add SMS to the registers' list

[Maíra Canal]

V3D 7.1 exposes a new register block, called V3D_SMS. As BCM2712 has a
V3D 7.1 core, add a new register item to the list. Similar to the GCA
and bridge register, SMS is optional and should only be added for V3D
7.1 variants.

Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>
Cc: devicetree@vger.kernel.org
Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
index dc078ceeca9ac3447ba54a7c8830821f0b2a7f9f..8a3d3fc6065d7756da141bda4dc522f63be5e9a1 100644
--- a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
+++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
@@ -27,14 +27,16 @@ properties:
       - description: core0 register (required)
       - description: GCA cache controller register (if GCA controller present)
       - description: bridge register (if no external reset controller)
+      - description: SMS register (if SMS controller present)
     minItems: 2
 
   reg-names:
     items:
       - const: hub
       - const: core0
-      - enum: [ bridge, gca ]
-      - enum: [ bridge, gca ]
+      - enum: [ bridge, gca, sms ]
+      - enum: [ bridge, gca, sms ]
+      - enum: [ bridge, gca, sms ]
     minItems: 2
 
   interrupts:

-- 
Git-154)

Re: [PATCH 4/6] dt-bindings: gpu: v3d: Add SMS to the registers' list

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]

On Wed, Feb 26, 2025 at 04:59:02PM -0300, Maíra Canal wrote:
> V3D 7.1 exposes a new register block, called V3D_SMS. As BCM2712 has a
> V3D 7.1 core, add a new register item to the list. Similar to the GCA
> and bridge register, SMS is optional and should only be added for V3D
> 7.1 variants.
> 
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
> index dc078ceeca9ac3447ba54a7c8830821f0b2a7f9f..8a3d3fc6065d7756da141bda4dc522f63be5e9a1 100644
> --- a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
> +++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
> @@ -27,14 +27,16 @@ properties:
>        - description: core0 register (required)
>        - description: GCA cache controller register (if GCA controller present)
>        - description: bridge register (if no external reset controller)
> +      - description: SMS register (if SMS controller present)
>      minItems: 2
>  
>    reg-names:
>      items:
>        - const: hub
>        - const: core0
> -      - enum: [ bridge, gca ]
> -      - enum: [ bridge, gca ]
> +      - enum: [ bridge, gca, sms ]
> +      - enum: [ bridge, gca, sms ]
> +      - enum: [ bridge, gca, sms ]
>      minItems: 2

Can you add a per-compatible restriction, to only allow maxItems: 2
when the compatible is not mcb2712 please?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH 6/6] dt-bindings: gpu: Add V3D driver maintainer as DT maintainer

[Maíra Canal]

As established in commit 89d04995f76c ("MAINTAINERS: Drop Emma Anholt
from all M lines."), Emma is no longer active in the Linux kernel and
dropped the V3D maintainership. Therefore, remove Emma as one of the DT
maintainers and add the current V3D driver maintainer.

Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>
Cc: devicetree@vger.kernel.org
Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
index 8a3d3fc6065d7756da141bda4dc522f63be5e9a1..13eaa1a40485153eea0e5d4bb164009d1030e314 100644
--- a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
+++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
@@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 title: Broadcom V3D GPU
 
 maintainers:
-  - Eric Anholt <eric@anholt.net>
+  - Maíra Canal <mcanal@igalia.com>
   - Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
 
 properties:

-- 
Git-154)

Re: [PATCH 6/6] dt-bindings: gpu: Add V3D driver maintainer as DT maintainer

[Rob Herring (Arm)]

On Wed, 26 Feb 2025 16:59:04 -0300, Maíra Canal wrote:
> As established in commit 89d04995f76c ("MAINTAINERS: Drop Emma Anholt
> from all M lines."), Emma is no longer active in the Linux kernel and
> dropped the V3D maintainership. Therefore, remove Emma as one of the DT
> maintainers and add the current V3D driver maintainer.
> 
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 0/6] drm/v3d: Fix GPU reset issues on the Raspberry Pi 5

[Iago Toral]

Thanks Maíra, all patches but 4 are:

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>

I hope someone else can can look at the remaining DT patch.

Iago

El mié, 26-02-2025 a las 16:58 -0300, Maíra Canal escribió:
> This series addresses GPU reset issues reported in [1], where running
> a
> long compute job would trigger repeated GPU resets, leading to a UI
> freeze.
> 
> Patches #1 and #2 prevent the same faulty job from being resubmitted
> in a
> loop, mitigating the first cause of the issue.
> 
> However, the issue isn't entirely solved. Even with only a single GPU
> reset, the UI still freezes on the Raspberry Pi 5, indicating a GPU
> hang.
> Patches #3 to #5 address this by properly configuring the V3D_SMS
> registers, which are required for power management and resets in V3D
> 7.1.
> 
> Patch #6 updates the DT maintainership, replacing Emma with the
> current
> v3d driver maintainer.
> 
> [1] https://github.com/raspberrypi/linux/issues/6660
> 
> Best Regards,
> - Maíra
> 
> ---
> Maíra Canal (6):
>       drm/v3d: Don't run jobs that have errors flagged in its fence
>       drm/v3d: Set job pointer to NULL when the job's fence has an
> error
>       drm/v3d: Associate a V3D tech revision to all supported devices
>       dt-bindings: gpu: v3d: Add SMS to the registers' list
>       drm/v3d: Use V3D_SMS registers for power on/off and reset on
> V3D 7.x
>       dt-bindings: gpu: Add V3D driver maintainer as DT maintainer
> 
>  .../devicetree/bindings/gpu/brcm,bcm-v3d.yaml      |  8 +--
>  drivers/gpu/drm/v3d/v3d_drv.c                      | 58
> ++++++++++++++++++++--
>  drivers/gpu/drm/v3d/v3d_drv.h                      | 18 +++++++
>  drivers/gpu/drm/v3d/v3d_gem.c                      | 17 +++++++
>  drivers/gpu/drm/v3d/v3d_regs.h                     | 26 ++++++++++
>  drivers/gpu/drm/v3d/v3d_sched.c                    | 23 +++++++--
>  6 files changed, 140 insertions(+), 10 deletions(-)
> ---
> base-commit: 099b79f94366f3110783301e20d8136d762247f8
> change-id: 20250224-v3d-gpu-reset-fixes-2d21fc70711d
> 
>