Re: [PATCH v6 03/21] dt-bindings: riscv: add Sxcsrind ISA extension description

[Atish Patra <atish.patra@linux.dev>]

On 6/8/26 11:09 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Low] The `sscsrind` extension is inserted out of alphanumeric order, violating the explicit formatting rule in the binding file.
> - [Low] The description for `smcsrind` contains a copy-paste error incorrectly labeling it as a 'supervisor-level' extension, and both `smcsrind` and `sscsrind` contain a grammatical typo.
> --
>
> commit a4e1326a37463e042ca0a72ff72d93f2be1d22f8
> Author: Atish Patra <atishp@rivosinc.com>
>
> dt-bindings: riscv: add Sxcsrind ISA extension description
>
> Add the S[m|s]csrind ISA extension description.
>
>> diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml
>> index 2b0a8a93bb214..4be557dc215de 100644
>> --- a/Documentation/devicetree/bindings/riscv/extensions.yaml
>> +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml
>> @@ -181,6 +181,14 @@ properties:
>>               changes to interrupts as frozen at commit ccbddab ("Merge pull
>>               request #42 from riscv/jhauser-2023-RC4") of riscv-aia.
>>   
>> +        - const: smcsrind
>> +          description: |
>> +            The standard Smcsrind supervisor-level extension extends the
>> +            indirect CSR access mechanism defined by the Smaia extension. This
> [Severity: Low]
> Is this description accurate for smcsrind? The m in Smcsrind indicates
> it is a machine-level extension, rather than a supervisor-level extension.
>
>> +            extension allows other ISA extension to use indirect CSR access
> [Severity: Low]
> This isn't a bug, but there is a typo here. Should "ISA extension" be
> pluralized to "ISA extensions"?
>
>> +            mechanism in M-mode as ratified in the 20240326 version of the
>> +            privileged ISA specification.
>> +
> [ ... ]
>
>> @@ -199,6 +207,14 @@ properties:
>>               added by other RISC-V extensions in H/S/VS/U/VU modes and as
>>               ratified at commit a28bfae (Ratified (#7)) of riscv-state-enable.
>>   
>> +        - const: sscsrind
>> +          description: |
>> +            The standard Sscsrind supervisor-level extension extends the
>> +            indirect CSR access mechanism defined by the Ssaia extension. This
>> +            extension allows other ISA extension to use indirect CSR access
> [Severity: Low]
> This isn't a bug, but there is the same typo here. Should "ISA extension" be
> pluralized to "ISA extensions"?
>
>> +            mechanism in S-mode as ratified in the 20240326 version of the
>> +            privileged ISA specification.
>> +
>>           - const: ssaia
> [Severity: Low]
> Should sscsrind be placed after ssaia rather than before it? The
> extensions in this file are expected to be sorted alphanumerically.

Fixed the typos in v7.


>>             description: |
>>               The standard Ssaia supervisor-level extension for the advanced