public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Ziyue Zhang <quic_ziyuzhan@quicinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: <vkoul@kernel.org>, <kishon@kernel.org>,
	<dmitry.baryshkov@linaro.org>, <abel.vesa@linaro.org>,
	<neil.armstrong@linaro.org>, <andersson@kernel.org>,
	<konradybcio@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <quic_qianyu@quicinc.com>
Subject: Re: [PATCH 3/3] arm64: dts: qcom: qcs615: add pcie phy max current property
Date: Thu, 12 Dec 2024 15:32:23 +0800	[thread overview]
Message-ID: <89bc05c4-dc84-4e1b-892e-87a959c72556@quicinc.com> (raw)
In-Reply-To: <20241211062645.3eut7ibjqymm6ayt@thinkpad>


在 12/11/2024 2:26 PM, Manivannan Sadhasivam 写道:
> On Wed, Dec 04, 2024 at 06:52:49PM +0800, Ziyue Zhang wrote:
>> Add vdda-pll-max-microamp for vdda-pll-supply. The value of this property
>> is from the power grid guide. It is the maximum current the regulator can
>> provide. The property will be parsed by PCIe PHY driver to set the current
>> load.
>>
>> Signed-off-by: Ziyue Zhang <quic_ziyuzhan@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> index 18f131ae9e07..6d93ef0d886b 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> @@ -215,6 +215,7 @@ &pcie {
>>   &pcie_phy {
>>   	vdda-phy-supply = <&vreg_l5a>;
>>   	vdda-pll-supply = <&vreg_l12a>;
>> +	vdda-pll-max-microamp = <165000>;
>>   
> Min uV of this regulator is 1800000:
> https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/tree/arch/arm64/boot/dts/qcom/qcs615-ride.dts?h=for-next#n151
>
> How can you set 165000?
>
> - Mani

Hi Mani
the 165000 cames from the power grid guide, and it is 165000uA not uV
BRs
Ziyue

>

  reply	other threads:[~2024-12-12  7:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04 10:52 [PATCH 0/3] pci: qcom: Add PCIe setting current load support Ziyue Zhang
2024-12-04 10:52 ` [PATCH 1/3] dt-bindings: phy: qcom,qmp-pcie: add optional current load properties Ziyue Zhang
2024-12-05 10:23   ` Krzysztof Kozlowski
2024-12-11  6:20     ` Manivannan Sadhasivam
2024-12-11  8:09       ` Krzysztof Kozlowski
2024-12-11  8:24         ` Manivannan Sadhasivam
2024-12-11  9:52           ` Krzysztof Kozlowski
2024-12-11 10:34             ` Krzysztof Kozlowski
2024-12-11 11:50             ` Manivannan Sadhasivam
2024-12-12  7:29               ` Ziyue Zhang
2024-12-12  7:31                 ` Krzysztof Kozlowski
2024-12-12  7:30               ` Krzysztof Kozlowski
2024-12-04 10:52 ` [PATCH 2/3] phy: qcom: qmp-pcie: add current load vote/devote for PCIe PHY Ziyue Zhang
2024-12-05 16:31   ` Konrad Dybcio
2024-12-04 10:52 ` [PATCH 3/3] arm64: dts: qcom: qcs615: add pcie phy max current property Ziyue Zhang
2024-12-11  6:26   ` Manivannan Sadhasivam
2024-12-12  7:32     ` Ziyue Zhang [this message]
2024-12-26  5:09   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89bc05c4-dc84-4e1b-892e-87a959c72556@quicinc.com \
    --to=quic_ziyuzhan@quicinc.com \
    --cc=abel.vesa@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=kishon@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_qianyu@quicinc.com \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox