From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ziyue Zhang <quic_ziyuzhan@quicinc.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: vkoul@kernel.org, kishon@kernel.org, dmitry.baryshkov@linaro.org,
abel.vesa@linaro.org, neil.armstrong@linaro.org,
andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
quic_qianyu@quicinc.com
Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,qmp-pcie: add optional current load properties
Date: Thu, 12 Dec 2024 08:31:58 +0100 [thread overview]
Message-ID: <d803ead8-af3d-438a-9d9f-6194a7a5431a@kernel.org> (raw)
In-Reply-To: <16d109d8-d1be-4ecb-ba25-8e21e9d48dad@quicinc.com>
On 12/12/2024 08:29, Ziyue Zhang wrote:
>
>> In that case, I was wondering if the load set by the driver is going to vary
>> between platforms (boards) or not (question to Ziyue Zhang). If it varies
>> between SoC, then we can hardcode the load in driver based on compatible.
>
> Hi Mani, Krzystof
>
> Now we set the current to 165mA which is the max power supply the regulator
> can provide, so this is platform(boards) related. But we think PCIe PHY needs
Yeah, so that's the answer to what I asked just a second ago - you do
not put there device load. You put there regulator constraints.
> to set the current value we need, which is soc related.
So move it away from DT. I don't care what's in the driver, so you can
put there whatever fake value.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-12 7:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 10:52 [PATCH 0/3] pci: qcom: Add PCIe setting current load support Ziyue Zhang
2024-12-04 10:52 ` [PATCH 1/3] dt-bindings: phy: qcom,qmp-pcie: add optional current load properties Ziyue Zhang
2024-12-05 10:23 ` Krzysztof Kozlowski
2024-12-11 6:20 ` Manivannan Sadhasivam
2024-12-11 8:09 ` Krzysztof Kozlowski
2024-12-11 8:24 ` Manivannan Sadhasivam
2024-12-11 9:52 ` Krzysztof Kozlowski
2024-12-11 10:34 ` Krzysztof Kozlowski
2024-12-11 11:50 ` Manivannan Sadhasivam
2024-12-12 7:29 ` Ziyue Zhang
2024-12-12 7:31 ` Krzysztof Kozlowski [this message]
2024-12-12 7:30 ` Krzysztof Kozlowski
2024-12-04 10:52 ` [PATCH 2/3] phy: qcom: qmp-pcie: add current load vote/devote for PCIe PHY Ziyue Zhang
2024-12-05 16:31 ` Konrad Dybcio
2024-12-04 10:52 ` [PATCH 3/3] arm64: dts: qcom: qcs615: add pcie phy max current property Ziyue Zhang
2024-12-11 6:26 ` Manivannan Sadhasivam
2024-12-12 7:32 ` Ziyue Zhang
2024-12-26 5:09 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d803ead8-af3d-438a-9d9f-6194a7a5431a@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_qianyu@quicinc.com \
--cc=quic_ziyuzhan@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox