Re: [PATCH 2/2] clocksource/timer-econet-en751221: Support irq number per timer

[Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>]

On 5/6/26 17:27, Caleb James DeLisle wrote:
> Hello, thanks for having a look.
> 
> 
> On 06/05/2026 16:39, Daniel Lezcano wrote:
>> On 4/16/26 19:51, Caleb James DeLisle wrote:
>>> This timer was first developed on the EN751221 which is a MIPS 34Kc
>>> and therefore has a custom interrupt controller. The hardware for
>>> econet,en751221-intc implements percpu routing of the timer
>>> interrupts.
>>>
>>> However, the EN751627 and EN7528 are MIPS 1004Kc based, and
>>> therefore use the standard mti,gic compatible interrupt controller.
>>> This interrupt controller uses a different IRQ number for each
>>> timer interrupt.
>>>
>>> Add support for both models in this timer driver.
>>
>> Given the changes done in this driver, the description is short and 
>> does not explain why the code is so impacted.
> 
> 
> Fair enough. Supporting the two different IRQ models lead to an annoying 
> amount of changes.
> 
> 
>>
>> I suggest to split the changes in order to facilitate the review process
> 
> 
> Okay, I'll see what I can do in this regard.

Perfect, thanks !