Re: [PATCH v3 11/19] crypto: cmh - add DRBG hwrng

[Krzysztof Kozlowski <krzk@kernel.org>]

On 06/08/2026 21:55, Saravanakrishnan Krishnamoorthy wrote:
> + * cmh_rng_unregister() - Unregister the CMH hardware RNG device
> + *
> + * Unregisters the hwrng device from the kernel hwrng framework if it
> + * was previously registered.
> + */
> +void cmh_rng_unregister(void)
> +{
> +	if (!cmh_rng_registered)
> +		return;
> +	hwrng_unregister(&cmh_hwrng);
> +	cmh_rng_registered = false;
> +	dev_info(cmh_dev(), "rng: unregistered rambus-cmh-drbg\n");

So every function has dev_info?

This is one of its kind driver, because I never saw so much of spamming
dmesg. It should raise eyebrows of your internal reviewers, therefore I
insist on performing reviews on the mailing list if you want them to be
tracked.

Best regards,
Krzysztof