From: Krzysztof Kozlowski <krzk@kernel.org>
To: Petko Manolov <petko.manolov@konsulko.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
dinguyen@kernel.org
Subject: Re: [PATCH v2 1/1] ARM: dts: draeger: Add socfpga devicetree for Draeger's M48 board.
Date: Wed, 9 Sep 2026 08:52:19 +0200 [thread overview]
Message-ID: <90736548-168f-461d-961c-2b113f5a73f0@kernel.org> (raw)
In-Reply-To: <20260909065059.GB10420@carbon.k.g>
On 09/09/2026 08:50, Petko Manolov wrote:
> On 26-09-09 08:36:23, Krzysztof Kozlowski wrote:
>> On 08/09/2026 13:10, Petko Manolov wrote:
>>> Signed-off-by: Petko Manolov <petko.manolov@konsulko.com>
>>
>> Please run scripts/checkpatch.pl on the patches and fix reported warnings.
>> After that, run also 'scripts/checkpatch.pl --strict' on the patches and
>> (probably) fix more warnings. Some warnings can be ignored, especially from
>> --strict run, but the code here looks like it needs a fix. Feel free to get in
>> touch if the warning is not clear.
>>
>>
>>> ---
>>> .../devicetree/bindings/arm/altera.yaml | 1 +
>>> arch/arm/boot/dts/intel/socfpga/Makefile | 1 +
>>> .../socfpga/socfpga_cyclone5_draeger_m48.dts | 130 ++++++++++++++++++
>>> 3 files changed, 132 insertions(+)
>>> create mode 100644 arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_draeger_m48.dts
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
>>> index 3030cf46fe74..8ed1ba733510 100644
>>> --- a/Documentation/devicetree/bindings/arm/altera.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/altera.yaml
>>
>> Same comments. Binding should not be part of other patches.
>
> Does this mean i should submit the bindings related patches first?
Please read both submitting patches documents.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-09 6:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 11:09 [PATCH v2 0/1] ARM: dts: draeger: Add socfpga devicetree for Draeger's M48 board Petko Manolov
2026-09-08 11:10 ` [PATCH v2 1/1] " Petko Manolov
2026-09-08 11:17 ` sashiko-bot
2026-09-09 6:36 ` Krzysztof Kozlowski
2026-09-09 6:50 ` Petko Manolov
2026-09-09 6:52 ` Krzysztof Kozlowski [this message]
2026-09-09 10:07 ` Petko Manolov
2026-09-09 10:14 ` Krzysztof Kozlowski
2026-09-09 11:16 ` Petko Manolov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90736548-168f-461d-961c-2b113f5a73f0@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petko.manolov@konsulko.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox