From: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Abel Vesa <abel.vesa@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: eliza: Add PCIe PHY and controller nodes
Date: Tue, 7 Jul 2026 15:59:09 +0530 [thread overview]
Message-ID: <95e256bd-191f-40df-96b4-6cff38473c5b@oss.qualcomm.com> (raw)
In-Reply-To: <9448e854-d64f-4316-8fdd-4e1e3dcc9ce0@oss.qualcomm.com>
On 7/7/2026 3:55 PM, Konrad Dybcio wrote:
> On 6/26/26 5:15 PM, Abel Vesa wrote:
>> On 26-06-26 09:46:03, Krishna Chaitanya Chundru wrote:
>>>
>>> On 6/25/2026 3:42 PM, Abel Vesa wrote:
>>>> On 26-06-10 17:40:09, Krishna Chaitanya Chundru wrote:
>>>>> Eliza supports two PCIe instances: one 8GT/s x1 (PCIe0) and one 8GT/s x2
>>>>> (PCIe1). Add PCIe controller and PHY nodes for both instances, and update
>>>>> the GCC clock references to use the newly added PHY nodes instead of
>>>>> placeholder zeros.
>>>>>
>>>>> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
>>>>> ---
> [...]
>
>>>> No pinctrl states?
>>> As we are adding perst & wake gpio's in board specific file, it is better to
>>> add the pincntrl also
>>> there only.
>> I'll let Bjorn and Konrad reply, but most of the sm8*50.dtsi have
>> them. Though some of the newer platforms moved them in the board dts.
> Some folks argue (I believe purely ideologically) that the pin states
> should be defined in the board DTSI, but I don't think we have a single
> example of non-default routing in the many many years of linux-arm-msm,
> so I think the reasonable decision is to keep them in the SoC DTSI.
ack. I will re-spin
- Krishna Chaitanya.
>
> Konrad
prev parent reply other threads:[~2026-07-07 10:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 12:10 [PATCH] arm64: dts: qcom: eliza: Add PCIe PHY and controller nodes Krishna Chaitanya Chundru
2026-06-10 12:23 ` sashiko-bot
2026-06-25 10:12 ` Abel Vesa
2026-06-26 4:16 ` Krishna Chaitanya Chundru
2026-06-26 15:15 ` Abel Vesa
2026-07-07 10:25 ` Konrad Dybcio
2026-07-07 10:29 ` Krishna Chaitanya Chundru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95e256bd-191f-40df-96b4-6cff38473c5b@oss.qualcomm.com \
--to=krishna.chundru@oss.qualcomm.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox