public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
	Conor Dooley <conor@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: renesas,r9a09g077: Document pin configuration properties
Date: Fri, 16 Jan 2026 15:28:33 +0100	[thread overview]
Message-ID: <9c1b12fb-2c30-4610-8262-5c615e1ac982@kernel.org> (raw)
In-Reply-To: <CA+V-a8s0gPbe2ffmN1G_7ibVL4+=FKUEQZu3_CwQL=U0T3--DQ@mail.gmail.com>

On 14/01/2026 21:53, Lad, Prabhakar wrote:
>>>>> What are the meanings of "0" and "1" for slew rate? Why isn't this given
>>>> I'll add a description for it (0 = slow, 1 = fast) and the same values
>>>> are programmed in the register to configure the slew rate.
>>>>
>>>>> as the actual rates? The docs surely give more detail than just "slow"
>>>>> and "fast".
>>>> You mean to represent slew-rate in some sort of a unit?
>>>>
>>> Based on the comments from the HW team, there is no numerical
>>> definition to represent slow/fast It only defines a relative
>>> relationship.
>>>>>
>>>>>> +      renesas,drive-strength:
>>>>>> +        description:
>>>>>> +          Drive strength configuration value. Valid values are 0 to 3, representing
>>>>>> +          increasing drive strength from low, medium, high and ultra high.
>>>>>
> I got the feedback from the HW team "The RZ/T2H drive strength
> (driving ability) is expressed using abstract levels such as Low,
> Middle, and High. These values do not correspond directly to specific

Hold my beer and let me design PCB... I will use high voltage power
supply, then small resistor and small capacitor. Ah, and that regulator
here should operate on medium/middle voltage. Looks about right, all
ready to send to fab!

> mA units. To determine how much current the pin can actually drive,
> the engineer must refer to the electrical characteristics table.
> Therefore, the drive strength in RZ/T2H is a parameter that switches
> the internal output transistor mode rather than directly representing
> a physical drive current.
> Consequently, expressing RZ/T2H drive strength in milli- or
> micro-amps, as suggested by the reviewer, is inappropriate. To
> accurately reflect the SoC's hardware specification, introducing a
> custom property is essential."

So the hardware team tells you how you should model DT - "introducing a
custom property is essential".

That's pretty bold statement and very poor language construct. It is not
hardware team which decides how DT should be written.


Best regards,
Krzysztof

  parent reply	other threads:[~2026-01-16 14:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14 19:11 [PATCH 0/2] Add support for configuring pin properties on RZ/T2H-N2H SoCs Prabhakar
2025-10-14 19:11 ` [PATCH 1/2] dt-bindings: pinctrl: renesas,r9a09g077: Document pin configuration properties Prabhakar
2025-10-16 16:41   ` Conor Dooley
2025-10-17 15:33     ` Lad, Prabhakar
2025-10-17 15:45       ` Conor Dooley
2025-12-08 10:36       ` Lad, Prabhakar
2025-12-08 18:00         ` Conor Dooley
2025-12-11  0:00           ` Linus Walleij
2025-12-12 11:11             ` Lad, Prabhakar
2026-01-14 20:53           ` Lad, Prabhakar
2026-01-14 22:26             ` Conor Dooley
2026-01-16 14:28             ` Krzysztof Kozlowski [this message]
2026-01-19  0:09             ` Linus Walleij
2026-03-18 21:30               ` Lad, Prabhakar
2026-03-19  1:36                 ` Conor Dooley
2026-03-20 13:29                 ` Linus Walleij
2025-10-20 21:25   ` Linus Walleij
2025-10-14 19:11 ` [PATCH 2/2] pinctrl: renesas: rzt2h: Add pin configuration support Prabhakar
2026-03-03 13:53   ` Geert Uytterhoeven
2026-03-12 11:42     ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c1b12fb-2c30-4610-8262-5c615e1ac982@kernel.org \
    --to=krzk@kernel.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox