From: "Erim, Salih" <salih.erim@amd.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Conall O'Griofa" <conall.ogriofa@amd.com>,
"Michal Simek" <michal.simek@amd.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Salih Erim" <erimsalih@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/5] iio: adc: add Versal SysMon driver
Date: Sun, 7 Jun 2026 21:55:44 +0100 [thread overview]
Message-ID: <9dc9f575-b5de-4135-bdee-468b7448687d@amd.com> (raw)
In-Reply-To: <aiUm5vmG7EHmp52x@ashevche-desk.local>
Hi Andy,
On 07/06/2026 09:08, Andy Shevchenko wrote:
>
> On Sun, Jun 07, 2026 at 11:06:13AM +0300, Andy Shevchenko wrote:
>> On Sat, Jun 06, 2026 at 06:17:04AM +0100, Salih Erim wrote:
>
> Ah, and missed part below.
>
> ...
>
>>> +#ifndef _VERSAL_SYSMON_H_
>>> +#define _VERSAL_SYSMON_H_
>>> +
>>> +#include <linux/bits.h>
>>> +#include <linux/mutex.h>
>
>>> +#include <linux/types.h>
>
> types.h is not used here.
Accepted. Will remove from P2 and add in P4 where struct
members first need it.
>
>>> +struct device;
>
>>> +struct iio_dev;
>
> Neither this forward declaration.
Accepted. struct iio_dev is never referenced in the header.
Will remove.
Thanks,
Salih
>
>>> +struct regmap;
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2026-06-07 20:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-06 5:17 [PATCH v4 0/5] iio: adc: add AMD/Xilinx Versal SysMon driver Salih Erim
2026-06-06 5:17 ` [PATCH v4 1/5] dt-bindings: iio: adc: add xlnx,versal-sysmon binding Salih Erim
2026-06-06 5:27 ` sashiko-bot
2026-06-06 5:17 ` [PATCH v4 2/5] iio: adc: add Versal SysMon driver Salih Erim
2026-06-07 8:06 ` Andy Shevchenko
2026-06-07 8:08 ` Andy Shevchenko
2026-06-07 20:55 ` Erim, Salih [this message]
2026-06-07 20:45 ` Erim, Salih
2026-06-09 17:34 ` Andy Shevchenko
2026-06-06 5:17 ` [PATCH v4 3/5] iio: adc: versal-sysmon: add I2C driver Salih Erim
2026-06-06 5:27 ` sashiko-bot
2026-06-06 18:34 ` Andy Shevchenko
2026-06-07 10:27 ` Erim, Salih
2026-06-06 5:17 ` [PATCH v4 4/5] iio: adc: versal-sysmon: add threshold event support Salih Erim
2026-06-06 5:31 ` sashiko-bot
2026-06-07 7:31 ` Andy Shevchenko
2026-06-07 21:02 ` Erim, Salih
2026-06-09 17:31 ` Andy Shevchenko
2026-06-10 11:46 ` Erim, Salih
2026-06-10 13:51 ` Andy Shevchenko
2026-06-06 5:17 ` [PATCH v4 5/5] iio: adc: versal-sysmon: add oversampling support Salih Erim
2026-06-06 5:30 ` sashiko-bot
2026-06-07 7:50 ` Andy Shevchenko
2026-06-07 22:29 ` Erim, Salih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dc9f575-b5de-4135-bdee-468b7448687d@amd.com \
--to=salih.erim@amd.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conall.ogriofa@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=erimsalih@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.simek@amd.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox