public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Conor Dooley <conor@kernel.org>
Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>,
	devicetree@vger.kernel.org,  Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] schemas: Allow clocks: property in cache nodes
Date: Mon, 4 May 2026 10:19:40 +0200	[thread overview]
Message-ID: <CAMuHMdV-4jRYfF8LxdP9XrDuKDsAp7ZXdpCChdp=CanE0xGPUA@mail.gmail.com> (raw)
In-Reply-To: <20260503-vagabond-barge-dac8ececfc11@spud>

Hi Conor,

On Sun, 3 May 2026 at 20:09, Conor Dooley <conor@kernel.org> wrote:
> On Sun, May 03, 2026 at 05:44:13PM +0200, Marek Vasut wrote:
> > Renesas R-Mobile APE6 currently describes clock which supply the cache
> > controller in their DT using "clocks" property. This is not the only
> > hardware that has cache controller clock controllable via some sort of
> > clock controller, for example Altera SoCFPGA Cyclone V and Arria V also
> > has controllable cache controller clock. Allow clocks: property in cache
> > controller node to allow users to fully describe such hardware.
>
> Hmm, shouldn't these cache controllers have dedicated bindings that
> enforce their clock requirements?

Just a few general comments:
  - All electronics needs power, so "power-domains" should always
    be permitted,
  - All synchronous logic needs a clock, so "clocks" should always
    be permitteded,
  - All reasonably complex circuits need a reset, so "resets" should
    always be permitted.

> > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

As I have sent the same patch before[1]:
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

> > --- a/dtschema/schemas/cache.yaml
> > +++ b/dtschema/schemas/cache.yaml
> > @@ -33,6 +33,9 @@ properties:
> >    compatible:
> >      const: cache
> >
> > +  clocks:
> > +    maxItems: 1
> > +
> >    power-domains:
> >      maxItems: 1

[1] https://lore.kernel.org/20260113075243.1192477-1-geert+renesas@glider.be/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2026-05-04  8:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03 15:44 [PATCH] schemas: Allow clocks: property in cache nodes Marek Vasut
2026-05-03 18:09 ` Conor Dooley
2026-05-04  8:19   ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdV-4jRYfF8LxdP9XrDuKDsAp7ZXdpCChdp=CanE0xGPUA@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox