* [PATCH v3] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750
@ 2026-06-12 9:04 Krzysztof Kozlowski
2026-06-12 9:16 ` sashiko-bot
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-12 9:04 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Abel Vesa
Document Qualcomm PMK7750 GPIO used with Eliza SoC. PMIC is almost the
same as PMK8550, thus compatible with it.
Cc: Abel Vesa <abel.vesa@oss.qualcomm.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Changes in v3:
1. Drop stale pmk7750 from main enum lisrt (the big one) - leftover of
previous version
Changes in v2:
1. Add fallback compatible.
---
.../bindings/pinctrl/qcom,pmic-gpio.yaml | 151 +++++++++---------
1 file changed, 78 insertions(+), 73 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 386c31e9c52b..5ecf5da3d100 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -15,79 +15,84 @@ description:
properties:
compatible:
- items:
- - enum:
- - qcom,pm2250-gpio
- - qcom,pm660-gpio
- - qcom,pm660l-gpio
- - qcom,pm6125-gpio
- - qcom,pm6150-gpio
- - qcom,pm6150l-gpio
- - qcom,pm6350-gpio
- - qcom,pm6450-gpio
- - qcom,pm7250b-gpio
- - qcom,pm7325-gpio
- - qcom,pm7550-gpio
- - qcom,pm7550ba-gpio
- - qcom,pm8005-gpio
- - qcom,pm8018-gpio
- - qcom,pm8019-gpio
- - qcom,pm8038-gpio
- - qcom,pm8058-gpio
- - qcom,pm8150-gpio
- - qcom,pm8150b-gpio
- - qcom,pm8150l-gpio
- - qcom,pm8226-gpio
- - qcom,pm8350-gpio
- - qcom,pm8350b-gpio
- - qcom,pm8350c-gpio
- - qcom,pm8450-gpio
- - qcom,pm8550-gpio
- - qcom,pm8550b-gpio
- - qcom,pm8550ve-gpio
- - qcom,pm8550vs-gpio
- - qcom,pm8916-gpio
- - qcom,pm8917-gpio
- - qcom,pm8921-gpio
- - qcom,pm8937-gpio
- - qcom,pm8941-gpio
- - qcom,pm8950-gpio
- - qcom,pm8953-gpio
- - qcom,pm8994-gpio
- - qcom,pm8998-gpio
- - qcom,pma8084-gpio
- - qcom,pmc8180-gpio
- - qcom,pmc8180c-gpio
- - qcom,pmc8380-gpio
- - qcom,pmcx0102-gpio
- - qcom,pmd8028-gpio
- - qcom,pmh0101-gpio
- - qcom,pmh0104-gpio
- - qcom,pmh0110-gpio
- - qcom,pmi632-gpio
- - qcom,pmi8950-gpio
- - qcom,pmi8994-gpio
- - qcom,pmi8998-gpio
- - qcom,pmih0108-gpio
- - qcom,pmiv0104-gpio
- - qcom,pmk8350-gpio
- - qcom,pmk8550-gpio
- - qcom,pmk8850-gpio
- - qcom,pmm8155au-gpio
- - qcom,pmm8654au-gpio
- - qcom,pmp8074-gpio
- - qcom,pmr735a-gpio
- - qcom,pmr735b-gpio
- - qcom,pmr735d-gpio
- - qcom,pms405-gpio
- - qcom,pmx55-gpio
- - qcom,pmx65-gpio
- - qcom,pmx75-gpio
- - qcom,pmxr2230-gpio
-
- - enum:
- - qcom,spmi-gpio
- - qcom,ssbi-gpio
+ oneOf:
+ - items:
+ - enum:
+ - qcom,pm2250-gpio
+ - qcom,pm660-gpio
+ - qcom,pm660l-gpio
+ - qcom,pm6125-gpio
+ - qcom,pm6150-gpio
+ - qcom,pm6150l-gpio
+ - qcom,pm6350-gpio
+ - qcom,pm6450-gpio
+ - qcom,pm7250b-gpio
+ - qcom,pm7325-gpio
+ - qcom,pm7550-gpio
+ - qcom,pm7550ba-gpio
+ - qcom,pm8005-gpio
+ - qcom,pm8018-gpio
+ - qcom,pm8019-gpio
+ - qcom,pm8038-gpio
+ - qcom,pm8058-gpio
+ - qcom,pm8150-gpio
+ - qcom,pm8150b-gpio
+ - qcom,pm8150l-gpio
+ - qcom,pm8226-gpio
+ - qcom,pm8350-gpio
+ - qcom,pm8350b-gpio
+ - qcom,pm8350c-gpio
+ - qcom,pm8450-gpio
+ - qcom,pm8550-gpio
+ - qcom,pm8550b-gpio
+ - qcom,pm8550ve-gpio
+ - qcom,pm8550vs-gpio
+ - qcom,pm8916-gpio
+ - qcom,pm8917-gpio
+ - qcom,pm8921-gpio
+ - qcom,pm8937-gpio
+ - qcom,pm8941-gpio
+ - qcom,pm8950-gpio
+ - qcom,pm8953-gpio
+ - qcom,pm8994-gpio
+ - qcom,pm8998-gpio
+ - qcom,pma8084-gpio
+ - qcom,pmc8180-gpio
+ - qcom,pmc8180c-gpio
+ - qcom,pmc8380-gpio
+ - qcom,pmcx0102-gpio
+ - qcom,pmd8028-gpio
+ - qcom,pmh0101-gpio
+ - qcom,pmh0104-gpio
+ - qcom,pmh0110-gpio
+ - qcom,pmi632-gpio
+ - qcom,pmi8950-gpio
+ - qcom,pmi8994-gpio
+ - qcom,pmi8998-gpio
+ - qcom,pmih0108-gpio
+ - qcom,pmiv0104-gpio
+ - qcom,pmk8350-gpio
+ - qcom,pmk8550-gpio
+ - qcom,pmk8850-gpio
+ - qcom,pmm8155au-gpio
+ - qcom,pmm8654au-gpio
+ - qcom,pmp8074-gpio
+ - qcom,pmr735a-gpio
+ - qcom,pmr735b-gpio
+ - qcom,pmr735d-gpio
+ - qcom,pms405-gpio
+ - qcom,pmx55-gpio
+ - qcom,pmx65-gpio
+ - qcom,pmx75-gpio
+ - qcom,pmxr2230-gpio
+ - enum:
+ - qcom,spmi-gpio
+ - qcom,ssbi-gpio
+ - items:
+ - enum:
+ - qcom,pmk7750-gpio
+ - const: qcom,pmk8550-gpio
+ - const: qcom,spmi-gpio
reg:
maxItems: 1
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750
2026-06-12 9:04 [PATCH v3] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750 Krzysztof Kozlowski
@ 2026-06-12 9:16 ` sashiko-bot
2026-06-13 8:08 ` Krzysztof Kozlowski
2026-06-15 21:02 ` Rob Herring (Arm)
2026-06-29 14:44 ` Krzysztof Kozlowski
2 siblings, 1 reply; 5+ messages in thread
From: sashiko-bot @ 2026-06-12 9:16 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: robh, devicetree, conor+dt
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing Compatible String in Conditional Block for 'qcom,pmk7750-gpio'
- [Low] Missing PMK7750 PMIC parent node in MFD bindings
--
commit 4f1189e771b6e33f2285b6ec22e2635e18bc5718
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750
Document Qualcomm PMK7750 GPIO used with Eliza SoC. PMIC is almost the
same as PMK8550, thus compatible with it.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> index 386c31e9c52b8..5ecf5da3d1000 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -15,79 +15,84 @@ description:
>
> properties:
> compatible:
[ ... ]
> + - items:
> + - enum:
> + - qcom,pmk7750-gpio
> + - const: qcom,pmk8550-gpio
> + - const: qcom,spmi-gpio
>
> reg:
> maxItems: 1
[Severity: Low]
Does the allOf conditional block for qcom,pmk8550-gpio need to be updated
to explicitly include qcom,pmk7750-gpio?
Looking at the existing conditional blocks further down in the file:
- if:
properties:
compatible:
contains:
enum:
- qcom,pm8018-gpio
- qcom,pm8019-gpio
- qcom,pm8550vs-gpio
- qcom,pmk8550-gpio
then:
Since qcom,pmk7750-gpio is compatible with qcom,pmk8550-gpio, should it also
be explicitly listed in these constraints to ensure schema validation remains
complete?
[Severity: Low]
Does the parent PMIC qcom,pmk7750 need to be added to the MFD bindings in
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml?
The MFD binding strictly enforces exactly a two-element array:
compatible:
items:
- enum:
- qcom,pm2250
...
- qcom,pmk8550
...
- const: qcom,spmi-pmic
Since qcom,pmk7750-gpio is added here, will device trees fail schema
validation for the parent PMIC node if qcom,pmk7750 is missing from the
enum in qcom,spmi-pmic.yaml?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260612090426.23403-2-krzysztof.kozlowski@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750
2026-06-12 9:16 ` sashiko-bot
@ 2026-06-13 8:08 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-13 8:08 UTC (permalink / raw)
To: sashiko-reviews; +Cc: Krzysztof Kozlowski, robh, devicetree, conor+dt
On Fri, Jun 12, 2026 at 09:16:14AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Low] Missing Compatible String in Conditional Block for 'qcom,pmk7750-gpio'
False positive.
> - [Low] Missing PMK7750 PMIC parent node in MFD bindings
False positive, sent separately already.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750
2026-06-12 9:04 [PATCH v3] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750 Krzysztof Kozlowski
2026-06-12 9:16 ` sashiko-bot
@ 2026-06-15 21:02 ` Rob Herring (Arm)
2026-06-29 14:44 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring (Arm) @ 2026-06-15 21:02 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-msm, Abel Vesa, devicetree, linux-gpio,
Krzysztof Kozlowski, Conor Dooley, Linus Walleij, Bjorn Andersson,
linux-kernel
On Fri, 12 Jun 2026 11:04:27 +0200, Krzysztof Kozlowski wrote:
> Document Qualcomm PMK7750 GPIO used with Eliza SoC. PMIC is almost the
> same as PMK8550, thus compatible with it.
>
> Cc: Abel Vesa <abel.vesa@oss.qualcomm.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> ---
>
> Changes in v3:
> 1. Drop stale pmk7750 from main enum lisrt (the big one) - leftover of
> previous version
>
> Changes in v2:
> 1. Add fallback compatible.
> ---
> .../bindings/pinctrl/qcom,pmic-gpio.yaml | 151 +++++++++---------
> 1 file changed, 78 insertions(+), 73 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750
2026-06-12 9:04 [PATCH v3] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750 Krzysztof Kozlowski
2026-06-12 9:16 ` sashiko-bot
2026-06-15 21:02 ` Rob Herring (Arm)
@ 2026-06-29 14:44 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-29 14:44 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, linux-gpio, devicetree, linux-kernel
Cc: Abel Vesa
On 12/06/2026 11:04, Krzysztof Kozlowski wrote:
> Document Qualcomm PMK7750 GPIO used with Eliza SoC. PMIC is almost the
> same as PMK8550, thus compatible with it.
>
> Cc: Abel Vesa <abel.vesa@oss.qualcomm.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> ---
>
> Changes in v3:
> 1. Drop stale pmk7750 from main enum lisrt (the big one) - leftover of
> previous version
>
> Changes in v2:
> 1. Add fallback compatible.
> ---
> .../bindings/pinctrl/qcom,pmic-gpio.yaml | 151 +++++++++---------
> 1 file changed, 78 insertions(+), 73 deletions(-)
After some internal discussions, we concluded that it probably is the
same die as pmk8550, just fused differently, thus does not deserve
dedicated compatible and patch can be dropped.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-06-29 14:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-12 9:04 [PATCH v3] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750 Krzysztof Kozlowski
2026-06-12 9:16 ` sashiko-bot
2026-06-13 8:08 ` Krzysztof Kozlowski
2026-06-15 21:02 ` Rob Herring (Arm)
2026-06-29 14:44 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox