Re: [PATCH 8/8] arm64: dts: qcom: x1e80100-crd: Add qcom,tsens for EC fan thermal management

[Anvesh Jain P <anvesh.p@oss.qualcomm.com>]

On 7/29/2026 12:06 AM, sashiko-bot@kernel.org wrote:
> --- Patch [8]: [PATCH 8/8] arm64: dts: qcom: x1e80100-crd: Add qcom,tsens for EC fan thermal management ---
> commit 59ab25e0b30620df90dae53f1497861f1847b925
> Author: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
> 
> arm64: dts: qcom: x1e80100-crd: Add qcom,tsens for EC fan thermal management
> 
> This commit adds the qcom,tsens property to the embedded-controller node
> in the x1e80100-crd device tree to report average SoC junction temperature
> to the EC for fan control.
> 
>> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
>> index 429deffcf3e9d..4639340e716c6 100644
>> --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
>> +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
>> @@ -20,3 +20,9 @@ &gpu_zap_shader {
>>  &iris {
>>  	status = "okay";
>>  };
>> +
>> +&i2c5 {
>> +	embedded-controller@76 {
>> +		qcom,tsens = <&tsens2 11>, <&tsens3 15>;
>> +	};
>> +};
> [Severity: Medium]
> Since this defines a new embedded-controller@76 node directly under &i2c5
> rather than referencing an existing phandle, does it need compatible and reg
> properties?
> 
> Without them, dtc will emit a unit_address_vs_reg warning because the @76
> unit address lacks a corresponding reg = <0x76> property.
> 
> Furthermore, the I2C subsystem will not instantiate the device without a
> compatible string and reg address, which would prevent the driver from
> probing and leave the thermal management non-functional.

Same as patch 7, already defined via the included dtsi, bot missed it.
I'll switch to the ec label anyway.

-- 
Best Regards,
Anvesh