From: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
To: "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
"Sibi Sankar" <sibi.sankar@oss.qualcomm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 2/8] platform: arm64: qcom-hamoa-ec: Add SoC junction temperature reporting
Date: Fri, 31 Jul 2026 11:17:59 +0530 [thread overview]
Message-ID: <d3094d80-c51e-47c3-9359-2d28d6d47c8c@oss.qualcomm.com> (raw)
In-Reply-To: <9d9eaae1-97e0-492f-954d-d683f089ef78@oss.qualcomm.com>
On 7/30/2026 10:34 PM, Konrad Dybcio wrote:
> On 7/29/26 3:03 PM, Anvesh Jain P wrote:
>>
>>
>> On 7/29/2026 4:29 PM, Konrad Dybcio wrote:
>>> On 7/28/26 7:44 PM, Anvesh Jain P wrote:
>>>> Add the EC command definitions and handler function for reporting the
>>>> SoC junction temperature (Tj) to the EC.
>>>>
>>>> Discover the platform's thermal sensor to zone mapping via the
>>>> qcom,tsens device tree property, average the junction temperatures
>>>> across the mapped zones, and periodically report the result to the EC
>>>> over SMBus using a delayed work item. Serialize this and the existing
>>>> EC command sequences (firmware version read, thermal capability read,
>>>> SCI event control, and the SCI IRQ handler) under a new io_lock mutex,
>>>> since the delayed work item now runs concurrently with those paths.
>>>>
>>>> Re-arm the periodic report on resume and cancel it on suspend to avoid
>>>> racing with the modern standby transition.
>>>> ---
>
> [...]
>
>> Agreed, will split the devm_add_action_or_reset() conversion into its
>> own commit — it's an independent correctness fix (also disables SCI
>> events on partial probe failure, not just on remove()), unrelated to SoC
>> Tj reporting.
>>
>> On the -13 during suspend/resume: that looks like the SCI IRQ firing (or
>> its threaded handler still running) while the I2C SE resources are down
>> for suspend. Will dig into whether the IRQ needs to be quiesced/disabled
>> around suspend/resume here and follow up.
>
> I hope I'm misjudging here, but if I'm going to talk to your agent
> instead of you, this is pointless..
>
> Konrad
I do use tools to help format and reword replies faster, but the inputs
and technical decisions here are all mine.
--
Best Regards,
Anvesh
next prev parent reply other threads:[~2026-07-31 5:48 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 17:44 [PATCH 0/8] Extend Qualcomm reference device EC driver with fan LUT, profile and SoC Tj support Anvesh Jain P
2026-07-28 17:44 ` [PATCH 1/8] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add qcom,tsens Anvesh Jain P
2026-07-28 17:54 ` sashiko-bot
2026-08-05 9:54 ` Anvesh Jain P
2026-07-29 11:08 ` Krzysztof Kozlowski
2026-07-29 11:54 ` Anvesh Jain P
2026-07-29 12:32 ` Krzysztof Kozlowski
2026-07-29 13:00 ` Anvesh Jain P
2026-07-29 11:13 ` Konrad Dybcio
2026-07-29 12:13 ` Anvesh Jain P
2026-07-30 17:11 ` Konrad Dybcio
2026-07-31 5:55 ` Anvesh Jain P
2026-07-28 17:44 ` [PATCH 2/8] platform: arm64: qcom-hamoa-ec: Add SoC junction temperature reporting Anvesh Jain P
2026-07-28 18:02 ` sashiko-bot
2026-08-05 10:40 ` Anvesh Jain P
2026-07-29 10:59 ` Konrad Dybcio
2026-07-29 13:03 ` Anvesh Jain P
2026-07-30 17:04 ` Konrad Dybcio
2026-07-31 5:47 ` Anvesh Jain P [this message]
2026-07-28 17:44 ` [PATCH 3/8] platform: arm64: qcom-hamoa-ec: Switch fan profile based on power supply state Anvesh Jain P
2026-07-28 18:05 ` sashiko-bot
2026-08-05 13:12 ` Anvesh Jain P
2026-07-29 11:02 ` Konrad Dybcio
2026-07-30 6:21 ` Anvesh Jain P
2026-07-28 17:44 ` [PATCH 4/8] platform: arm64: qcom-hamoa-ec: Add fan RPM query and LUT calibration Anvesh Jain P
2026-07-28 18:15 ` sashiko-bot
2026-08-05 13:15 ` Anvesh Jain P
2026-07-29 11:07 ` Konrad Dybcio
2026-07-30 6:35 ` Anvesh Jain P
2026-07-30 17:08 ` Konrad Dybcio
2026-07-31 6:25 ` Anvesh Jain P
2026-07-28 17:44 ` [PATCH 5/8] platform: arm64: qcom-hamoa-ec: Verify required I2C adapter functionality Anvesh Jain P
2026-07-28 18:14 ` sashiko-bot
2026-08-05 14:20 ` Anvesh Jain P
2026-07-29 11:08 ` Konrad Dybcio
2026-07-30 6:37 ` Anvesh Jain P
2026-07-28 17:44 ` [PATCH 6/8] platform: arm64: qcom-hamoa-ec: Retry I2C transfers on NACK Anvesh Jain P
2026-07-28 18:26 ` sashiko-bot
2026-08-05 15:10 ` Anvesh Jain P
2026-07-29 11:11 ` Konrad Dybcio
2026-07-30 6:40 ` Anvesh Jain P
2026-07-28 17:44 ` [PATCH 7/8] arm64: dts: qcom: x1p42100-crd: Add qcom,tsens for EC fan thermal management Anvesh Jain P
2026-07-28 18:26 ` sashiko-bot
2026-08-06 4:29 ` Anvesh Jain P
2026-07-28 17:44 ` [PATCH 8/8] arm64: dts: qcom: x1e80100-crd: " Anvesh Jain P
2026-07-28 18:36 ` sashiko-bot
2026-08-06 4:37 ` Anvesh Jain P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3094d80-c51e-47c3-9359-2d28d6d47c8c@oss.qualcomm.com \
--to=anvesh.p@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox