From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matthias Fend <matthias.fend@emfend.at>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Hans Verkuil" <hverkuil@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ricardo Ribalda" <ribalda@chromium.org>,
"André Apitzsch" <git@apitzsch.eu>,
"Tarang Raval" <tarang.raval@siliconsignals.io>,
"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
"Sylvain Petinot" <sylvain.petinot@foss.st.com>,
"Dongcheng Yan" <dongcheng.yan@intel.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Jingjing Xiong" <jingjing.xiong@intel.com>,
"Heimir Thor Sverrisson" <heimir.sverrisson@gmail.com>,
"Mehdi Djait" <mehdi.djait@linux.intel.com>,
"Vladimir Zapolskiy" <vladimir.zapolskiy@linaro.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Hardevsinh Palaniya" <hardevsinh.palaniya@siliconsignals.io>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "Hao Yao" <hao.yao@intel.com>,
bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH v4 2/2] media: i2c: add Himax HM1246 image sensor driver
Date: Mon, 20 Oct 2025 12:58:37 +0300 [thread overview]
Message-ID: <aPYHzaBtClxT32r5@ashevche-desk.local> (raw)
In-Reply-To: <c5406a18-0f2b-41c8-854c-e91e74225b61@emfend.at>
On Mon, Oct 20, 2025 at 09:21:10AM +0200, Matthias Fend wrote:
> Am 18.10.2025 um 22:30 schrieb Andy Shevchenko:
> > On Fri, Oct 17, 2025 at 12:49:39PM +0200, Matthias Fend wrote:
...
> > > + hm1246->reset_gpio =
> > > + devm_gpiod_get_optional(hm1246->dev, "reset", GPIOD_OUT_HIGH);
> > > + if (IS_ERR(hm1246->reset_gpio))
> > > + return dev_err_probe(hm1246->dev, PTR_ERR(hm1246->reset_gpio),
> > > + "failed to get reset GPIO\n");
> >
> > Rely on the reset-gpio driver instead of this.
>
> Do you mean that I should use devm_reset_control_get_optional, for example,
> to handle the reset GPIO pin?
> Unless I've missed something, no I2C image sensor seems to use that.
> The recently added driver for the OV2735 also uses the standard GPIO
> framework for the reset pin.
The driver is kinda new (a year and half old), nevertheless I see
disadvantages, it's OF-centric and makes little sense for most of
the users (discrete components).
> For these reasons, I'm not quite sure if I've understood this correctly.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-10-20 9:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 10:49 [PATCH v4 0/2] media: add Himax HM1246 image sensor Matthias Fend
2025-10-17 10:49 ` [PATCH v4 1/2] media: dt-bindings: i2c: " Matthias Fend
2025-10-17 10:49 ` [PATCH v4 2/2] media: i2c: add Himax HM1246 image sensor driver Matthias Fend
2025-10-18 20:30 ` Andy Shevchenko
2025-10-20 7:21 ` Matthias Fend
2025-10-20 9:58 ` Andy Shevchenko [this message]
2025-10-21 14:46 ` Sakari Ailus
2025-10-23 9:00 ` Matthias Fend
2025-11-03 6:54 ` Matthias Fend
2025-11-03 11:02 ` Sakari Ailus
2025-11-03 16:19 ` Matthias Fend
2025-11-04 8:29 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPYHzaBtClxT32r5@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=bryan.odonoghue@linaro.org \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongcheng.yan@intel.com \
--cc=git@apitzsch.eu \
--cc=hansg@kernel.org \
--cc=hao.yao@intel.com \
--cc=hardevsinh.palaniya@siliconsignals.io \
--cc=heimir.sverrisson@gmail.com \
--cc=hverkuil@kernel.org \
--cc=jingjing.xiong@intel.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matthias.fend@emfend.at \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=ribalda@chromium.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=sylvain.petinot@foss.st.com \
--cc=tarang.raval@siliconsignals.io \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox