Re: [PATCH v4 2/2] media: i2c: add Himax HM1246 image sensor driver

[Matthias Fend <matthias.fend@emfend.at>]

Hi Andy,

thanks for your comment.

Am 18.10.2025 um 22:30 schrieb Andy Shevchenko:
> On Fri, Oct 17, 2025 at 12:49:39PM +0200, Matthias Fend wrote:
>> Add a V4L2 sub-device driver for Himax HM1246 image sensor.
>>
>> The Himax HM1246-AWD is a 1/3.7-Inch CMOS image sensor SoC with an active
>> array size of 1296 x 976. It is programmable through an I2C interface and
>> connected via parallel bus.
>>
>> The sensor has an internal ISP with a complete image processing pipeline
>> including control loops. However, this driver uses the sensor in raw mode
>> and the entire ISP is bypassed.
> 
> ...
> 
>> +	hm1246->reset_gpio =
>> +		devm_gpiod_get_optional(hm1246->dev, "reset", GPIOD_OUT_HIGH);
>> +	if (IS_ERR(hm1246->reset_gpio))
>> +		return dev_err_probe(hm1246->dev, PTR_ERR(hm1246->reset_gpio),
>> +				     "failed to get reset GPIO\n");
> 
> Rely on the reset-gpio driver instead of this.

Do you mean that I should use devm_reset_control_get_optional, for 
example, to handle the reset GPIO pin?
Unless I've missed something, no I2C image sensor seems to use that.
The recently added driver for the OV2735 also uses the standard GPIO 
framework for the reset pin.

For these reasons, I'm not quite sure if I've understood this correctly.

Thanks
  ~Matthias