Re: [PATCH v6 0/8] iio: light: vcnl4000: add regulator support

Re: [PATCH v6 0/8] iio: light: vcnl4000: add regulator support

[Andy Shevchenko]

On Fri, Mar 20, 2026 at 06:45:35PM +0200, Erikas Bitovtas wrote:
> This patch series introduces support for voltage supply, I2C and cathode
> regulators. This fixes an issue where if a regulator is shared between
> the proximity sensor and some other device, and the other device is
> powered off, the proximity sensor would be powered off as well.
> 
> One of the commits includes a Reported-by: tag without a Closes: tag -
> the report was done outside in a Matrix channel. A link to access the
> report requires sign-in, therefore it was left out.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

For the series, except the DT binding, I haven't even opened that mail.
Also you can add Suggested-by to the selected patches.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v6 0/8] iio: light: vcnl4000: add regulator support

[Jonathan Cameron]

On Fri, 20 Mar 2026 21:35:01 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Fri, Mar 20, 2026 at 06:45:35PM +0200, Erikas Bitovtas wrote:
> > This patch series introduces support for voltage supply, I2C and cathode
> > regulators. This fixes an issue where if a regulator is shared between
> > the proximity sensor and some other device, and the other device is
> > powered off, the proximity sensor would be powered off as well.
> > 
> > One of the commits includes a Reported-by: tag without a Closes: tag -
> > the report was done outside in a Matrix channel. A link to access the
> > report requires sign-in, therefore it was left out.  
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 
> For the series, except the DT binding, I haven't even opened that mail.
> Also you can add Suggested-by to the selected patches.
> 
You do like to challenge b4! :) Hand removed the tag it added for
the DT patch.

Series applied to the testing branch of iio.git that I'll push
out as togreg once initial build tests are in etc.

Thanks,

Jonathan

Re: [PATCH v6 1/8] dt-bindings: iio: light: vcnl4000: add regulators

[Krzysztof Kozlowski]

On Fri, Mar 20, 2026 at 06:45:36PM +0200, Erikas Bitovtas wrote:
> These sensors can accept 2 supplies - one for the sensor and one for IR
> LED [1]. Add supply properties for the sensor - 2 for the sensors and
> one external, for their open drain interrupt line, to ensure the sensor
> is powered on before proceeding with setup.
> 
> [1] https://www.vishay.com/docs/84274/vcnl4040.pdf
> 
> Reviewed-by: David Lechner <dlechner@baylibre.com>
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
>  .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml     | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH v6 1/8] dt-bindings: iio: light: vcnl4000: add regulators

[Jonathan Cameron]

On Fri, 20 Mar 2026 18:45:36 +0200
Erikas Bitovtas <xerikasxx@gmail.com> wrote:

> These sensors can accept 2 supplies - one for the sensor and one for IR
> LED [1]. Add supply properties for the sensor - 2 for the sensors and
> one external, for their open drain interrupt line, to ensure the sensor
> is powered on before proceeding with setup.
> 
> [1] https://www.vishay.com/docs/84274/vcnl4040.pdf
> 
> Reviewed-by: David Lechner <dlechner@baylibre.com>
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
>  .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml     | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> index 2ba4d5de4ec4..516afef7a545 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> @@ -33,6 +33,17 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  vdd-supply:
> +    description: Regulator providing power to the "VDD" pin.
> +
> +  vio-supply:
> +    description: Regulator providing power for pull-up of the I/O lines.
> +      Does not connect to the sensor directly, but is needed for the
> +      correct operation of the I2C and interrupt lines.

It's optional so I guess it doesn't matter, but whether this supply is
needed of not is down to whether the SoC allows for pull up on the
interrupt and I2C lines.  Some SoCs provide this (though it's been
a while since I used one that did.).

In other cases an external pull up is needed. It would feel
odd to provide a supply for the pull up it was all hidden in the SoC.

Anyhow, optional so we aren't forcing this anyway.

Jonathan


> +
> +  vled-supply:
> +    description: Regulator providing power to the IR anode pin.
> +
>    reg:
>      maxItems: 1
>  
> @@ -54,6 +65,9 @@ examples:
>              compatible = "vishay,vcnl4200";
>              reg = <0x51>;
>              proximity-near-level = <220>;
> +            vdd-supply = <&reg_vdd>;
> +            vio-supply = <&reg_vio>;
> +            vled-supply = <&reg_vled>;
>          };
>      };
>  ...
>