From: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
mohammad.rafi.shaik@oss.qualcomm.com,
ajay.nandam@oss.qualcomm.com
Subject: Re: [PATCH v1 1/2] arm64: dts: qcom: eliza: Add LPASS macro and SoundWire support
Date: Wed, 8 Jul 2026 16:50:42 +0530 [thread overview]
Message-ID: <aed53b10-31e4-4fd7-9dd7-7f305f69a8f9@oss.qualcomm.com> (raw)
In-Reply-To: <399abb64-be63-4944-a8a6-3290cdb167ea@oss.qualcomm.com>
On 7/7/2026 2:12 PM, Konrad Dybcio wrote:
> On 7/3/26 10:34 AM, Ravi Hothi wrote:
>> Add SoC-level LPASS WSA macro, VA macro, SoundWire controller and LPASS
>> LPI pin controller nodes. DMIC and WSA SoundWire pinctrl states are
>> defined inside the LPASS LPI pin controller node. The hardware is similar
>> to the SM8750 platform.
>>
>> The WSA macro, VA macro and SoundWire controller are kept disabled so
>> board DTS files can selectively enable and configure them.
>>
>> Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/eliza.dtsi | 193 ++++++++++++++++++++++++++++
>> 1 file changed, 193 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
>> index 8dbfd0504598..142f43a1e6a3 100644
>> --- a/arch/arm64/boot/dts/qcom/eliza.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
>> @@ -19,6 +19,7 @@
>> #include <dt-bindings/power/qcom,rpmhpd.h>
>> #include <dt-bindings/soc/qcom,gpr.h>
>> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>> +#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
>>
>> / {
>> interrupt-parent = <&intc>;
>> @@ -2072,6 +2073,198 @@ lpass_lpicx_noc: interconnect@7420000 {
>> #interconnect-cells = <2>;
>> };
>>
>> + lpass_wsamacro: codec@6b00000 {
>> + compatible = "qcom,eliza-lpass-wsa-macro",
>> + "qcom,sm8550-lpass-wsa-macro";
>> + reg = <0x0 0x06b00000 0x0 0x1000>;
>
> Nodes with a unit address must be ordered by it - the diff hunk
> above shows you that this one is out-of-order
ACK, Will update in next version.
Thanks,
Ravi Hothi
>
> Konrad
next prev parent reply other threads:[~2026-07-08 11:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 8:34 [PATCH v1 0/2] arm64: dts: qcom: eliza: Add audio support Ravi Hothi
2026-07-03 8:34 ` [PATCH v1 1/2] arm64: dts: qcom: eliza: Add LPASS macro and SoundWire support Ravi Hothi
2026-07-07 8:42 ` Konrad Dybcio
2026-07-08 11:20 ` Ravi Hothi [this message]
2026-07-03 8:34 ` [PATCH v1 2/2] arm64: dts: qcom: eliza-cqs-evk: Enable sound card support with WSA8845 and DMIC Ravi Hothi
2026-07-07 8:41 ` Konrad Dybcio
2026-07-08 11:27 ` Ravi Hothi
2026-07-08 12:12 ` Konrad Dybcio
2026-07-09 7:30 ` Ravi Hothi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aed53b10-31e4-4fd7-9dd7-7f305f69a8f9@oss.qualcomm.com \
--to=ravi.hothi@oss.qualcomm.com \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox