From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Ravi Hothi <ravi.hothi@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
mohammad.rafi.shaik@oss.qualcomm.com,
ajay.nandam@oss.qualcomm.com
Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: eliza-cqs-evk: Enable sound card support with WSA8845 and DMIC
Date: Tue, 7 Jul 2026 10:41:14 +0200 [thread overview]
Message-ID: <bbd86b28-b6e7-4483-93a1-bac96c2dba43@oss.qualcomm.com> (raw)
In-Reply-To: <20260703083421.2736184-3-ravi.hothi@oss.qualcomm.com>
On 7/1/26 7:43 PM, Ravi Hothi wrote:
> Enable the sound card on the Eliza CQS EVK platform, including the
> WSA8845 external speaker path and DMIC microphone capture via VA macro.
>
> Enable the required LPASS WSA macro, VA macro and SoundWire controller
> along with the necessary pinctrl configurations for DMIC and WSA
> SoundWire interfaces.
>
> Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
> ---
[...]
> +&lpass_vamacro {
> + status = "okay";
'status' should be the last property (let's also keep an \n before
it) - file-wide
[...]
> +&pm7550_gpios {
> + dmic-eldo-en-hog {
> + gpio-hog;
> + gpios = <7 GPIO_ACTIVE_HIGH>;
> + output-high;
> + line-name = "dmic-eldo-en";
> + };
Why add a hog if you defined the regulator already?
Konrad
next prev parent reply other threads:[~2026-07-07 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 8:34 [PATCH v1 0/2] arm64: dts: qcom: eliza: Add audio support Ravi Hothi
2026-07-03 8:34 ` [PATCH v1 1/2] arm64: dts: qcom: eliza: Add LPASS macro and SoundWire support Ravi Hothi
2026-07-07 8:42 ` Konrad Dybcio
2026-07-08 11:20 ` Ravi Hothi
2026-07-03 8:34 ` [PATCH v1 2/2] arm64: dts: qcom: eliza-cqs-evk: Enable sound card support with WSA8845 and DMIC Ravi Hothi
2026-07-07 8:41 ` Konrad Dybcio [this message]
2026-07-08 11:27 ` Ravi Hothi
2026-07-08 12:12 ` Konrad Dybcio
2026-07-09 7:30 ` Ravi Hothi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbd86b28-b6e7-4483-93a1-bac96c2dba43@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=ravi.hothi@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox