[PATCH] arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node

[PATCH] arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node

[Abhinaba Rakshit]

Qualcomm Inline Crypto Engine (ICE) platform driver now supports
an optional OPP-table.

Add OPP-table for ICE UFS device nodes for LeMans platform.

Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
---
Testing:
* dtbs_check
* Validated on LeMans-evk platform
---
 arch/arm64/boot/dts/qcom/lemans.dtsi | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
index 522ba43836a2425a8612506f5f7113f291f34706..43f96c6d3eb14140ef20091f5b25886c44fd5ac1 100644
--- a/arch/arm64/boot/dts/qcom/lemans.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
@@ -3109,6 +3109,32 @@ ice: crypto@1d88000 {
 			clock-names = "core",
 				      "iface";
 			power-domains = <&gcc UFS_PHY_GDSC>;
+
+			operating-points-v2 = <&ice_opp_table>;
+
+			ice_opp_table: opp-table {
+				compatible = "operating-points-v2";
+
+				opp-75000000 {
+					opp-hz = /bits/ 64 <750000000>;
+					required-opps = <&rpmhpd_opp_svs_l1>;
+				};
+
+				opp-150000000 {
+					opp-hz = /bits/ 64 <150000000>;
+					required-opps = <&rpmhpd_opp_svs_l1>;
+				};
+
+				opp-300000000 {
+					opp-hz = /bits/ 64 <300000000>;
+					required-opps = <&rpmhpd_opp_nom>;
+				};
+
+				opp-600000000 {
+					opp-hz = /bits/ 64 <600000000>;
+					required-opps = <&rpmhpd_opp_nom>;
+				};
+			};
 		};
 
 		cryptobam: dma-controller@1dc4000 {

---
base-commit: c1ecb239fa3456529a32255359fc78b69eb9d847
change-id: 20260525-add-opp-table-for-lemans-ice-ufs-156d70e2696c

Best regards,
-- 
Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>

Re: [PATCH] arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Mismatch between OPP node name `opp-75000000` and its `opp-hz` value, incorrectly specifying 750 MHz instead of 75 MHz.
--

commit 7df0ac8d5186b38efd03084ecec240e439760d84
Author: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>

arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node

This commit adds an optional OPP-table for the Inline Crypto Engine (ICE) UFS
device nodes on the Qualcomm LeMans platform. It defines the operating points
by specifying required clock frequencies and their corresponding power domain
performance states.

> diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
> --- a/arch/arm64/boot/dts/qcom/lemans.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi

[ ... ]

> @@ -3109,6 +3109,32 @@ ice: crypto@1d88000 {
>  			clock-names = "core",
>  				      "iface";
>  			power-domains = <&gcc UFS_PHY_GDSC>;
> +
> +			operating-points-v2 = <&ice_opp_table>;
> +
> +			ice_opp_table: opp-table {
> +				compatible = "operating-points-v2";
> +
> +				opp-75000000 {
> +					opp-hz = /bits/ 64 <750000000>;

[Severity: High]
Does this opp-hz value have an extra zero? 

The node name is opp-75000000, but the frequency specified is 750000000 
(750 MHz) instead of 75 MHz. Requesting a 750 MHz clock frequency at the 
rpmhpd_opp_svs_l1 low power state could potentially cause clock scaling 
failures or hardware instability for the ICE block.

> +					required-opps = <&rpmhpd_opp_svs_l1>;
> +				};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527-add-opp-table-for-lemans-ice-ufs-v1-1-3f97f5ce60db@oss.qualcomm.com?part=1

Re: [PATCH] arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node

[Abhinaba Rakshit]

On Wed, May 27, 2026 at 10:16:20AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] Mismatch between OPP node name `opp-75000000` and its `opp-hz` value, incorrectly specifying 750 MHz instead of 75 MHz.
> --
> 
> commit 7df0ac8d5186b38efd03084ecec240e439760d84
> Author: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
> 
> arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node
> 
> This commit adds an optional OPP-table for the Inline Crypto Engine (ICE) UFS
> device nodes on the Qualcomm LeMans platform. It defines the operating points
> by specifying required clock frequencies and their corresponding power domain
> performance states.
> 
> > diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
> > --- a/arch/arm64/boot/dts/qcom/lemans.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
> 
> [ ... ]
> 
> > @@ -3109,6 +3109,32 @@ ice: crypto@1d88000 {
> >  			clock-names = "core",
> >  				      "iface";
> >  			power-domains = <&gcc UFS_PHY_GDSC>;
> > +
> > +			operating-points-v2 = <&ice_opp_table>;
> > +
> > +			ice_opp_table: opp-table {
> > +				compatible = "operating-points-v2";
> > +
> > +				opp-75000000 {
> > +					opp-hz = /bits/ 64 <750000000>;
> 
> [Severity: High]
> Does this opp-hz value have an extra zero? 
> 
> The node name is opp-75000000, but the frequency specified is 750000000 
> (750 MHz) instead of 75 MHz. Requesting a 750 MHz clock frequency at the 
> rpmhpd_opp_svs_l1 low power state could potentially cause clock scaling 
> failures or hardware instability for the ICE block.
> 
> > +					required-opps = <&rpmhpd_opp_svs_l1>;
> > +				};

Thanks for pointing this out.
Apologies, it's a miss on my side.
I will fix this in the next patch set.

Abhinaba Rakshit