Devicetree
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nguyen Minh Tien <zizuzacker@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] iio: adc: Add Texas Instruments ADS1220 ADC
Date: Thu, 11 Jun 2026 10:06:41 +0300	[thread overview]
Message-ID: <aipegeFkRY7sZasE@ashevche-desk.local> (raw)
In-Reply-To: <20260610151342.44274-1-zizuzacker@gmail.com>

On Wed, Jun 10, 2026 at 10:13:40PM +0700, Nguyen Minh Tien wrote:
> This series adds support for the Texas Instruments ADS1220, a 24-bit,
> 2-kSPS, 4-channel delta-sigma ADC with an SPI (mode 1) interface, a
> programmable gain amplifier (1 to 128), an internal 2.048V reference and
> a dedicated DRDY data-ready output.
> 
> The driver supports:
>  - single-ended and differential voltage channels described as
>    device-tree child nodes;
>  - per-channel programmable gain (via _scale) and data rate (via
>    _sampling_frequency), with the matching *_available attributes;
>  - the internal 2.048V reference, an external reference on REFP0/REFN0
>    via a regulator, or the analog supply (AVDD) as a ratiometric
>    reference for single-supply measurements;
>  - single-shot conversions gated on the DRDY interrupt, or on a
>    data-rate-derived delay when no interrupt is wired;
>  - a DRDY-interrupt-driven triggered buffer for streaming;
>  - runtime PM (power-down between conversions).
> 
> I tested this on a Lichee Pi Nano (Allwinner F1C100s) running Linux 7.0:
> with a potentiometer on AIN0 (single-ended against AVSS, AVDD as the
> reference), in_voltage0_raw tracks the wiper linearly across the full
> 0..3.3V range (0 to 0x7fffff). Nothing in the driver is board-specific -
> it only uses the SPI and IIO frameworks - so it should work on any SPI
> host.
> 
> This is my first kernel contribution. I modelled the driver on the
> existing TI ADS-family IIO drivers - ti-ads1119 for the structure and
> ti-ads124s08 for the SPI side - so I'd welcome any feedback on things
> I've missed.

When adding a brand new driver, answer to the following questions:
- Why a new driver? Can any existed one cover these chips with some refactoring?
- Where to find a datasheet (URL, other means)?

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2026-06-11  7:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 15:13 [PATCH 0/2] iio: adc: Add Texas Instruments ADS1220 ADC Nguyen Minh Tien
2026-06-10 15:13 ` [PATCH 1/2] dt-bindings: iio: adc: Add TI ADS1220 Nguyen Minh Tien
2026-06-10 15:29   ` sashiko-bot
2026-06-11 18:00     ` Conor Dooley
2026-06-11 12:15   ` Jonathan Cameron
2026-06-11 17:47   ` Conor Dooley
2026-06-12 16:10   ` David Lechner
2026-06-12 17:07     ` David Lechner
2026-06-10 15:13 ` [PATCH 2/2] iio: adc: Add TI ADS1220 driver Nguyen Minh Tien
2026-06-10 15:43   ` sashiko-bot
2026-06-11 13:00   ` Jonathan Cameron
2026-06-11 16:00   ` Andy Shevchenko
2026-06-12 16:14   ` David Lechner
2026-06-11  7:06 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aipegeFkRY7sZasE@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=zizuzacker@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox