From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Erim, Salih" <salih.erim@amd.com>
Cc: jic23@kernel.org, andy@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, conall.ogriofa@amd.com,
michal.simek@amd.com, linux@roeck-us.net, erimsalih@gmail.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/5] iio: adc: versal-sysmon: add I2C driver
Date: Tue, 16 Jun 2026 10:45:52 +0300 [thread overview]
Message-ID: <ajD_MMpiVQIwtbV3@ashevche-desk.local> (raw)
In-Reply-To: <15d14eee-8384-4605-ad83-5aad774541ac@amd.com>
On Mon, Jun 15, 2026 at 04:42:43PM +0100, Erim, Salih wrote:
> On 15/06/2026 15:30, Andy Shevchenko wrote:
> > On Mon, Jun 15, 2026 at 12:37:20AM +0100, Salih Erim wrote:
...
> > > +static const struct regmap_config sysmon_i2c_regmap_config = {
> > > + .reg_bits = 32,
> > > + .val_bits = 32,
> > > + .reg_stride = SYSMON_REG_STRIDE,
> > > + .max_register = SYSMON_MAX_REG,
> > > + .reg_read = sysmon_i2c_reg_read,
> > > + .reg_write = sysmon_i2c_reg_write,
> > > +};
> >
> > No cache?
>
> No, the registers are live ADC readings and interrupt status.
> Caching would return stale voltage and temperature data.
So, basically what you are saying is this:
"All registers are volatile in this HW."
Or alternatively:
"Almost all registers are volatile in this HW. The rest is not being accessed
too often to cache."
Choose the one that fits and add on top of this regmap_config initialiser.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-16 7:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-14 23:37 [PATCH v7 0/5] iio: adc: add AMD/Xilinx Versal SysMon driver Salih Erim
2026-06-14 23:37 ` [PATCH v7 1/5] dt-bindings: iio: adc: add xlnx,versal-sysmon binding Salih Erim
2026-06-14 23:37 ` [PATCH v7 2/5] iio: adc: add Versal SysMon driver Salih Erim
2026-06-15 14:22 ` Andy Shevchenko
2026-06-15 15:41 ` Erim, Salih
2026-06-16 7:43 ` Andy Shevchenko
2026-06-16 12:12 ` Erim, Salih
2026-06-14 23:37 ` [PATCH v7 3/5] iio: adc: versal-sysmon: add I2C driver Salih Erim
2026-06-15 14:30 ` Andy Shevchenko
2026-06-15 15:42 ` Erim, Salih
2026-06-16 7:45 ` Andy Shevchenko [this message]
2026-06-16 12:17 ` Erim, Salih
2026-06-14 23:37 ` [PATCH v7 4/5] iio: adc: versal-sysmon: add threshold event support Salih Erim
2026-06-14 23:48 ` sashiko-bot
2026-06-15 14:43 ` Andy Shevchenko
2026-06-15 15:45 ` Erim, Salih
2026-06-14 23:37 ` [PATCH v7 5/5] iio: adc: versal-sysmon: add oversampling support Salih Erim
2026-06-14 23:47 ` sashiko-bot
2026-06-15 14:28 ` Andy Shevchenko
2026-06-15 15:50 ` Erim, Salih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajD_MMpiVQIwtbV3@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conall.ogriofa@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=erimsalih@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.simek@amd.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=salih.erim@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox