From: Frank Li <Frank.li@oss.nxp.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Bryan O'Donoghue <bod@kernel.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v12 4/6] media: qcom: camss: Add legacy_phy flag to SoC definition structures
Date: Thu, 9 Jul 2026 11:48:48 -0400 [thread overview]
Message-ID: <ak_C4BCzekUIdBwc@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260708-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v12-4-f8588da41f16@linaro.org>
On Wed, Jul 08, 2026 at 01:06:58AM +0100, Bryan O'Donoghue wrote:
> Flag which SoCs have legacy - builtin PHY code. This will be useful in
> subsequent patches to inform PHY bringup logic if legacy bindings are
> available.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/media/platform/qcom/camss/camss.c | 17 +++++++++++++++++
> drivers/media/platform/qcom/camss/camss.h | 1 +
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 95e655a8b6aa0..e814a96953b1b 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -5512,6 +5512,7 @@ static void camss_remove(struct platform_device *pdev)
>
> static const struct camss_resources msm8916_resources = {
> .version = CAMSS_8x16,
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_8x16,
> .csid_res = csid_res_8x16,
> .ispif_res = &ispif_res_8x16,
> @@ -5523,6 +5524,7 @@ static const struct camss_resources msm8916_resources = {
>
> static const struct camss_resources msm8939_resources = {
> .version = CAMSS_8x39,
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_8x39,
> .csid_res = csid_res_8x39,
> .ispif_res = &ispif_res_8x39,
> @@ -5534,6 +5536,7 @@ static const struct camss_resources msm8939_resources = {
>
> static const struct camss_resources msm8953_resources = {
> .version = CAMSS_8x53,
> + .legacy_phy = true,
> .icc_res = icc_res_8x53,
> .icc_path_num = ARRAY_SIZE(icc_res_8x53),
> .csiphy_res = csiphy_res_8x96,
> @@ -5547,6 +5550,7 @@ static const struct camss_resources msm8953_resources = {
>
> static const struct camss_resources msm8996_resources = {
> .version = CAMSS_8x96,
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_8x96,
> .csid_res = csid_res_8x96,
> .ispif_res = &ispif_res_8x96,
> @@ -5558,6 +5562,7 @@ static const struct camss_resources msm8996_resources = {
>
> static const struct camss_resources qcm2290_resources = {
> .version = CAMSS_2290,
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_2290,
> .csid_res = csid_res_2290,
> .vfe_res = vfe_res_2290,
> @@ -5571,6 +5576,7 @@ static const struct camss_resources qcm2290_resources = {
> static const struct camss_resources qcs8300_resources = {
> .version = CAMSS_8300,
> .pd_name = "top",
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_8300,
> .tpg_res = tpg_res_8775p,
> .csid_res = csid_res_8775p,
> @@ -5587,6 +5593,7 @@ static const struct camss_resources qcs8300_resources = {
> static const struct camss_resources sa8775p_resources = {
> .version = CAMSS_8775P,
> .pd_name = "top",
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_8775p,
> .tpg_res = tpg_res_8775p,
> .csid_res = csid_res_8775p,
> @@ -5602,6 +5609,7 @@ static const struct camss_resources sa8775p_resources = {
>
> static const struct camss_resources sdm660_resources = {
> .version = CAMSS_660,
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_660,
> .csid_res = csid_res_660,
> .ispif_res = &ispif_res_660,
> @@ -5613,6 +5621,7 @@ static const struct camss_resources sdm660_resources = {
>
> static const struct camss_resources sdm670_resources = {
> .version = CAMSS_845,
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_670,
> .csid_res = csid_res_670,
> .vfe_res = vfe_res_670,
> @@ -5624,6 +5633,7 @@ static const struct camss_resources sdm670_resources = {
> static const struct camss_resources sdm845_resources = {
> .version = CAMSS_845,
> .pd_name = "top",
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_845,
> .csid_res = csid_res_845,
> .vfe_res = vfe_res_845,
> @@ -5635,6 +5645,7 @@ static const struct camss_resources sdm845_resources = {
> static const struct camss_resources sm6150_resources = {
> .version = CAMSS_6150,
> .pd_name = "top",
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_sm6150,
> .csid_res = csid_res_sm6150,
> .vfe_res = vfe_res_sm6150,
> @@ -5661,6 +5672,7 @@ static const struct camss_resources sm6350_resources = {
> static const struct camss_resources sm8250_resources = {
> .version = CAMSS_8250,
> .pd_name = "top",
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_8250,
> .csid_res = csid_res_8250,
> .vfe_res = vfe_res_8250,
> @@ -5674,6 +5686,7 @@ static const struct camss_resources sm8250_resources = {
> static const struct camss_resources sc8280xp_resources = {
> .version = CAMSS_8280XP,
> .pd_name = "top",
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_sc8280xp,
> .csid_res = csid_res_sc8280xp,
> .ispif_res = NULL,
> @@ -5688,6 +5701,7 @@ static const struct camss_resources sc8280xp_resources = {
> static const struct camss_resources sc7280_resources = {
> .version = CAMSS_7280,
> .pd_name = "top",
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_7280,
> .csid_res = csid_res_7280,
> .vfe_res = vfe_res_7280,
> @@ -5701,6 +5715,7 @@ static const struct camss_resources sc7280_resources = {
> static const struct camss_resources sm8550_resources = {
> .version = CAMSS_8550,
> .pd_name = "top",
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_8550,
> .csid_res = csid_res_8550,
> .vfe_res = vfe_res_8550,
> @@ -5715,6 +5730,7 @@ static const struct camss_resources sm8550_resources = {
> static const struct camss_resources sm8650_resources = {
> .version = CAMSS_8650,
> .pd_name = "top",
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_sm8650,
> .csid_res = csid_res_sm8650,
> .csid_wrapper_res = &csid_wrapper_res_sm8550,
> @@ -5729,6 +5745,7 @@ static const struct camss_resources sm8650_resources = {
> static const struct camss_resources x1e80100_resources = {
> .version = CAMSS_X1E80100,
> .pd_name = "top",
> + .legacy_phy = true,
> .csiphy_res = csiphy_res_x1e80100,
> .tpg_res = tpg_res_x1e80100,
> .csid_res = csid_res_x1e80100,
> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
> index 93d691c8ac63b..698694d3064ea 100644
> --- a/drivers/media/platform/qcom/camss/camss.h
> +++ b/drivers/media/platform/qcom/camss/camss.h
> @@ -107,6 +107,7 @@ enum icc_count {
> struct camss_resources {
> enum camss_version version;
> const char *pd_name;
> + const bool legacy_phy;
> const struct camss_subdev_resources *csiphy_res;
> const struct camss_subdev_resources *tpg_res;
> const struct camss_subdev_resources *csid_res;
>
> --
> 2.54.0
>
next prev parent reply other threads:[~2026-07-09 15:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 0:06 [PATCH v12 0/6] Add dt-bindings and PHY updates for CAMSS on x1e80100 silicon Bryan O'Donoghue
2026-07-08 0:06 ` [PATCH v12 1/6] dt-bindings: media: qcom,x1e80100-camss: Add optional PHY handle definitions Bryan O'Donoghue
2026-07-08 0:16 ` sashiko-bot
2026-07-08 1:34 ` Rob Herring (Arm)
2026-07-08 7:49 ` Vladimir Zapolskiy
2026-07-08 22:09 ` Frank Li
2026-07-08 22:15 ` Bryan O'Donoghue
2026-07-08 0:06 ` [PATCH v12 2/6] dt-bindings: media: qcom,x1e80100-camss: Describe iommu entries Bryan O'Donoghue
2026-07-08 12:39 ` Loic Poulain
2026-07-08 15:15 ` Vikram Sharma
2026-07-08 21:32 ` Bryan O'Donoghue
2026-07-09 15:28 ` Vikram Sharma
2026-07-09 15:50 ` Bryan O'Donoghue
2026-07-08 0:06 ` [PATCH v12 3/6] media: qcom: camss: Add support to populate sub-devices Bryan O'Donoghue
2026-07-08 0:18 ` sashiko-bot
2026-07-09 15:47 ` Frank Li
2026-07-08 0:06 ` [PATCH v12 4/6] media: qcom: camss: Add legacy_phy flag to SoC definition structures Bryan O'Donoghue
2026-07-08 0:14 ` sashiko-bot
2026-07-08 0:16 ` Bryan O'Donoghue
2026-07-09 15:48 ` Frank Li [this message]
2026-07-09 16:33 ` Loic Poulain
2026-07-08 0:06 ` [PATCH v12 5/6] media: qcom: camss: Add support for PHY API devices Bryan O'Donoghue
2026-07-08 0:19 ` sashiko-bot
2026-07-09 16:08 ` Frank Li
2026-07-08 0:07 ` [PATCH v12 6/6] media: qcom: camss: Drop legacy PHY descriptions from x1e Bryan O'Donoghue
2026-07-08 0:26 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak_C4BCzekUIdBwc@lizhi-Precision-Tower-5810 \
--to=frank.li@oss.nxp.com \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox