Re: Re: [PATCH v5 10/12] serial: 8250: add Ambarella UART driver

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, Aug 19, 2026 at 02:31:59PM +0800, zl020895 wrote:
> 
> Thanks for the review.

> This is Ambarella 8250-compatible IP, not Synopsys DesignWare. We
> first tried 8250_dw after Linus asked us to move to the 8250 library;
> you then told us not to touch 8250_dw and to use 8250_ambarella
> instead. That is what this patch is.
> Background:
> https://lore.kernel.org/r/CAD++jLm6HzEU1TM-c=Vtjv3FJEBecVP7TyxSgq_Q0zF-YwT6NA@mail.gmail.com/
> https://lore.kernel.org/linux-serial/an8KvvHWX0naH3Xw@ashevche-desk.local/
> https://lore.kernel.org/linux-serial/7E774305-3920-4BB7-BA46-E0772D6BED84@ambarella.com/
> I will also switch to uart_read_port_properties() and trim the
> 8250_dw-derived boilerplate.

Thanks for the register descriptions, it was helpful. After going through them
it seems the v3 as you made it is good enough (sorry for going back and forth).
What it needs is better commit message explaining that while it's not a Synopsys
DW IP, it was made to be quite compatible with that (on register level) and hence
no new driver is required, just a small quirk.

-- 
With Best Regards,
Andy Shevchenko