Devicetree
 help / color / mirror / Atom feed
From: Stefano Radaelli <stefano.radaelli21@gmail.com>
To: Frank Li <Frank.li@oss.nxp.com>
Cc: sashiko-reviews@lists.linux.dev, conor+dt@kernel.org,
	robh@kernel.org, Frank.Li@kernel.org, imx@lists.linux.dev,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: imx8mm-var-dart: add TPM support
Date: Thu, 17 Sep 2026 21:14:19 +0200	[thread overview]
Message-ID: <aqw8C2YwvXOcRYPV@Lord-Beerus.station> (raw)
In-Reply-To: <aqw2zT8W6EvRroWj@SMW015318>

On Thu, Sep 17, 2026 at 01:51:57PM -0500, Frank Li wrote:
> 
> tpm_tis_core.c have not parser reset-gpios. ref
> 
> static int reset_gpio_assert(struct reset_controller_dev *rc, unsigned long id)
> {
>         struct reset_gpio_priv *priv = rc_to_reset_gpio(rc);
> 
>         return gpiod_set_value_cansleep(priv->reset, 1);
> }
> 
> suppose it should be GPIO_ACTIVE_LOW to assert reset line
> 
> Frank

Thanks Frank.

You're right, tpm_tis_i2c currently does not parse a reset control.
I have proposed a separate patch to add optional reset support using
the reset framework:

https://patchwork.kernel.org/project/linux-integrity/patch/20260917124211.136221-1-stefano.r@variscite.com/

Also, the reset line is active-low, so you are right, GPIO_ACTIVE_LOW
is the correct polarity here.

Would you prefer me to send v3 without the TPM DTS patch for now,
and add it back once the reset support patch has been accepted?

Best Regards,
Stefano

  reply	other threads:[~2026-09-17 19:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 15:41 [PATCH v2 0/3] arm64: dts: imx8mm-var-dart: update SoM support Stefano Radaelli
2026-09-17 15:41 ` [PATCH v2 1/3] arm64: dts: imx8mm-var-dart: configure SAI3 synchronous RX mode Stefano Radaelli
2026-09-17 15:41 ` [PATCH v2 2/3] arm64: dts: imx8mm-var-dart: add TPM support Stefano Radaelli
2026-09-17 15:50   ` sashiko-bot
2026-09-17 18:51     ` Frank Li
2026-09-17 19:14       ` Stefano Radaelli [this message]
2026-09-17 19:52         ` Frank Li
2026-09-17 15:41 ` [PATCH v2 3/3] arm64: dts: imx8mm-var-dart: increase PHY reset deassert delay Stefano Radaelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqw8C2YwvXOcRYPV@Lord-Beerus.station \
    --to=stefano.radaelli21@gmail.com \
    --cc=Frank.Li@kernel.org \
    --cc=Frank.li@oss.nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox