Re: [PATCH v2 2/3] arm64: dts: imx8mm-var-dart: add TPM support

[Frank Li <Frank.li@oss.nxp.com>]

On Thu, Sep 17, 2026 at 09:14:19PM +0200, Stefano Radaelli wrote:
> On Thu, Sep 17, 2026 at 01:51:57PM -0500, Frank Li wrote:
> >
> > tpm_tis_core.c have not parser reset-gpios. ref
> >
> > static int reset_gpio_assert(struct reset_controller_dev *rc, unsigned long id)
> > {
> >         struct reset_gpio_priv *priv = rc_to_reset_gpio(rc);
> >
> >         return gpiod_set_value_cansleep(priv->reset, 1);
> > }
> >
> > suppose it should be GPIO_ACTIVE_LOW to assert reset line
> >
> > Frank
>
> Thanks Frank.
>
> You're right, tpm_tis_i2c currently does not parse a reset control.
> I have proposed a separate patch to add optional reset support using
> the reset framework:
>
> https://patchwork.kernel.org/project/linux-integrity/patch/20260917124211.136221-1-stefano.r@variscite.com/
>
> Also, the reset line is active-low, so you are right, GPIO_ACTIVE_LOW
> is the correct polarity here.
>
> Would you prefer me to send v3 without the TPM DTS patch for now,
> and add it back once the reset support patch has been accepted?

You leave reset-gpios if binding already here. Just need fix GPIO_ACTIVE_LOW

Frank

>
> Best Regards,
> Stefano