From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Chang Yu" <marcus.yu.56@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Shi Hao" <i.shihao.999@gmail.com>,
"Jose A. Perez de Azpillaga" <azpijr@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] iio: light: add AS7343 multi-spectral sensor driver
Date: Tue, 13 Oct 2026 19:28:29 +0300 [thread overview]
Message-ID: <as5cLfhdv3rA69v1@ashevche-desk.local> (raw)
In-Reply-To: <20261013143521.00006de9@gmail.com>
On Tue, Oct 13, 2026 at 02:35:21PM +0200, Joshua Crofts wrote:
> On Tue, 13 Oct 2026 19:56:39 +0800
> Chang Yu <marcus.yu.56@gmail.com> wrote:
>
> > Add a driver for the AMS AS7343 14-channel multi-spectral sensor.
> >
> > The AS7343 is a 14-channel spectral sensor featuring 11 visible
> > channels, 1 near-infrared channel, 1 clear channel (VIS), and 1
> > flicker detection channel.
> >
> > The driver exposes 12 spectral channels (11 visible light and 1
> > near-infrared) via sysfs. Runtime PM is implemented to stop
> > measurements when the device is suspended or torn down. Power is
> > never cut (PON=1 always) to preserve register values.
> >
> > Future patches will add configurable gain and integration time,
> > interrupt support, buffered reads, VIS channel, and flicker
> > detection.
> >
> > Datasheet: https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7343-14-Channel-Multi-Spectral-Sensor.pdf
> > Signed-off-by: Chang Yu <marcus.yu.56@gmail.com>
> > ---
>
> I think this is ready to be applied.
I agree. I have a few nit-picks (easy to address), after that feel also free to
add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-13 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 11:56 [PATCH v6 0/2] Add support for AS7343 multi-spectral sensor Chang Yu
2026-10-13 11:56 ` [PATCH v6 1/2] dt-bindings: iio: light: add as7343 Chang Yu
2026-10-13 12:04 ` sashiko-bot
2026-10-13 12:36 ` Joshua Crofts
2026-10-13 15:15 ` Chang Yu
2026-10-13 11:56 ` [PATCH v6 2/2] iio: light: add AS7343 multi-spectral sensor driver Chang Yu
2026-10-13 12:35 ` Joshua Crofts
2026-10-13 16:28 ` Andy Shevchenko [this message]
2026-10-13 16:27 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as5cLfhdv3rA69v1@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=azpijr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=i.shihao.999@gmail.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.yu.56@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox