Devicetree
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: beacon: Increase sdhi speeds
@ 2026-11-16 10:41 Wolfram Sang
  2026-11-16 11:08 ` sashiko-bot
  2026-11-16 11:57 ` Wolfram Sang
  0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2026-11-16 10:41 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Adam Ford, Wolfram Sang, Geert Uytterhoeven, Magnus Damm,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree

From: Adam Ford <aford173@gmail.com>

The eMMC can run at hs400 and the WiFi chip can run at sdr104.
Set the respective flags to push the sdhi faster.

Signed-off-by: Adam Ford <aford173@gmail.com>
[wsa: rebased, add HS400 flag instead of replacing the HS200 one]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Okay, the original patch is really old, from around 2021 [1]. I found it
while looking for SDHI improvements and it is still easy enough to do
the requested changes and add these additional capabilities, so why not?

[1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20201224170502.2254683-9-aford173@gmail.com/

 arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
index 882513149042..8af2edaa690a 100644
--- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
+++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
@@ -288,8 +288,9 @@ &scif2 {
 };
 
 &sdhi2 {
-	pinctrl-names = "default";
 	pinctrl-0 = <&sdhi2_pins>;
+	pinctrl-1 = <&sdhi2_pins>;
+	pinctrl-names = "default", "state_uhs";
 	bus-width = <4>;
 	vmmc-supply = <&reg_3p3v>;
 	vqmmc-supply = <&reg_1p8v>;
@@ -297,6 +298,8 @@ &sdhi2 {
 	cap-power-off-card;
 	keep-power-in-suspend;
 	mmc-pwrseq = <&wlan_pwrseq>;
+	sd-uhs-sdr50;
+	sd-uhs-sdr104;
 	status = "okay";
 	#address-cells = <1>;
 	#size-cells = <0>;
@@ -317,6 +320,7 @@ &sdhi3 {
 	vqmmc-supply = <&reg_1p8v>;
 	bus-width = <8>;
 	mmc-hs200-1_8v;
+	mmc-hs400-1_8v;
 	no-sd;
 	no-sdio;
 	non-removable;
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: renesas: beacon: Increase sdhi speeds
  2026-11-16 10:41 [PATCH] arm64: dts: renesas: beacon: Increase sdhi speeds Wolfram Sang
@ 2026-11-16 11:08 ` sashiko-bot
  2026-11-16 11:57 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-11-16 11:08 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: renesas: beacon: HS400 enabled on r8a774a1 without
  SDHI quirks
--

commit b89b68011d07b5d887c10ae098b7d13e972848a1
Author: Adam Ford <aford173@gmail.com>

arm64: dts: renesas: beacon: Increase sdhi speeds

This commit enables UHS SDR50/SDR104 modes on sdhi2 for WiFi and HS400
mode on sdhi3 for the eMMC in the shared Beacon Renesom SOM device tree.

> diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> index 8825131490420..8af2edaa690af 100644
> --- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi

[ ... ]

> @@ -317,6 +320,7 @@ &sdhi3 {
>  	vqmmc-supply = <&reg_1p8v>;
>  	bus-width = <8>;
>  	mmc-hs200-1_8v;
> +	mmc-hs400-1_8v;
>  	no-sd;
>  	no-sdio;
>  	non-removable;

[Severity: High]
Does enabling mmc-hs400-1_8v here break eMMC HS400 transfers on
r8a774a1-beacon-rzg2m-kit with RZ/G2M ES1.3 or ES3.0?

beacon-renesom-som.dtsi is included by r8a774a1-beacon-rzg2m-kit.dts,
where sdhi3 has compatible "renesas,sdhi-r8a774a1",
"renesas,rcar-gen3-sdhi".  Unlike renesas,sdhi-r8a774b1 and
renesas,sdhi-r8a774e1, renesas_sdhi_internal_dmac_of_match[] has no
entry for renesas,sdhi-r8a774a1, so it falls back to
of_rcar_gen3_compatible with quirks set to NULL.  In sdhi_quirks_match[],
r8a774a1 only matches ES1.[012]:

drivers/mmc/host/renesas_sdhi_internal_dmac.c:
	{ .soc_id = "r8a774a1", .revision = "ES1.[012]", .data = &sdhi_quirks_4tap_nohs400 },
	{ .soc_id = "r8a7795", .revision = "ES2.0", .data = &sdhi_quirks_4tap },
	{ .soc_id = "r8a7796", .revision = "ES1.0", .data = &sdhi_quirks_4tap_nohs400_one_rx },
	{ .soc_id = "r8a7796", .revision = "ES1.[12]", .data = &sdhi_quirks_4tap_nohs400 },
	{ .soc_id = "r8a7796", .revision = "ES1.*", .data = &sdhi_quirks_r8a7796_es13 },

On r8a774a1 ES1.3 or ES3.0, HS400 is therefore enabled with quirks == NULL,
which programs 8-tap clock and SCC settings in renesas_sdhi_clk_update()
instead of 4-tap and skips bad-tap avoidance, manual tap correction, and
HS400 calibration table lookup for the onboard eMMC.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116104427.5152-2-wsa+renesas@sang-engineering.com?part=1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: renesas: beacon: Increase sdhi speeds
  2026-11-16 10:41 [PATCH] arm64: dts: renesas: beacon: Increase sdhi speeds Wolfram Sang
  2026-11-16 11:08 ` sashiko-bot
@ 2026-11-16 11:57 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2026-11-16 11:57 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Adam Ford, Geert Uytterhoeven, Magnus Damm, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]


> [Severity: High]
> Does enabling mmc-hs400-1_8v here break eMMC HS400 transfers on
> r8a774a1-beacon-rzg2m-kit with RZ/G2M ES1.3 or ES3.0?

Dunno which ES versions this SoM can carry. I will drop the relevant
hunk and leave the addition for a party really having the HW.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-16 11:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 10:41 [PATCH] arm64: dts: renesas: beacon: Increase sdhi speeds Wolfram Sang
2026-11-16 11:08 ` sashiko-bot
2026-11-16 11:57 ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox