From: Mina Chou <minachou@andestech.com>
To: Conor Dooley <conor@kernel.org>
Cc: <pjw@kernel.org>, <palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<alex@ghiti.fr>, <jic23@kernel.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<geert+renesas@glider.be>, <magnus.damm@gmail.com>,
<prabhakar.mahadev-lad.rj@bp.renesas.com>,
<linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <randolph@andestech.com>,
<cyyang772@andestech.com>, <tim609@andestech.com>,
<az70021@gmail.com>
Subject: Re: [PATCH v2 17/19] riscv: errata: andes: generalize cache errata for Andes cores
Date: Tue, 17 Nov 2026 18:11:55 +0800 [thread overview]
Message-ID: <avwoa/UDFV8iKG11@atcsi01.andestech.com> (raw)
In-Reply-To: <20261113-voice-pledge-d0b4e1420676@spud>
On Fri, Nov 13, 2026 at 01:59:11PM +0000, Conor Dooley wrote:
> > -static void errata_probe_iocp(unsigned int stage, unsigned long arch_id, unsigned long impid)
> > +static void errata_probe_andes_cache(unsigned int stage, unsigned long arch_id, unsigned long impid)
>
> Just call it probe so that you dont rename it again when the next
> erratum shows up?
>
Thanks for the suggestion, I'll give it a more generic name.
> > {
> > static bool done;
> >
> > @@ -51,11 +51,12 @@ static void errata_probe_iocp(unsigned int stage, unsigned long arch_id, unsigne
> >
> > done = true;
> >
> > - if (arch_id != ANDES_AX45MP_MARCHID || impid != ANDES_AX45MP_MIMPID)
> > - return;
> > -
> > - if (!ax45mp_iocp_sw_workaround())
> > + if (arch_id == ANDES_AX45MP_MARCHID && impid == ANDES_AX45MP_MIMPID) {
> > + if (!ax45mp_iocp_sw_workaround())
> > + return;
> > + } else if (riscv_isa_extension_available(NULL, ZICBOM)) {
> > return;
> > + }
>
> Is this correct? The code goes on to always mark noncoherent stuff
> supported, so this means that every andes device must then support
> noncoherent. The commit message's wording isn't that strong.
>
Yes, this is intended. IOCP is configurable on Andes cores: a core
either has no IOCP, or has IOCP that the SoC can enable or disable
(RZ/Five, for example, disables it). As this is up to each SoC, we
would rather not check it for every core and configuration, so the
errata marks non-coherent DMA as supported on every Andes core without
Zicbom.
This does not make any device non-coherent: a device is still coherent
unless the devicetree marks it dma-noncoherent, and the CCTL cache ops
are only registered when the devicetree has the LLC node.
I will make this explicit in the commit message.
> >
> > /* Set this just to make core cbo code happy */
>
> This comment is no longer accurate because you gave this value special
> meaning elsewhere in the series.
> That patch needs to change this comment.
>
> Cheers,
> Conor.
>
I will update the comment in the patch that gives this value its meaning.
Thanks,
Mina
next prev parent reply other threads:[~2026-11-17 10:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 7:11 [PATCH v2 00/19] riscv: andes: make the LLC driver and cache errata generic Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 01/19] cache: ax45mp_cache: use __initconst for ax45mp_cmo_ops Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 02/19] cache: ax45mp_cache: rename AX45MP-specific identifiers to generic ANDES Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 03/19] cache: ax45mp_cache: rename L2 identifiers to LLC Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 04/19] cache: ax45mp_cache: add shared header for Andes CSRs Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 05/19] cache: ax45mp_cache: standardize macro naming for LLC and L1D registers Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 06/19] cache: ax45mp_cache: rename ax45mp_cache.c to andes_llcache.c Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 07/19] cache: andes_llcache: clean up cache inv/wback functions Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 08/19] cache: andes_llcache: use u32 and fix the cache-line-size error message Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 09/19] cache: andes_llcache: write the full physical address for CCTL Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 10/19] cache: andes_llcache: register cache ops only when the errata needs them Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 11/19] cache: andes_llcache: use the hart ID to index the CCTL registers Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 12/19] dt-bindings: cache: andestech: update schema for generic LLC support Mina Hui-Min Chou
2026-11-13 14:05 ` Conor Dooley
2026-11-16 12:05 ` Krzysztof Kozlowski
2026-11-16 18:00 ` Conor Dooley
2026-11-17 9:20 ` Mina Chou
2026-11-13 7:11 ` [PATCH v2 13/19] dt-bindings: cache: rename andestech,ax45mp-cache to andestech,llcache Mina Hui-Min Chou
2026-11-13 14:01 ` Conor Dooley
2026-11-16 12:01 ` Krzysztof Kozlowski
2026-11-13 7:11 ` [PATCH v2 14/19] cache: andes_llcache: add generic andestech,llcache compatible Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 15/19] MAINTAINERS: Add maintainer for Andes cache driver Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 16/19] riscv: errata: andes: allow ERRATA_ANDES_CMO on all Andes SoCs Mina Hui-Min Chou
2026-11-13 14:00 ` Conor Dooley
2026-11-17 3:28 ` Mina Chou
2026-11-13 7:11 ` [PATCH v2 17/19] riscv: errata: andes: generalize cache errata for Andes cores Mina Hui-Min Chou
2026-11-13 13:59 ` Conor Dooley
2026-11-17 10:11 ` Mina Chou [this message]
2026-11-13 7:11 ` [PATCH v2 18/19] riscv: errata: andes: limit the IOCP workaround to RZ/Five Mina Hui-Min Chou
2026-11-13 13:53 ` Conor Dooley
2026-11-17 9:24 ` Mina Chou
2026-11-13 16:21 ` [PATCH v2 00/19] riscv: andes: make the LLC driver and cache errata generic Conor Dooley
2026-11-16 1:22 ` Mina Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avwoa/UDFV8iKG11@atcsi01.andestech.com \
--to=minachou@andestech.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=az70021@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=cyyang772@andestech.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=magnus.damm@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=randolph@andestech.com \
--cc=robh@kernel.org \
--cc=tim609@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox