Re: [PATCH v2 1/2] arm64: dts: socfpga: Enable the SMMU for SoCFPGA device trees

[Dinh Nguyen <dinguyen@kernel.org>]

On 5/15/26 03:00, muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
> 
> Enable the SMMU on the SoCFPGA board device trees where it was
> missing. The SoC uses a different memory-mapped base address for
> its peripherals, which requires the System Memory Management Unit
> (SMMU) to be active so that the Secure Device Manager (SDM) can
> correctly access those regions through address translation.
> 
> Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
> ---
> Changes in v2:
> - Move SMMU enable into the base DTSI file instead of individual DTS files
> 
>   arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> index b06c6d5d60ee..64f3739a0c33 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> @@ -385,7 +385,7 @@ smmu: iommu@16000000 {
>   			interrupt-names = "eventq", "gerror", "priq";
>   			dma-coherent;
>   			#iommu-cells = <1>;
> -			status = "disabled";
> +			status = "okay";
>   		};
>   
>   		spi0: spi@10da4000 {

Please make it a practice to see what formatting previous commits look 
like on the subsystem you're making changes to. For example, this commit 
header should be something like this:


arm64: dts: socfpga: agilex5: Enable the SMMU

Then in your commit message should not restate your commit header. So 
remove "Enable the SMMU on the SoCFPGA board device trees"

Thanks,
Dinh