Re: [PATCH v2 1/2] arm64: dts: socfpga: Enable the SMMU for SoCFPGA device trees

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete Refactoring (Redundant Overrides)
--

commit 1b8d9495374546485f67ed52546157ae1e006ba8
Author: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>

arm64: dts: socfpga: Enable the SMMU for SoCFPGA device trees

This commit enables the SMMU on the SoCFPGA board device trees by setting its
status to okay in the base dtsi file. This is needed so the Secure Device
Manager can correctly access memory-mapped peripheral regions.

> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> index 352c96d144a84..527a5ef54c837 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> @@ -385,7 +385,7 @@ smmu: iommu@16000000 {
>  			interrupt-names = "eventq", "gerror", "priq";
>  			dma-coherent;
>  			#iommu-cells = <1>;
> -			status = "disabled";
> +			status = "okay";

This isn't a bug, but since the status is now set to okay in the base dtsi,
does this make the existing overrides in the board specific device trees
redundant?

For example, socfpga_agilex5_socdk_modular.dts,
socfpga_agilex5_socdk_013b.dts, and socfpga_agilex3_socdk.dts already
contain:

&smmu {
	status = "okay";
};

Could these board-level overrides be removed in this patch to maintain
device tree cleanliness?

>  		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515080014.6260-1-muhammad.nazim.amirul.nazle.asmade@altera.com?part=1