Re: [PATCH v2 10/11] arm64: dts: qcom: sdm670: add digital audio codec

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 10/19/26 4:46 PM, Richard Acayan wrote:
> On Fri, Oct 16, 2026 at 12:21:10PM +0200, Konrad Dybcio wrote:
>> On 10/3/26 7:56 PM, Richard Acayan wrote:
>>> Add the digital WCD audio codec to the SDM670 device tree.
>>>
>>> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/sdm670.dtsi | 15 +++++++++++++++
>>>  1 file changed, 15 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
>>> index 038ef0f73ea9..91188acd16b1 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi
>>> @@ -21,6 +21,7 @@
>>>  #include <dt-bindings/power/qcom-rpmpd.h>
>>>  #include <dt-bindings/soc/qcom,apr.h>
>>>  #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>>> +#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
>>>  
>>>  / {
>>>  	interrupt-parent = <&intc>;
>>> @@ -2541,5 +2542,19 @@ data2-pins {
>>>  				};
>>>  			};
>>>  		};
>>> +
>>> +		lpass_codec: audio-codec@62ec0000 {
>>> +			compatible = "qcom,sdm670-wcd-digital-codec",
>>> +				     "qcom,msm8916-wcd-digital-codec";
>>> +			reg = <0 0x62ec0000 0 0x400>;
>>> +
>>> +			clocks = <&q6afecc LPASS_CLK_ID_INT_MCLK_0 LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
>>> +			clock-names = "mclk";
>>
>> This clock configuration is forbidden according to bindings
> 
> It is corrected in patch 11 which is why this isn't caught. I'll move
> the fixed clock to sdm670.dtsi.
> 
>> I'm not expert in audio, but an LLM points me towards
>> LPASS_CLK_ID_INTERNAL_DIGITAL_CODEC_CORE
> 
> Does the LLM have access to schematics?

That LLM has access to more than just schematics..

But at the end of the day it's just an LLM. I don't know for sure
and that's why I wrote it that way.

Konrad