From: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>
To: sashiko-reviews@lists.linux.dev
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH ath-next 14/15] wifi: ath12k: add and hook Wi-Fi 8 mac80211 ops skeleton for QCN9575
Date: Wed, 18 Nov 2026 10:54:13 +0530 [thread overview]
Message-ID: <cc8e97f5-be62-40ab-81ed-4f23e50bb14a@oss.qualcomm.com> (raw)
In-Reply-To: <sashiko-outbox-210929@kernel.org>
On 11/12/2026 3:49 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Medium] wifi: ath12k: missing sta_set_4addr callback in
> ath12k_ops_wifi8
> --
>
> commit 6de3568cf375a8ba9425721f1a8ad36656373d50
> Author: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>
>
> wifi: ath12k: add and hook Wi-Fi 8 mac80211 ops skeleton for QCN9575
>
> This commit adds a dedicated ath12k_ops_wifi8 ieee80211_ops table with a
> placeholder TX callback and existing common ath12k_mac_op_* callbacks,
> and hooks it in ath12k_wifi8_hw_init().
>
>> diff --git a/drivers/net/wireless/ath/ath12k/wifi8/hw.c b/drivers/net/wireless/ath/ath12k/wifi8/hw.c
>> index 92c897de16f4f..30188f4fae022 100644
>> --- a/drivers/net/wireless/ath/ath12k/wifi8/hw.c
>> +++ b/drivers/net/wireless/ath/ath12k/wifi8/hw.c
>
> [ ... ]
>
>> @@ -152,6 +155,72 @@ static const struct ath12k_hw_params ath12k_wifi8_hw_params[] = {
>> },
>> };
>>
>> +static void ath12k_wifi8_mac_op_tx(struct ieee80211_hw *hw,
>> + struct ieee80211_tx_control *control,
>> + struct sk_buff *skb)
>> +{
>> + struct ath12k_hw *ah = ath12k_hw_to_ah(hw);
>> +
>> + __ath12k_warn(ah->dev, "wifi8: tx stub is a placeholder, dropping frame\n");
>> + ieee80211_free_txskb(hw, skb);
>> +}
>> +
>> +static const struct ieee80211_ops ath12k_ops_wifi8 = {
>> + .tx = ath12k_wifi8_mac_op_tx,
>> + .wake_tx_queue = ieee80211_handle_wake_tx_queue,
>> + .start = ath12k_mac_op_start,
>> + .stop = ath12k_mac_op_stop,
>> + .reconfig_complete = ath12k_mac_op_reconfig_complete,
>> + .add_interface = ath12k_mac_op_add_interface,
>> + .remove_interface = ath12k_mac_op_remove_interface,
>> + .update_vif_offload = ath12k_mac_op_update_vif_offload,
>> + .link_info_changed = ath12k_mac_op_link_info_changed,
>> + .vif_cfg_changed = ath12k_mac_op_vif_cfg_changed,
>> + .change_vif_links = ath12k_mac_op_change_vif_links,
>> + .configure_filter = ath12k_mac_op_configure_filter,
>> + .hw_scan = ath12k_mac_op_hw_scan,
>> + .cancel_hw_scan = ath12k_mac_op_cancel_hw_scan,
>> + .set_key = ath12k_mac_op_set_key,
>> + .set_rekey_data = ath12k_mac_op_set_rekey_data,
>> + .sta_state = ath12k_mac_op_sta_state,
>> + .sta_set_txpwr = ath12k_mac_op_sta_set_txpwr,
>> + .link_sta_rc_update = ath12k_mac_op_link_sta_rc_update,
>> + .conf_tx = ath12k_mac_op_conf_tx,
>
> [Severity: Medium]
> Should ath12k_ops_wifi8 also wire .sta_set_4addr to
> ath12k_mac_op_sta_set_4addr like ath12k_ops_wifi7 does?
>
> The other shared callbacks here (ath12k_mac_op_update_vif_offload() and
> ath12k_mac_op_add_interface()) enable IEEE80211_OFFLOAD_ENCAP_4ADDR and
> WMI_VDEV_PARAM_WDS on 4-address interfaces, but without .sta_set_4addr,
> drv_sta_set_4addr() is a no-op and never configures WMI_PEER_USE_4ADDR or
> peer->dp_peer->use_4addr when a 4-address station associates.
>
This is a false positive, since the CP/DP changes will fill in the
remaining fields.
next prev parent reply other threads:[~2026-11-18 5:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 8:32 [PATCH ath-next 00/15] wifi: ath12k: add initial Wi-Fi 8 support for QCN9575 Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 01/15] dt-bindings: net: wireless: add ath12k wifi device QCN9575 Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 02/15] wifi: ath12k: refactor PCI window selection to per-device layout Madhavan Ganesan
2026-11-12 8:46 ` sashiko-bot
2026-11-18 5:23 ` Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 03/15] wifi: ath12k: add extended QMI WLAN cfg for CE and service pipes Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 04/15] wifi: ath12k: add QMI support for extended firmware binary download Madhavan Ganesan
2026-11-12 9:07 ` sashiko-bot
2026-11-18 5:23 ` Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 05/15] wifi: ath12k: add Wi-Fi 8 directory and base module scaffolding Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 06/15] wifi: ath12k: add initial Wi-Fi 8 hw params and init helper for QCN9575 Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 07/15] wifi: ath12k: add Wi-Fi 8 HAL register table and hal init hook " Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 08/15] wifi: ath12k: add Wi-Fi 8 HAL ops and descriptor definitions " Madhavan Ganesan
2026-11-12 9:25 ` sashiko-bot
2026-11-18 5:23 ` Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 09/15] wifi: ath12k: add unified firmware image support " Madhavan Ganesan
2026-11-12 9:44 ` sashiko-bot
2026-11-18 5:24 ` Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 10/15] wifi: ath12k: add Wi-Fi 8 MHI config " Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 11/15] wifi: ath12k: add Wi-Fi 8 CE config and service pipe map " Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 12/15] wifi: ath12k: add Wi-Fi 8 WMI init " Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 13/15] wifi: ath12k: add Wi-Fi 8 hw ops " Madhavan Ganesan
2026-11-12 8:32 ` [PATCH ath-next 14/15] wifi: ath12k: add and hook Wi-Fi 8 mac80211 ops skeleton " Madhavan Ganesan
2026-11-12 10:19 ` sashiko-bot
2026-11-18 5:24 ` Madhavan Ganesan [this message]
2026-11-12 8:32 ` [PATCH ath-next 15/15] wifi: ath12k: add Wi-Fi 8 PCI driver scaffolding " Madhavan Ganesan
2026-11-12 10:29 ` sashiko-bot
2026-11-18 5:24 ` Madhavan Ganesan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc8e97f5-be62-40ab-81ed-4f23e50bb14a@oss.qualcomm.com \
--to=madhavan.ganesan@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox