Re: [PATCH v2 1/4] arm64: dts: qcom: Add header file for ADC5 Gen3 channel macros

[Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>]

On 6/14/2026 1:42 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Devicetree binding headers for shared hardware components must be placed in `include/dt-bindings/`, not architecture-specific directories.
> --
> 
> commit 7bed566fe71218ad2ab3cd2babe147ee1d601536
> Author: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
> 
> arm64: dts: qcom: Add header file for ADC5 Gen3 channel macros
> 
> This commit adds macro definitions for ADC5 Gen3 virtual channels to be
> used in devicetrees and ADC channel reg properties.
> 
>> diff --git a/arch/arm64/boot/dts/qcom/qcom-adc5-gen3.h b/arch/arm64/boot/dts/qcom/qcom-adc5-gen3.h
>> new file mode 100644
>> index 0000000000000..aa8e54d7e786a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/qcom-adc5-gen3.h
>> @@ -0,0 +1,88 @@
>> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
>> +/*
>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>> + */
>> +
>> +#ifndef __DTS_ARM64_QCOM_ADC5_GEN3_H__
>> +#define __DTS_ARM64_QCOM_ADC5_GEN3_H__
>> +
>> +/* ADC channels for PMIC5 Gen3 */
>> +
>> +#define VIRT_CHAN(sid, chan)			((sid) << 8 | (chan))
> 
> [Severity: Low]
> Should this header be placed in include/dt-bindings/ instead of an
> architecture-specific directory?
> 
> Devicetree binding headers defining ABI constants for reg values typically
> reside in include/dt-bindings/ like include/dt-bindings/iio/adc/. Placing
> the header in arch/arm64/boot/dts/qcom/ prevents cross-architecture sharing
> and can break dt_binding_check validation, as the schema tooling expects to
> include these headers from the standard dt-bindings location.
> 

Based on this discussion earlier: https://lore.kernel.org/all/d10e2eea-4b86-4e1a-b7a0-54c55907a605@oss.qualcomm.com/,
these ADC channel definitions should be placed in the dts folder instead of
dt-bindings folder as they are hardware constants meant to be directly
written into registers and not ABI constants.

Thanks,
Jishnu


> [ ... ]
>