Re: [PATCH] arm64: dts: qcom: sm8650: add description of CCI controllers

[Bryan O'Donoghue <bryan.odonoghue@linaro.org>]

On 10/04/2024 08:49, Vladimir Zapolskiy wrote:
> +			clocks = <&camcc CAM_CC_CAMNOC_AXI_NRT_CLK>,
> +				 <&camcc CAM_CC_SLOW_AHB_CLK_SRC>,
> +				 <&camcc CAM_CC_CPAS_AHB_CLK>,
> +				 <&camcc CAM_CC_CCI_0_CLK>;
> +			clock-names = "camnoc_axi",
> +				      "slow_ahb_src",
> +				      "cpas_ahb",
> +				      "cci";

So..

You still need a new compat for this clock list right ?

Current options for clocks which need camnoc_axi are

   - if:
       properties:
         compatible:
           contains:
             enum:
               - qcom,sdm845-cci
               - qcom,sm6350-cci
     then:
       properties:
         clocks:
           minItems: 6
         clock-names:
           items:
             - const: camnoc_axi
             - const: soc_ahb
             - const: slow_ahb_src
             - const: cpas_ahb
             - const: cci
             - const: cci_src

and

   - if:
       properties:
         compatible:
           contains:
             enum:
               - qcom,sc7280-cci
               - qcom,sm8250-cci
               - qcom,sm8450-cci
     then:
       properties:
         clocks:
           minItems: 5
           maxItems: 5
         clock-names:
           items:
             - const: camnoc_axi
             - const: slow_ahb_src
             - const: cpas_ahb
             - const: cci
             - const: cci_src


Also suggest you should look into dropping

slow_ahb_src
cci_src

May not be technically feasible though I accept.

---
bod