From: Krzysztof Kozlowski <krzk@kernel.org>
To: dongxuyang@eswincomputing.com, ukleinek@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
ben-linux@fluff.org, ben.dooks@codethink.co.uk,
p.zabel@pengutronix.de, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com,
xuxiang@eswincomputing.com, wangguosheng@eswincomputing.com,
pinkesh.vaghela@einfochips.com
Subject: Re: [PATCH v6 1/2] dt-bindings: pwm: dwc: add optional reset
Date: Tue, 28 Apr 2026 10:42:15 +0200 [thread overview]
Message-ID: <ee58a5d6-9268-445c-a270-1f4a49b49c6e@kernel.org> (raw)
In-Reply-To: <20260424095435.1721-1-dongxuyang@eswincomputing.com>
On 24/04/2026 11:54, dongxuyang@eswincomputing.com wrote:
>
> +allOf:
> + - $ref: pwm.yaml#
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: eswin,eic7700-pwm
Same problem as v3 which I commented. I do not understand why your new
device has also 1 reset.
Your commit msg MUST explain why 1 reset is valid.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-28 8:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 9:45 [PATCH v6 0/2] Update designware pwm driver dongxuyang
2026-04-24 9:54 ` [PATCH v6 1/2] dt-bindings: pwm: dwc: add optional reset dongxuyang
2026-04-24 17:03 ` Conor Dooley
2026-04-28 8:42 ` Krzysztof Kozlowski [this message]
2026-04-28 9:30 ` Xuyang Dong
2026-04-28 9:34 ` Krzysztof Kozlowski
2026-04-29 9:30 ` Xuyang Dong
2026-04-24 9:57 ` [PATCH v6 2/2] pwm: dwc: add of/platform support dongxuyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee58a5d6-9268-445c-a270-1f4a49b49c6e@kernel.org \
--to=krzk@kernel.org \
--cc=ben-linux@fluff.org \
--cc=ben.dooks@codethink.co.uk \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pinkesh.vaghela@einfochips.com \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
--cc=wangguosheng@eswincomputing.com \
--cc=xuxiang@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox