public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Crystal Guo (郭晶)" <Crystal.Guo@mediatek.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface
Date: Wed, 9 Apr 2025 09:33:39 +0200	[thread overview]
Message-ID: <f26c71f4-3a17-4335-943c-90e3671c9266@kernel.org> (raw)
In-Reply-To: <bf1f44c34097d090894303cf6e3a9f017f4d5b38.camel@mediatek.com>

On 09/04/2025 09:16, Crystal Guo (郭晶) wrote:
> On Sun, 2025-04-06 at 14:35 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On Thu, Apr 03, 2025 at 02:48:47PM GMT, Crystal Guo wrote:
>>> +maintainers:
>>> +  - Crystal Guo <crystal.guo@mediatek.com>
>>> +
>>> +description:
>>> +  A MediaTek DRAM controller interface to provide the current data
>>> rate of DRAM.
>>
>> DRAM controller does not offer scaling? Or PHY/timing configuration?
>> This binding looks pretty incomplete.
>>
> 
> The PHY/timing configuration is completed during the bootloader stage.
> In the kernel, we currently only need to provide an interface to
> retrieve the current DDR data rate.
Not really, that's what you currently want to do in kernel, but not what
you for example will want next days. Binding is supposed to be complete,
so if you do not have any scaling/interconnect then extend the
description of hardware and explain that memory controller is non
configurable, cannot scale and it exposes only read interface. Or
something similar.

Best regards,
Krzysztof

  reply	other threads:[~2025-04-09  7:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03  6:48 [PATCH v4 0/2] Add an interface to get current DDR data rate Crystal Guo
2025-04-03  6:48 ` [PATCH v4 1/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface Crystal Guo
2025-04-03 10:14   ` AngeloGioacchino Del Regno
2025-04-06 12:35   ` Krzysztof Kozlowski
2025-04-09  7:16     ` Crystal Guo (郭晶)
2025-04-09  7:33       ` Krzysztof Kozlowski [this message]
2025-04-09  8:03         ` Crystal Guo (郭晶)
2025-04-03  6:48 ` [PATCH v4 2/2] memory/mediatek: Add an interface to get current DDR data rate Crystal Guo
2025-04-03 10:14   ` AngeloGioacchino Del Regno
2025-04-04 11:11   ` Krzysztof Kozlowski
2025-04-09  7:42     ` Crystal Guo (郭晶)
2025-05-12  7:36       ` Crystal Guo (郭晶)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f26c71f4-3a17-4335-943c-90e3671c9266@kernel.org \
    --to=krzk@kernel.org \
    --cc=Crystal.Guo@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox