* Re: [PATCH] ARM: dts: am33x, da816x, da814x: Remove useless register address
From: Tony Lindgren @ 2017-01-17 16:28 UTC (permalink / raw)
To: Alexandre Bailon
Cc: nsekhar-l0cyMroinI0, khilman-rdvid1DuHRBWk0Htik3J/w,
vinod.koul-ral2JQCrhuEAvxtiuMwx3w,
dmaengine-u79uwXL29TY76Z2rM5mHXA, ptitiano-rdvid1DuHRBWk0Htik3J/w,
linux-omap-u79uwXL29TY76Z2rM5mHXA, b-liu-l0cyMroinI0,
sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, devicetree-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <08fc8b99-e6c4-7282-8023-b0d37956428c-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
* Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> [170117 08:17]:
> On 01/17/2017 04:47 PM, Tony Lindgren wrote:
> > * Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> [170117 05:55]:
> >> In order to make CPPI 4.1 DMA driver more generic, accesses to USBSS
> >> have been removed. So it is not required anymore to define "glue"
> >> register's address and size in DT.
> >> Remove "glue" register from cppi41dma node.
> >
> > Is this OK to queue later on after all the dependencies have been
> > merged?
> It should be queued on same time as "[PATCH v2 3/7] dmaengine: cppi41:
> Remove usbss_mem", so yes I guess it is OK.
Sounds like it will break things then.. Please read about "flag day"
changes and why they are not accepted.
You should make the driver work with the old and new binding, then
we can just drop the old binding later on from the dts files.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v2 01/10] ASoC: sun4i-i2s: Increase DMA max burst to 8
From: Maxime Ripard @ 2017-01-17 16:41 UTC (permalink / raw)
To: Mylène Josserand
Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, broonie-DgEjT+Ai2ygdnm+yROfE0A,
perex-/Fr2/VpizcU, tiwai-IBi9RG/b67k, wens-jdAy2FN1RRM,
mturquette-rdvid1DuHRBWk0Htik3J/w, sboyd-sgV2jX0FEOL9JmXXK+q4OQ,
mark.rutland-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-clk-u79uwXL29TY76Z2rM5mHXA,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
In-Reply-To: <20170117140230.23142-2-mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
On Tue, Jan 17, 2017 at 03:02:21PM +0100, Mylène Josserand wrote:
> As done previously for sun4i-codec, the DMA maxburst of 4
> is not supported by every SoCs so the DMA controller engine
> returns "unsupported value".
>
> As a maxburst of 8 is supported by all variants, this patch
> increases it to 8.
>
> For more details, see commit from Chen-Yu Tsai:
> commit 730e2dd0cbc7 ("ASoC: sun4i-codec: Increase DMA max burst to 8")
Those details could have been included directly in the commit log.
Otherwise,
Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: [PATCH v2 02/10] clk: ccu-sun8i-a33: Add CLK_SET_RATE_PARENT to ac-dig
From: Maxime Ripard @ 2017-01-17 16:44 UTC (permalink / raw)
To: Mylène Josserand
Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, broonie-DgEjT+Ai2ygdnm+yROfE0A,
perex-/Fr2/VpizcU, tiwai-IBi9RG/b67k, wens-jdAy2FN1RRM,
mturquette-rdvid1DuHRBWk0Htik3J/w, sboyd-sgV2jX0FEOL9JmXXK+q4OQ,
mark.rutland-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-clk-u79uwXL29TY76Z2rM5mHXA,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
In-Reply-To: <20170117140230.23142-3-mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
Hi,
On Tue, Jan 17, 2017 at 03:02:22PM +0100, Mylène Josserand wrote:
> The audio DAI needs to set the clock rates of the ac-dig clock.
> To make it possible, the parent PLL audio clock rates should
> also be changed. This is possible via "CLK_SET_RATE_PARENT" flag.
>
> Signed-off-by: Mylène Josserand <mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Please make sure to look at the prefixes usually used in the commit
titles of the area you're working on. In this case that would have
been "clk: sunxi-ng:". I fixed it, and applied.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: [PATCH v2 03/10] dt-bindings: sound: Add new reset compatible for sun4i-i2s
From: Maxime Ripard @ 2017-01-17 16:46 UTC (permalink / raw)
To: Mylène Josserand
Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, broonie-DgEjT+Ai2ygdnm+yROfE0A,
perex-/Fr2/VpizcU, tiwai-IBi9RG/b67k, wens-jdAy2FN1RRM,
mturquette-rdvid1DuHRBWk0Htik3J/w, sboyd-sgV2jX0FEOL9JmXXK+q4OQ,
mark.rutland-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-clk-u79uwXL29TY76Z2rM5mHXA,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
In-Reply-To: <20170117140230.23142-4-mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 3177 bytes --]
On Tue, Jan 17, 2017 at 03:02:23PM +0100, Mylène Josserand wrote:
> Add a new compatible for sun4i-i2s driver to handle some
> SoCs that have a reset line that must be asserted/deasserted.
>
> This new compatible, "allwinner,sun6i-a31-i2s", requires two
> properties:
> - resets: phandle to the reset line
> - reset-names: the name of the reset line ("rst").
> Except these differences, the compatible is identical to previous one
> which will not handle a reset line.
>
> Signed-off-by: Mylène Josserand <mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> .../devicetree/bindings/sound/sun4i-i2s.txt | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt
> index 7a2c0945fd22..f673206e309b 100644
> --- a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt
> +++ b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt
> @@ -7,6 +7,7 @@ Required properties:
>
> - compatible: should be one of the following:
> - "allwinner,sun4i-a10-i2s"
> + - "allwinner,sun6i-a31-i2s" for controller with reset lines
That's not only for controllers with reset lines, but for the
controllers found in the A31 (and later). I'd simply drop the last
part of that line.
> - reg: physical base address of the controller and length of memory mapped
> region.
> - interrupts: should contain the I2S interrupt.
> @@ -19,7 +20,13 @@ Required properties:
> - "mod" : module clock for the I2S controller
> - #sound-dai-cells : Must be equal to 0
>
> +Required properties for the following compatibles:
> + - "allwinner,sun6i-a31-i2s"
> +- resets: phandle to the reset line for this codec
> +- reset-names: Contains the reset signal name "rst"
You don't need reset-names if there's a single reset line.
> +
> Example:
> +For "allwinner,sun4i-a10-i2s":
>
> i2s0: i2s@01c22400 {
> #sound-dai-cells = <0>;
> @@ -32,3 +39,19 @@ i2s0: i2s@01c22400 {
> <&dma SUN4I_DMA_NORMAL 3>;
> dma-names = "rx", "tx";
> };
> +
> +For "allwinner,sun6i-a31-i2s":
> +
> +dai: dai@01c22c00 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun6i-a31-i2s";
> + reg = <0x01c22c00 0x200>;
> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_CODEC>, <&ccu CLK_AC_DIG>;
> + clock-names = "apb", "mod";
> + resets = <&ccu RST_BUS_CODEC>;
> + reset-names = "rst";
> + dmas = <&dma 15>, /* AUDIO_CODEC port */
> + <&dma 15>; /* AUDIO_CODEC port */
> + dma-names = "rx", "tx";
> +};
And we already have an example, so there's no need to add a new one
either.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: [PATCH v2 04/10] ASoC: sun4i-i2s: Add quirks to handle new compatible for reset
From: Maxime Ripard @ 2017-01-17 16:47 UTC (permalink / raw)
To: Mylène Josserand
Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, broonie-DgEjT+Ai2ygdnm+yROfE0A,
perex-/Fr2/VpizcU, tiwai-IBi9RG/b67k, wens-jdAy2FN1RRM,
mturquette-rdvid1DuHRBWk0Htik3J/w, sboyd-sgV2jX0FEOL9JmXXK+q4OQ,
mark.rutland-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-clk-u79uwXL29TY76Z2rM5mHXA,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
In-Reply-To: <20170117140230.23142-5-mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On Tue, Jan 17, 2017 at 03:02:24PM +0100, Mylène Josserand wrote:
> Some SoCs have a reset line that must be asserted/deasserted.
> This patch adds a quirk to handle the new compatible
> "allwinner,sun6i-a31-i2s" which will deassert the reset
> line on probe function and assert it on remove's one.
>
> This new compatible is useful in case of A33 codec driver, for example.
>
> Signed-off-by: Mylène Josserand <mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: [PATCH v2 06/10] ASoC: sun8i-codec-analog: Add amplifier event to fix first delay
From: Maxime Ripard @ 2017-01-17 16:49 UTC (permalink / raw)
To: Mylène Josserand
Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, broonie-DgEjT+Ai2ygdnm+yROfE0A,
perex-/Fr2/VpizcU, tiwai-IBi9RG/b67k, wens-jdAy2FN1RRM,
mturquette-rdvid1DuHRBWk0Htik3J/w, sboyd-sgV2jX0FEOL9JmXXK+q4OQ,
mark.rutland-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-clk-u79uwXL29TY76Z2rM5mHXA,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
In-Reply-To: <20170117140230.23142-7-mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]
On Tue, Jan 17, 2017 at 03:02:26PM +0100, Mylène Josserand wrote:
> When playing a sound for the first time, a short delay, where the audio
> file is not played, can be noticed.
> On a second play (right after), the sound is played correctly.
> If we wait a short time (~5 sec which corresponds to the aplay
> timeout), the delay is back.
>
> This patch fixes it by using an event on headphone amplifier.
> It allows to keep the amplifier enable while playing a sound.
> A delay of 700ms allows to wait that the amplifier is powered-up
> before playing the sound.
>
> Signed-off-by: Mylène Josserand <mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: [PATCH v2 07/10] dt-bindings: sound: Add sun8i audio documentation
From: Mark Brown @ 2017-01-17 16:50 UTC (permalink / raw)
To: Mylène Josserand
Cc: lgirdwood, perex, tiwai, maxime.ripard, wens, mturquette, sboyd,
mark.rutland, robh+dt, linux-kernel, linux-arm-kernel, linux-clk,
alsa-devel, devicetree, linux-sunxi, thomas.petazzoni,
alexandre.belloni
In-Reply-To: <20170117140230.23142-8-mylene.josserand@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
On Tue, Jan 17, 2017 at 03:02:27PM +0100, Mylène Josserand wrote:
> Add the documentation for dt-binding of the digital audio codec driver
> and the audio card driver for Sun8i SoCs.
Please submit patches using subject lines reflecting the style for the
subsystem. This makes it easier for people to identify relevant
patches. Look at what existing commits in the area you're changing are
doing and make sure your subject lines visually resemble what they're
doing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply
* Re: [PATCH v2 0/7] dmaengine: cppi41: Make CPPI 4.1 driver more generic
From: Sergei Shtylyov @ 2017-01-17 16:51 UTC (permalink / raw)
To: Tony Lindgren, Alexandre Bailon
Cc: vinod.koul-ral2JQCrhuEAvxtiuMwx3w, b-liu-l0cyMroinI0,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, dmaengine-u79uwXL29TY76Z2rM5mHXA,
nsekhar-l0cyMroinI0, khilman-rdvid1DuHRBWk0Htik3J/w,
ptitiano-rdvid1DuHRBWk0Htik3J/w,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <28b57293-4395-4281-0c64-19f299e6eaf6-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
On 01/17/2017 07:05 PM, Sergei Shtylyov wrote:
>>> Most of the patch of this series were part of
>>> "[PATCH 00/11] dmaengine: cppi41: Add dma support to da8xx"
>>>
>>> This series intend to make the CPPI 4.1 more generic in order to
>>> add a new platform (the DA8xx).
>>> To achieve that, all the IRQ code present in CPPI 4.1 driver has been moved
>>> to MUSB DSPS driver.
>>> Other changes mainly update the glue layer and platform code to make the
>>> whole driver more generic.
>>
>> So does da8xx use CPPI 4.1 DMA for other devices also in addition to
>> musb?
>
> No. DA8xx CPPI 4.1 is implemented as a part of the MUSB peripheral.
> But there were a SoC (support for which never got merged upstream) where CPPI
> 4.1 DMA is not limited to USB.
FWIW, the SoC was called TI Puma5, the support for it was filed by TI into
arch/arm/mach-avalanche/...
>> Regards,
>>
>> Tony
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v2 07/10] dt-bindings: sound: Add sun8i audio documentation
From: Maxime Ripard @ 2017-01-17 16:51 UTC (permalink / raw)
To: Mylène Josserand
Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, broonie-DgEjT+Ai2ygdnm+yROfE0A,
perex-/Fr2/VpizcU, tiwai-IBi9RG/b67k, wens-jdAy2FN1RRM,
mturquette-rdvid1DuHRBWk0Htik3J/w, sboyd-sgV2jX0FEOL9JmXXK+q4OQ,
mark.rutland-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-clk-u79uwXL29TY76Z2rM5mHXA,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
In-Reply-To: <20170117140230.23142-8-mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 4373 bytes --]
Hi,
On Tue, Jan 17, 2017 at 03:02:27PM +0100, Mylène Josserand wrote:
> Add the documentation for dt-binding of the digital audio codec driver
> and the audio card driver for Sun8i SoCs.
>
> Signed-off-by: Mylène Josserand <mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
One small comment below,
> ---
> .../devicetree/bindings/sound/sun8i-codec.txt | 76 ++++++++++++++++++++++
> 1 file changed, 76 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/sun8i-codec.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/sun8i-codec.txt b/Documentation/devicetree/bindings/sound/sun8i-codec.txt
> new file mode 100644
> index 000000000000..ce3c05219e33
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/sun8i-codec.txt
> @@ -0,0 +1,76 @@
> +Allwinner SUN8I audio codec
> +------------------------------------
> +
> +On Sun8i SoCs, and particularly on A33, the audio is separated in
Technically that's not true on all the SoCs of the sun8i family, but
only a few of them (A33 and H3 iirc).
This driver is only made for the A33 at the moment, so you should only
mention it (and you should rename that file as well).
Once done,
Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks,
Maxime
> +different parts:
> + - A DAI driver. It uses the "sun4i-i2s" driver which is
> + documented here:
> + Documentation/devicetree/bindings/sound/sun4i-i2s.txt
> + - An analog part of the codec which is handled as PRCM registers.
> + See Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt
> + - An digital part of the codec which is documented in this current
> + binding documentation.
> + - And finally, an audio card which links all the above components.
> + The simple-audio card will be used.
> + See Documentation/devicetree/bindings/sound/simple-card.txt
> +
> +This bindings documentation exposes Sun8i codec (digital part).
> +
> +Required properties:
> +- compatible: must be "allwinner,sun8i-a33-codec"
> +- reg: must contain the registers location and length
> +- interrupts: must contain the codec interrupt
> +- clocks: a list of phandle + clock-specifer pairs, one for each entry
> + in clock-names.
> +- clock-names: should contain followings:
> + - "bus": the parent APB clock for this controller
> + - "mod": the parent module clock
> +
> +Example:
> +codec: codec@01c22e00 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun8i-a33-codec";
> + reg = <0x01c22e00 0x400>;
> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_CODEC>, <&ccu CLK_AC_DIG>;
> + clock-names = "bus", "mod";
> + status = "disabled";
> +};
> +
> +Here is an example to add a sound card and the codec binding on sun8i SoCs that
> +are similar to A33 using simple-card:
> +
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,name = "Sun8i Audio Card";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,frame-master = <&link_codec>;
> + simple-audio-card,bitclock-master = <&link_codec>;
> + simple-audio-card,mclk-fs = <512>;
> + simple-audio-card,aux-devs = <&codec_analog>;
> + simple-audio-card,routing =
> + "Left DAC", "Digital Left DAC",
> + "Right DAC", "Digital Right DAC";
> +
> + simple-audio-card,cpu {
> + sound-dai = <&dai>;
> + };
> +
> + link_codec: simple-audio-card,codec {
> + sound-dai = <&codec>;
> + };
> +
> + soc@01c00000 {
> + [...]
> +
> + codec: codec@01c22e00 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun8i-a33-codec";
> + reg = <0x01c22e00 0x400>;
> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_CODEC>, <&ccu CLK_AC_DIG>;
> + clock-names = "bus", "mod";
> + status = "disabled";
> + };
> + };
> +
> --
> 2.11.0
>
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: [PATCH v2 1/4] arm: sunxi: add support for V3s SoC
From: Icenowy Zheng @ 2017-01-17 16:52 UTC (permalink / raw)
To: Maxime Ripard
Cc: Jonathan Corbet, Chen-Yu Tsai, Rob Herring, Zepan,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
In-Reply-To: <20170117090549.uqwsiwmclzhx7456@lukather>
17.01.2017, 17:06, "Maxime Ripard" <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>:
> On Tue, Jan 17, 2017 at 02:01:13AM +0800, Icenowy Zheng wrote:
>> Allwinner V3s is a low-end single-core Cortex-A7 SoC, with 64MB
>> integrated DRAM, and several peripherals.
>>
>> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
>> ---
>> Changes in v2:
>> - Used linux-sunxi.org wiki hosted address of V3s datasheet.
>>
>> Note: the V3s datasheet contains its user manual.
>
> That would be great to use User Manual in the filename rather than
> datasheet then. The datasheet is something different.
Allwinner named it datasheet.
For previous SoCs, datasheet will contain info about pins, and user manual
about registers.
But for H3 and V3s, datasheet now contains both pins' info and registers' info.
>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply
* Re: [PATCH] clk: meson-gxbb: Export HDMI clocks
From: Kevin Hilman @ 2017-01-17 16:54 UTC (permalink / raw)
To: Neil Armstrong
Cc: devicetree, mturquette, sboyd, linux-kernel, carlo, linux-amlogic,
linux-clk, linux-arm-kernel
In-Reply-To: <1484654928-5640-1-git-send-email-narmstrong@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> Export HDMI clock from internal to dt-bindings.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
> drivers/clk/meson/gxbb.h | 4 ++--
> include/dt-bindings/clock/gxbb-clkc.h | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/meson/gxbb.h b/drivers/clk/meson/gxbb.h
> index 0252939..2139e97 100644
> --- a/drivers/clk/meson/gxbb.h
> +++ b/drivers/clk/meson/gxbb.h
> @@ -231,7 +231,7 @@
> #define CLKID_AHB_DATA_BUS 60
> #define CLKID_AHB_CTRL_BUS 61
> #define CLKID_HDMI_INTR_SYNC 62
> -#define CLKID_HDMI_PCLK 63
> +/* CLKID_HDMI_PCLK */
> /* CLKID_USB1_DDR_BRIDGE */
> /* CLKID_USB0_DDR_BRIDGE */
> #define CLKID_MMC_PCLK 66
> @@ -245,7 +245,7 @@
> #define CLKID_VCLK2_VENCI1 74
> #define CLKID_VCLK2_VENCP0 75
> #define CLKID_VCLK2_VENCP1 76
> -#define CLKID_GCLK_VENCI_INT0 77
> +/* CLKID_GCLK_VENCI_INT0 */
> #define CLKID_GCLK_VENCI_INT 78
> #define CLKID_DAC_CLK 79
> #define CLKID_AOCLK_GATE 80
> diff --git a/include/dt-bindings/clock/gxbb-clkc.h b/include/dt-bindings/clock/gxbb-clkc.h
> index baade6f..da1d473 100644
> --- a/include/dt-bindings/clock/gxbb-clkc.h
> +++ b/include/dt-bindings/clock/gxbb-clkc.h
> @@ -18,8 +18,10 @@
> #define CLKID_USB0 50
> #define CLKID_USB1 51
> #define CLKID_USB 55
> +#define CLKID_HDMI_PCLK 63
> #define CLKID_USB1_DDR_BRIDGE 64
> #define CLKID_USB0_DDR_BRIDGE 65
> +#define CLKID_GCLK_VENCI_INT0 77
> #define CLKID_AO_I2C 93
> #define CLKID_SD_EMMC_A 94
> #define CLKID_SD_EMMC_B 95
^ permalink raw reply
* Re: [PATCH 1/4] phy: sun4i-usb: support PHY0 on H3 in MUSB mode
From: Icenowy Zheng @ 2017-01-17 16:57 UTC (permalink / raw)
To: Maxime Ripard
Cc: Rob Herring, Chen-Yu Tsai, Kishon Vijay Abraham I,
Greg Kroah-Hartman, Bin Liu,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
In-Reply-To: <20170117080611.tn7s7ddj2csqr27m@lukather>
17.01.2017, 16:06, "Maxime Ripard" <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>:
> On Tue, Jan 17, 2017 at 03:14:46AM +0800, Icenowy Zheng wrote:
>> The PHY0 on H3 can be wired either to MUSB controller or OHCI/EHCI
>> controller.
>>
>> The original driver wired it to OHCI/EHCI controller; however, as the
>> code to use PHY0 as OHCI/EHCI is missing, it makes the PHY fully
>> unusable.
>>
>> Rename the register (according to its function and the name in BSP
>> driver), and remove the code which wires the PHY0 to OHCI/EHCI, as MUSB
>> can support both peripheral and host mode (although the host mode of
>> MUSB is buggy).
>
> Can you elaborate on that? What's wrong with it?
The configuration is at bit 0 of register 0x20 in PHY.
When the PHY is reseted, it defaults as MUSB mode.
However, the original author of the H3 PHY code seems to be lack of this
knowledge (He named it PHY_UNK_H3), and changed the PHY to HCI mode.
I just removed the code that wires it to HCI mode, thus it will work in MUSB
mode, with my sun8i-h3-musb patch.
>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply
* Re: [PATCH v2 08/10] ARM: dts: sun8i: Add audio codec, dai and card for A33
From: Maxime Ripard @ 2017-01-17 16:58 UTC (permalink / raw)
To: Mylène Josserand
Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, broonie-DgEjT+Ai2ygdnm+yROfE0A,
perex-/Fr2/VpizcU, tiwai-IBi9RG/b67k, wens-jdAy2FN1RRM,
mturquette-rdvid1DuHRBWk0Htik3J/w, sboyd-sgV2jX0FEOL9JmXXK+q4OQ,
mark.rutland-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-clk-u79uwXL29TY76Z2rM5mHXA,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
In-Reply-To: <20170117140230.23142-9-mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2758 bytes --]
Hi,
On Tue, Jan 17, 2017 at 03:02:28PM +0100, Mylène Josserand wrote:
> Add the audio codec, dai and a simple card to be able to use the
> audio stream of the builtin codec on sun8i SoC.
>
> This commit adds also an audio-routing for the sound card node to link
> the analog DAPM widgets (Right/Left DAC) and the digital one's as they
> are created in different drivers.
>
> Signed-off-by: Mylène Josserand <mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> arch/arm/boot/dts/sun8i-a33.dtsi | 47 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi
> index 63d5181ffff8..fe8a4f4760d2 100644
> --- a/arch/arm/boot/dts/sun8i-a33.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a33.dtsi
> @@ -43,6 +43,7 @@
> */
>
> #include "sun8i-a23-a33.dtsi"
> +#include <dt-bindings/dma/sun4i-a10.h>
>
> / {
> cpus {
> @@ -69,6 +70,27 @@
> reg = <0x40000000 0x80000000>;
> };
>
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,name = "Sun8i Audio Card";
You might have several of them if you're using an internal i2s DAI
with a codec too. What about "a33-codec" or something alike?
> + simple-audio-card,format = "i2s";
> + simple-audio-card,frame-master = <&link_codec>;
> + simple-audio-card,bitclock-master = <&link_codec>;
> + simple-audio-card,mclk-fs = <512>;
> + simple-audio-card,aux-devs = <&codec_analog>;
> + simple-audio-card,routing =
> + "Left DAC", "Digital Left DAC",
> + "Right DAC", "Digital Right DAC";
This will be enabled all the time (even if your DAI and codec are
not), which means that the driver will probe and.. do nothing. You
probably want to disable it here.
> +
> + simple-audio-card,cpu {
> + sound-dai = <&dai>;
> + };
> +
> + link_codec: simple-audio-card,codec {
> + sound-dai = <&codec>;
> + };
> + };
> +
> soc@01c00000 {
> tcon0: lcd-controller@01c0c000 {
> compatible = "allwinner,sun8i-a33-tcon";
> @@ -116,6 +138,31 @@
> reset-names = "ahb";
> };
>
> + dai: dai@01c22c00 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun6i-a31-i2s";
> + reg = <0x01c22c00 0x200>;
> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_CODEC>, <&ccu CLK_AC_DIG>;
> + clock-names = "apb", "mod";
> + resets = <&ccu RST_BUS_CODEC>;
> + reset-names = "rst";
> + dmas = <&dma 15>, /* AUDIO_CODEC port */
> + <&dma 15>; /* AUDIO_CODEC port */
There's no need for those comments.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: [PATCH] fbdev: ssd1307fb: allow reset-gpios is missing
From: Icenowy Zheng @ 2017-01-17 16:58 UTC (permalink / raw)
To: Maxime Ripard
Cc: David Airlie, Rob Herring, linux-fbdev, linux-kernel, devicetree
2017年1月17日 15:40于 Maxime Ripard <maxime.ripard@free-electrons.com>写道：
>
> On Mon, Jan 16, 2017 at 05:50:21PM +0800, Icenowy Zheng wrote:
> >
> > 2017年1月16日 16:02于 Maxime Ripard <maxime.ripard@free-electrons.com>写道：
> > >
> > > On Sun, Jan 15, 2017 at 07:21:46PM +0800, Icenowy Zheng wrote:
> > > > Currently some SSD1306 OLED modules are sold without a reset pin (only
> > > > VCC, GND, SCK, SDA four pins).
> > > >
> > > > Add support for missing reset-gpios property.
> > > >
> > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> > >
> > > Unfortunately, a similar patch has been sent a couple of times
> > > already:
> > > https://www.spinics.net/lists/devicetree/msg158330.html
> >
> > Why is it never merged?
>
> It was sent 4 days ago...
>
> And since you didn't have the right maintainers in the cc list, yours
> didn't have a chance to be merged either.
That patch is better.
Ignore mine.
>
> > There are really boards that needs this function.
>
> Then you can accelerate its inclusion by reviewing it.
>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
^ permalink raw reply
* Re: Re: [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU
From: Icenowy Zheng @ 2017-01-17 17:02 UTC (permalink / raw)
To: Maxime Ripard
Cc: Rob Herring, linux-clk-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Zepan,
linux-doc-u79uwXL29TY76Z2rM5mHXA, Jonathan Corbet,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Chen-Yu Tsai
2017年1月17日 17:04于 Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>写道：
>
> Hi,
>
> On Tue, Jan 17, 2017 at 02:01:14AM +0800, Icenowy Zheng wrote:
> > V3s has a similar but cut-down CCU to H3.
> >
> > Add support for it.
> >
> > Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> > ---
>
> Output from checkpatch:
> total: 5 errors, 2 warnings, 3 checks, 857 lines checked
>
> > I think I should make a comparsion between V3s and H3 CCU here:
> > (I won't mention the missing/added clocks here, only list conflicting clocks)
>
> That should be in your commit log.
I think it can be easily get by a diff command :-)
And we do not have the tradition to describe clock difference in commit
log, is it right?
>
> > - "bus-ehci0" is at different bit (The bit that is "bus-ehci0" on V3s is
> > "bus-ehci2" on H3)
> > - The mux of "ce" is different. (According the view at V3s datasheet by the
> > author of sun4i-ss, V3s may have sun4i-ss, not sun8i-ce)
> > - The mux of "de" is different. (V3s do not have "pll-de", but it can mux "de"
> > to "pll-video")
> > - Clocks about CSI largely differs. (As V3s is designed as a camera SoC, and
> > it have an extra "pll-isp")
>
> OK.
>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
> For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply
* Re: [PATCH v2 1/8] ARM: dts: armada-370-rd: Utilize new DSA binding
From: Andrew Lunn @ 2017-01-17 17:03 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Jason Cooper,
Gregory Clement, Sebastian Hesselbarth, Rob Herring, Mark Rutland,
Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, vivien.didelot-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/
In-Reply-To: <20170105192957.14304-2-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Thu, Jan 05, 2017 at 11:29:50AM -0800, Florian Fainelli wrote:
> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net: dsa:
> Document new binding"). The legacy binding node is kept included, but is marked
> disabled.
>
> Signed-off-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Tested-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v2 2/8] ARM: dts: armada-385-linksys: Utilize new DSA binding
From: Andrew Lunn @ 2017-01-17 17:05 UTC (permalink / raw)
To: Florian Fainelli
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Jason Cooper, vivien.didelot, Russell King, open list,
Rob Herring, Gregory Clement, linux-arm-kernel,
Sebastian Hesselbarth
In-Reply-To: <20170105192957.14304-3-f.fainelli@gmail.com>
On Thu, Jan 05, 2017 at 11:29:51AM -0800, Florian Fainelli wrote:
> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net: dsa:
> Document new binding"). The legacy binding node is kept included, but is marked
> disabled.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply
* Re: [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU
From: Icenowy Zheng @ 2017-01-17 17:08 UTC (permalink / raw)
To: Maxime Ripard
Cc: Jonathan Corbet, Chen-Yu Tsai, Rob Herring, Zepan,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
In-Reply-To: <20170117090456.fgw6lpqgurwwcczj@lukather>
17.01.2017, 17:05, "Maxime Ripard" <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>:
> Hi,
>
> On Tue, Jan 17, 2017 at 02:01:14AM +0800, Icenowy Zheng wrote:
>> V3s has a similar but cut-down CCU to H3.
>>
>> Add support for it.
>>
>> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
>> ---
>
> Output from checkpatch:
> total: 5 errors, 2 warnings, 3 checks, 857 lines checked
I remembered some errors' code is directly derived from ccu-sun8i-h3.c,
so I generated a patch file for "clk: sunxi-ng: Add H3 clocks" and run
checkpatch on it:
total: 4 errors, 5 warnings, 1159 lines checked
Should I still get all errors fixed?
>
>> I think I should make a comparsion between V3s and H3 CCU here:
>> (I won't mention the missing/added clocks here, only list conflicting clocks)
>
> That should be in your commit log.
>
>> - "bus-ehci0" is at different bit (The bit that is "bus-ehci0" on V3s is
>> "bus-ehci2" on H3)
>> - The mux of "ce" is different. (According the view at V3s datasheet by the
>> author of sun4i-ss, V3s may have sun4i-ss, not sun8i-ce)
>> - The mux of "de" is different. (V3s do not have "pll-de", but it can mux "de"
>> to "pll-video")
>> - Clocks about CSI largely differs. (As V3s is designed as a camera SoC, and
>> it have an extra "pll-isp")
>
> OK.
>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply
* Re: [PATCH v2 6/7] dmaengine: cppi41: init_sched(): Get number of channels from DT
From: Sergei Shtylyov @ 2017-01-17 17:09 UTC (permalink / raw)
To: Alexandre Bailon, vinod.koul-ral2JQCrhuEAvxtiuMwx3w,
b-liu-l0cyMroinI0, robh+dt-DgEjT+Ai2ygdnm+yROfE0A
Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA, nsekhar-l0cyMroinI0,
khilman-rdvid1DuHRBWk0Htik3J/w, ptitiano-rdvid1DuHRBWk0Htik3J/w,
tony-4v6yS6AI5VpBDgjK7y7TUQ, linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20170117134540.9988-7-abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
On 01/17/2017 04:45 PM, Alexandre Bailon wrote:
> Despite the driver is already using DT to get the number of channels,
> init_sched() is using an hardcoded value to get it.
> Use DT to get the number of channels.
>
> Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> ---
> drivers/dma/cppi41.c | 33 ++++++++++++++++++++-------------
> 1 file changed, 20 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
> index 3b2f57f..303ccee 100644
> --- a/drivers/dma/cppi41.c
> +++ b/drivers/dma/cppi41.c
[...]
> @@ -832,7 +829,7 @@ static int init_descs(struct device *dev, struct cppi41_dd *cdd)
> return 0;
> }
>
> -static void init_sched(struct cppi41_dd *cdd)
> +static int init_sched(struct device *dev, struct cppi41_dd *cdd)
> {
> unsigned ch;
> unsigned word;
[...]
> @@ -850,9 +847,11 @@ static void init_sched(struct cppi41_dd *cdd)
> cppi_writel(reg, cdd->sched_mem + DMA_SCHED_WORD(word));
> word++;
> }
> - reg = 15 * 2 * 2 - 1;
> + reg = cdd->n_chans * 2 - 1;
> reg |= DMA_SCHED_CTRL_EN;
> cppi_writel(reg, cdd->sched_mem + DMA_SCHED_CTRL);
> +
> + return 0;
> }
>
> static int init_cppi41(struct device *dev, struct cppi41_dd *cdd)
> @@ -871,12 +870,14 @@ static int init_cppi41(struct device *dev, struct cppi41_dd *cdd)
>
> ret = init_descs(dev, cdd);
> if (ret)
> - goto err_td;
> + goto deinit;
>
> cppi_writel(cdd->td_queue.submit, cdd->ctrl_mem + DMA_TDFDQ);
> - init_sched(cdd);
> + ret = init_sched(dev, cdd);
> + if (ret)
What's the point if init_sched() always returns 0?
[...]
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v2 03/10] dt-bindings: sound: Add new reset compatible for sun4i-i2s
From: Icenowy Zheng @ 2017-01-17 17:10 UTC (permalink / raw)
To: Mylène Josserand
Cc: mturquette-rdvid1DuHRBWk0Htik3J/w,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, broonie-DgEjT+Ai2ygdnm+yROfE0A,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
perex-/Fr2/VpizcU, sboyd-sgV2jX0FEOL9JmXXK+q4OQ,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8, tiwai-IBi9RG/b67k,
linux-clk-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, mark.rutland-5wv7dgnIgG8,
devicetree-u79uwXL29TY76Z2rM5mHXA,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, wens-jdAy2FN1RRM,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A
2017年1月17日 22:02于 Mylène Josserand <mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>写道：
>
> Add a new compatible for sun4i-i2s driver to handle some
> SoCs that have a reset line that must be asserted/deasserted.
>
> This new compatible, "allwinner,sun6i-a31-i2s", requires two
> properties:
> - resets: phandle to the reset line
> - reset-names: the name of the reset line ("rst").
> Except these differences, the compatible is identical to previous one
> which will not handle a reset line.
But I think the IP block is identical, right?
Should a new compatible be added only for reset-line?
>
> Signed-off-by: Mylène Josserand <mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> .../devicetree/bindings/sound/sun4i-i2s.txt | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt
> index 7a2c0945fd22..f673206e309b 100644
> --- a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt
> +++ b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt
> @@ -7,6 +7,7 @@ Required properties:
>
> - compatible: should be one of the following:
> - "allwinner,sun4i-a10-i2s"
> + - "allwinner,sun6i-a31-i2s" for controller with reset lines
> - reg: physical base address of the controller and length of memory mapped
> region.
> - interrupts: should contain the I2S interrupt.
> @@ -19,7 +20,13 @@ Required properties:
> - "mod" : module clock for the I2S controller
> - #sound-dai-cells : Must be equal to 0
>
> +Required properties for the following compatibles:
> + - "allwinner,sun6i-a31-i2s"
> +- resets: phandle to the reset line for this codec
> +- reset-names: Contains the reset signal name "rst"
> +
> Example:
> +For "allwinner,sun4i-a10-i2s":
>
> i2s0: i2s@01c22400 {
> #sound-dai-cells = <0>;
> @@ -32,3 +39,19 @@ i2s0: i2s@01c22400 {
> <&dma SUN4I_DMA_NORMAL 3>;
> dma-names = "rx", "tx";
> };
> +
> +For "allwinner,sun6i-a31-i2s":
> +
> +dai: dai@01c22c00 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun6i-a31-i2s";
> + reg = <0x01c22c00 0x200>;
> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_CODEC>, <&ccu CLK_AC_DIG>;
> + clock-names = "apb", "mod";
> + resets = <&ccu RST_BUS_CODEC>;
> + reset-names = "rst";
> + dmas = <&dma 15>, /* AUDIO_CODEC port */
> + <&dma 15>; /* AUDIO_CODEC port */
> + dma-names = "rx", "tx";
> +};
> --
> 2.11.0
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply
* Re: [PATCH v2 1/3] dt/bindings: da8xx-usb: Add binding for the CPPI 4.1 DMA controller
From: Sergei Shtylyov @ 2017-01-17 17:14 UTC (permalink / raw)
To: Alexandre Bailon, vinod.koul-ral2JQCrhuEAvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A
Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA, nsekhar-l0cyMroinI0,
khilman-rdvid1DuHRBWk0Htik3J/w, ptitiano-rdvid1DuHRBWk0Htik3J/w,
tony-4v6yS6AI5VpBDgjK7y7TUQ, linux-omap-u79uwXL29TY76Z2rM5mHXA,
b-liu-l0cyMroinI0, devicetree-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20170117142016.11163-2-abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
On 01/17/2017 05:20 PM, Alexandre Bailon wrote:
> DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx cppi41 dma controller.
"CPPI 4.1 DMA" again.
>
> Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> ---
> .../devicetree/bindings/usb/da8xx-usb.txt | 42 ++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> index ccb844a..aed3169 100644
> --- a/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> @@ -18,10 +18,26 @@ Required properties:
>
> - phy-names: Should be "usb-phy"
>
> + - dmas: specifies the dma channels
> +
> + - dma-names: specifies the names of the channels. Use "rxN" for receive
> + and "txN" for transmit endpoints. N specifies the endpoint number.
> +
> Optional properties:
> ~~~~~~~~~~~~~~~~~~~~
> - vbus-supply: Phandle to a regulator providing the USB bus power.
>
> +DMA
> +~~~
> +- compatible: ti,da8xx-cppi41
> +- reg: offset and length of the following register spaces: CPPI DMA Controller,
> + CPPI DMA Scheduler, Queue Manager
> +- reg-names: "controller", "scheduler", "queuemgr"
> +- #dma-cells: should be set to 2. The first number represents the
> + channel number (0 … 3 for endpoints 1 … 4).
> + The second number is 0 for RX and 1 for TX transfers.
> +- #dma-channels: should be set to 4 representing the 4 endpoints.
Shouldn't the # of channels be a part of the glue data?
[...]
> @@ -39,5 +58,28 @@ Example:
> phys = <&usb_phy 0>;
> phy-names = "usb-phy";
>
> + dmas = <&cppi41dma 0 0 &cppi41dma 1 0
> + &cppi41dma 2 0 &cppi41dma 3 0
> + &cppi41dma 0 1 &cppi41dma 1 1
> + &cppi41dma 2 1 &cppi41dma 3 1>;
> + dma-names =
> + "rx1", "rx2", "rx3", "rx4",
> + "tx1", "tx2", "tx3", "tx4";
> +
> status = "okay";
> +
> + cppi41dma: dma-controller@201000 {
> + compatible = "ti,da8xx-cppi41";
> + reg = <0x201000 0x1000
> + 0x202000 0x1000
> + 0x204000 0x4000>;
> + reg-names = "controller", "scheduler", "queuemgr";
> + interrupts = <58>;
> + interrupt-names = "glue";
> + #dma-cells = <2>;
> + #dma-channels = <4>;
> + #dma-requests = <256>;
Not seeing this prop documented...
> + status = "okay";
Can be omitted.
> + };
> +
> };
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v2 07/10] dt-bindings: sound: Add sun8i audio documentation
From: Icenowy Zheng @ 2017-01-17 17:14 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mylène Josserand, mturquette-rdvid1DuHRBWk0Htik3J/w,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, broonie-DgEjT+Ai2ygdnm+yROfE0A,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
perex-/Fr2/VpizcU, sboyd-sgV2jX0FEOL9JmXXK+q4OQ,
tiwai-IBi9RG/b67k, linux-clk-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, mark.rutland-5wv7dgnIgG8,
devicetree-u79uwXL29TY76Z2rM5mHXA,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
wens-jdAy2FN1RRM, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A
2017年1月18日 00:51于 Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>写道：
>
> Hi,
>
> On Tue, Jan 17, 2017 at 03:02:27PM +0100, Mylène Josserand wrote:
> > Add the documentation for dt-binding of the digital audio codec driver
> > and the audio card driver for Sun8i SoCs.
> >
> > Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com>
>
> One small comment below,
>
> > ---
> > .../devicetree/bindings/sound/sun8i-codec.txt | 76 ++++++++++++++++++++++
> > 1 file changed, 76 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/sun8i-codec.txt
> >
> > diff --git a/Documentation/devicetree/bindings/sound/sun8i-codec.txt b/Documentation/devicetree/bindings/sound/sun8i-codec.txt
> > new file mode 100644
> > index 000000000000..ce3c05219e33
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/sun8i-codec.txt
> > @@ -0,0 +1,76 @@
> > +Allwinner SUN8I audio codec
> > +------------------------------------
> > +
> > +On Sun8i SoCs, and particularly on A33, the audio is separated in
>
> Technically that's not true on all the SoCs of the sun8i family, but
> only a few of them (A33 and H3 iirc).
H3 is still the old-style sunxi codec.
I think A64 has the same digital codec part (but A64's analog part is different)
>
> This driver is only made for the A33 at the moment, so you should only
> mention it (and you should rename that file as well).
>
> Once done,
> Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>
> Thanks,
> Maxime
>
>
> > +different parts:
> > + - A DAI driver. It uses the "sun4i-i2s" driver which is
> > + documented here:
> > + Documentation/devicetree/bindings/sound/sun4i-i2s.txt
> > + - An analog part of the codec which is handled as PRCM registers.
> > + See Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt
> > + - An digital part of the codec which is documented in this current
> > + binding documentation.
> > + - And finally, an audio card which links all the above components.
> > + The simple-audio card will be used.
> > + See Documentation/devicetree/bindings/sound/simple-card.txt
> > +
> > +This bindings documentation exposes Sun8i codec (digital part).
> > +
> > +Required properties:
> > +- compatible: must be "allwinner,sun8i-a33-codec"
> > +- reg: must contain the registers location and length
> > +- interrupts: must contain the codec interrupt
> > +- clocks: a list of phandle + clock-specifer pairs, one for each entry
> > + in clock-names.
> > +- clock-names: should contain followings:
> > + - "bus": the parent APB clock for this controller
> > + - "mod": the parent module clock
> > +
> > +Example:
> > +codec: codec@01c22e00 {
> > + #sound-dai-cells = <0>;
> > + compatible = "allwinner,sun8i-a33-codec";
> > + reg = <0x01c22e00 0x400>;
> > + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&ccu CLK_BUS_CODEC>, <&ccu CLK_AC_DIG>;
> > + clock-names = "bus", "mod";
> > + status = "disabled";
> > +};
> > +
> > +Here is an example to add a sound card and the codec binding on sun8i SoCs that
> > +are similar to A33 using simple-card:
> > +
> > + sound {
> > + compatible = "simple-audio-card";
> > + simple-audio-card,name = "Sun8i Audio Card";
> > + simple-audio-card,format = "i2s";
> > + simple-audio-card,frame-master = <&link_codec>;
> > + simple-audio-card,bitclock-master = <&link_codec>;
> > + simple-audio-card,mclk-fs = <512>;
> > + simple-audio-card,aux-devs = <&codec_analog>;
> > + simple-audio-card,routing =
> > + "Left DAC", "Digital Left DAC",
> > + "Right DAC", "Digital Right DAC";
> > +
> > + simple-audio-card,cpu {
> > + sound-dai = <&dai>;
> > + };
> > +
> > + link_codec: simple-audio-card,codec {
> > + sound-dai = <&codec>;
> > + };
> > +
> > + soc@01c00000 {
> > + [...]
> > +
> > + codec: codec@01c22e00 {
> > + #sound-dai-cells = <0>;
> > + compatible = "allwinner,sun8i-a33-codec";
> > + reg = <0x01c22e00 0x400>;
> > + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&ccu CLK_BUS_CODEC>, <&ccu CLK_AC_DIG>;
> > + clock-names = "bus", "mod";
> > + status = "disabled";
> > + };
> > + };
> > +
> > --
> > 2.11.0
> >
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply
* Re: [PATCH v2 1/3] dt/bindings: da8xx-usb: Add binding for the CPPI 4.1 DMA controller
From: Sergei Shtylyov @ 2017-01-17 17:16 UTC (permalink / raw)
To: Alexandre Bailon, vinod.koul-ral2JQCrhuEAvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A
Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA, nsekhar-l0cyMroinI0,
khilman-rdvid1DuHRBWk0Htik3J/w, ptitiano-rdvid1DuHRBWk0Htik3J/w,
tony-4v6yS6AI5VpBDgjK7y7TUQ, linux-omap-u79uwXL29TY76Z2rM5mHXA,
b-liu-l0cyMroinI0, devicetree-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20170117142016.11163-2-abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
On 01/17/2017 05:20 PM, Alexandre Bailon wrote:
> DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx cppi41 dma controller.
>
> Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> ---
> .../devicetree/bindings/usb/da8xx-usb.txt | 42 ++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> index ccb844a..aed3169 100644
> --- a/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> @@ -18,10 +18,26 @@ Required properties:
>
> - phy-names: Should be "usb-phy"
>
> + - dmas: specifies the dma channels
> +
> + - dma-names: specifies the names of the channels. Use "rxN" for receive
> + and "txN" for transmit endpoints. N specifies the endpoint number.
> +
> Optional properties:
> ~~~~~~~~~~~~~~~~~~~~
> - vbus-supply: Phandle to a regulator providing the USB bus power.
>
> +DMA
> +~~~
> +- compatible: ti,da8xx-cppi41
Almost missed this -- wildcards in this property are forbidden.
We should use "ti,da830-cppi41" as a least common denominator.
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v2 1/7] usb: musb: dsps: Manage CPPI 4.1 DMA interrupt in dsps
From: kbuild test robot @ 2017-01-17 17:20 UTC (permalink / raw)
Cc: kbuild-all-JC7UmRfGjtg, vinod.koul-ral2JQCrhuEAvxtiuMwx3w,
b-liu-l0cyMroinI0, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
dmaengine-u79uwXL29TY76Z2rM5mHXA, nsekhar-l0cyMroinI0,
khilman-rdvid1DuHRBWk0Htik3J/w, ptitiano-rdvid1DuHRBWk0Htik3J/w,
tony-4v6yS6AI5VpBDgjK7y7TUQ, linux-omap-u79uwXL29TY76Z2rM5mHXA,
sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8,
devicetree-u79uwXL29TY76Z2rM5mHXA, Alexandre Bailon
In-Reply-To: <20170117134540.9988-2-abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 3392 bytes --]
Hi Alexandre,
[auto build test ERROR on linus/master]
[also build test ERROR on v4.10-rc4 next-20170117]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Alexandre-Bailon/dmaengine-cppi41-Make-CPPI-4-1-driver-more-generic/20170118-002219
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa
All error/warnings (new ones prefixed by >>):
drivers/usb/musb/musb_dsps.c: In function 'dsps_dma_controller_create':
>> drivers/usb/musb/musb_dsps.c:642:3: error: implicit declaration of function 'cppi41_register_dma_callback' [-Werror=implicit-function-declaration]
cppi41_register_dma_callback(controller,
^
drivers/usb/musb/musb_dsps.c: In function 'dsps_dma_controller_destroy':
>> drivers/usb/musb/musb_dsps.c:651:9: error: implicit declaration of function 'cppi41_dma_controller_to_musb' [-Werror=implicit-function-declaration]
struct musb *musb = cppi41_dma_controller_to_musb(c);
^
>> drivers/usb/musb/musb_dsps.c:651:22: warning: initialization makes pointer from integer without a cast
struct musb *musb = cppi41_dma_controller_to_musb(c);
^
drivers/usb/musb/musb_dsps.c: At top level:
drivers/usb/musb/musb_dsps.c:633:1: warning: 'dsps_dma_controller_create' defined but not used [-Wunused-function]
dsps_dma_controller_create(struct musb *musb, void __iomem *base)
^
drivers/usb/musb/musb_dsps.c:649:13: warning: 'dsps_dma_controller_destroy' defined but not used [-Wunused-function]
static void dsps_dma_controller_destroy(struct dma_controller *c)
^
drivers/usb/musb/musb_dsps.c:659:13: warning: 'dsps_dma_controller_suspend' defined but not used [-Wunused-function]
static void dsps_dma_controller_suspend(struct dsps_glue *glue)
^
drivers/usb/musb/musb_dsps.c:666:13: warning: 'dsps_dma_controller_resume' defined but not used [-Wunused-function]
static void dsps_dma_controller_resume(struct dsps_glue *glue)
^
cc1: some warnings being treated as errors
vim +/cppi41_register_dma_callback +642 drivers/usb/musb/musb_dsps.c
636 struct dsps_glue *glue = dev_get_drvdata(musb->controller->parent);
637 void __iomem *usbss_base = glue->usbss_base;
638
639 controller = cppi41_dma_controller_create(musb, base);
640 if (!IS_ERR_OR_NULL(controller)) {
641 musb_writel(usbss_base, USBSS_IRQ_ENABLER, USBSS_IRQ_PD_COMP);
> 642 cppi41_register_dma_callback(controller,
643 dsps_dma_controller_callback);
644 }
645
646 return controller;
647 }
648
649 static void dsps_dma_controller_destroy(struct dma_controller *c)
650 {
> 651 struct musb *musb = cppi41_dma_controller_to_musb(c);
652 struct dsps_glue *glue = dev_get_drvdata(musb->controller->parent);
653 void __iomem *usbss_base = glue->usbss_base;
654
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48156 bytes --]
^ permalink raw reply
* Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2
From: Krzysztof Kozlowski @ 2017-01-17 17:20 UTC (permalink / raw)
To: Jaechul Lee
Cc: Mark Rutland, devicetree, linux-samsung-soc, Andi Shyti,
Chanwoo Choi, Catalin Marinas, Dmitry Torokhov, Will Deacon,
linux-kernel, Rob Herring, Javier Martinez Canillas, Kukjin Kim,
Krzysztof Kozlowski, linux-input, galaxyra, beomho.seo,
linux-arm-kernel
In-Reply-To: <1484632479-3111-3-git-send-email-jcsing.lee@samsung.com>
On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote:
> This patch adds support for the TM2 touch key and led
> functionality.
>
> The driver interfaces with userspace through an input device and
> reports KEY_PHONE and KEY_BACK event types. LED brightness can be
> controlled by "/sys/class/leds/tm2-touchkey/brightness".
>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Reviewed-by: Andi Shyti <andi.shyti@samsung.com>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This looks unusual. How did Dmitry's Sob end here?
Best regards,
Krzysztof
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox