* Re: [PATCH v5 1/2] at24: support eeproms that do not auto-rollover reads.
From: Bartosz Golaszewski @ 2017-12-07 21:33 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Sven Van Asbroeck, Rob Herring, Mark Rutland, Wolfram Sang,
nsekhar, Sakari Ailus, David Lechner, Javier Martinez Canillas,
Divagar Mohandass, devicetree, Linux Kernel Mailing List,
linux-i2c
In-Reply-To: <20171207190230.ttq5xthgsuuy4swn@pengutronix.de>
2017-12-07 20:02 GMT+01:00 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> Hello,
>
> On Thu, Dec 07, 2017 at 05:26:50PM +0100, Bartosz Golaszewski wrote:
>> > + if (at24->chip.flags & AT24_FLAG_NO_RDROL) {
>> > + bits = (at24->chip.flags & AT24_FLAG_ADDR16) ? 16 : 8;
>>
>> There's no need for braces around the ternary operator's condition.
>
> Even if not required, I'd keep them for clearity.
>
I don't want to start bikeshedding, so I'll take it as it is, but I
prefer to avoid braces wherever it's not necessary.
Thanks,
Bartosz
^ permalink raw reply
* Re: [PATCH 2/3] bluetooth: hci_ll: add constant for vendor-specific command
From: Marcel Holtmann @ 2017-12-07 21:43 UTC (permalink / raw)
To: David Lechner
Cc: devicetree, open list:BLUETOOTH DRIVERS, Rob Herring,
Mark Rutland, Gustavo F. Padovan, Johan Hedberg,
Network Development, linux-kernel
In-Reply-To: <55fff19a-c30f-88f0-afb2-6c0b9bad25a7@lechnology.com>
Hi David,
>>> This adds a #define for the vendor-specific HCI command to set the
>>> baudrate instead of using the bare 0xff36 multiple times.
>>>
>>> Signed-off-by: David Lechner <david@lechnology.com>
>>> ---
>>> drivers/bluetooth/hci_ll.c | 10 ++++++++--
>>> 1 file changed, 8 insertions(+), 2 deletions(-)
>> patch has been applied to bluetooth-next tree.
>
> I am new to the bluetooth tree, so just to be sure... does this mean I should not include this patch in v2 of this series since this patch has been applied?
please don’t include already applied patches. Base everything against bluetooth-next tree.
Regards
Marcel
^ permalink raw reply
* Re: [PATCH v2 2/2] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver
From: Philippe Ombredanne @ 2017-12-07 21:47 UTC (permalink / raw)
To: Dhaval Shah
Cc: Arnd Bergmann, Greg Kroah-Hartman, Rob Herring, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
michal.simek-gjFFaj9aHVfQT0dZR+AlfA, hyunk-gjFFaj9aHVfQT0dZR+AlfA,
Dhaval Shah
In-Reply-To: <1512682276-6082-3-git-send-email-dshah-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Dear Dhaval,
On Thu, Dec 7, 2017 at 10:31 PM, Dhaval Shah <dhaval.shah-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org> wrote:
> Xilinx ZYNQMP logicoreIP Init driver is based on the new
> LogiCoreIP design created. This driver provides the processing system
> and programmable logic isolation. Set the frequency based on the clock
> information get from the logicoreIP register set.
>
> It is put in drivers/misc as there is no subsystem for this logicoreIP.
>
> Signed-off-by: Dhaval Shah <dshah-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> ---
> Changes since v2:
> * Removed the "default n" from the Kconfig
> * More help text added to explain more about the logicoreIP driver
> * SPDX id is relocated at top of the file with // style comment
> * Removed the export API and header file and make it a single driver
> which provides logocoreIP init.
> * Provide the information in commit message as well for the why driver
> in drivers/misc.
Thank you for the SPDX comments updates.
Acked-by: Philippe Ombredanne <pombredanne-od1rfyK75/E@public.gmane.org>
--
Cordially
Philippe Ombredanne
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v5 1/2] at24: support eeproms that do not auto-rollover reads.
From: Uwe Kleine-König @ 2017-12-07 21:57 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Sven Van Asbroeck, Rob Herring, Mark Rutland, Wolfram Sang,
nsekhar-l0cyMroinI0, Sakari Ailus, David Lechner,
Javier Martinez Canillas, Divagar Mohandass,
devicetree-u79uwXL29TY76Z2rM5mHXA, Linux Kernel Mailing List,
linux-i2c
In-Reply-To: <CAMRc=MeEnDYjDTpE=XKuP3LricsnEnh0RHKMzxEPUcOS6E0tPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Dec 07, 2017 at 10:33:51PM +0100, Bartosz Golaszewski wrote:
> 2017-12-07 20:02 GMT+01:00 Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>:
> > Hello,
> >
> > On Thu, Dec 07, 2017 at 05:26:50PM +0100, Bartosz Golaszewski wrote:
> >> > + if (at24->chip.flags & AT24_FLAG_NO_RDROL) {
> >> > + bits = (at24->chip.flags & AT24_FLAG_ADDR16) ? 16 : 8;
> >>
> >> There's no need for braces around the ternary operator's condition.
> >
> > Even if not required, I'd keep them for clearity.
> >
>
> I don't want to start bikeshedding, so I'll take it as it is, but I
> prefer to avoid braces wherever it's not necessary.
For me the reasoning is: Most people (me included) don't know off-hand
if the semantic of
a & b ? c : d
is
(a & b) ? c : d
or
a & (b ? c : d)
In some situations (e.g. a & b == c) gcc even warns when you don't add
syntactically needless parentheses. The case under discussion isn't such
an example though.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH V6 3/7] device property: Introduce a common API to fetch device match data
From: Sakari Ailus @ 2017-12-07 22:06 UTC (permalink / raw)
To: Sinan Kaya
Cc: dmaengine, timur, devicetree, linux-acpi, linux-arm-msm,
linux-arm-kernel, Greg Kroah-Hartman, Rafael J. Wysocki,
Len Brown, Mika Westerberg, Sakari Ailus, Dmitry Torokhov,
Rob Herring, Kieran Bingham, open list
In-Reply-To: <c2b38889-888a-3518-bf59-c2377f64a8ce@codeaurora.org>
On Thu, Dec 07, 2017 at 03:17:52PM -0500, Sinan Kaya wrote:
> On 12/7/2017 7:40 AM, Sakari Ailus wrote:
> > On Tue, Dec 05, 2017 at 12:04:48PM -0500, Sinan Kaya wrote:
> >> @@ -101,6 +103,8 @@ struct fwnode_operations {
> >> (*graph_get_port_parent)(struct fwnode_handle *fwnode);
> >> int (*graph_parse_endpoint)(const struct fwnode_handle *fwnode,
> >> struct fwnode_endpoint *endpoint);
> >> + void *(*get_match_data)(const struct fwnode_handle *fwnode,
> >> + struct device *dev);
> >
> > You can make dev const, too.
> >
>
> done, I couldn't change device_get_match_data() parameter const due to
> dev_fwnode() function.
>
> from /local/mnt/workspace/projects/caf/kernel/drivers/base/property.c:13:
>
> /local/mnt/workspace/projects/caf/kernel/drivers/base/property.c:1341:39: warning: passing argument 1 of 'dev_fwnode' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> return fwnode_call_ptr_op(dev_fwnode(dev), device_get_match_data,
Right. Makes sense.
I guess it's not perhaps worth it introducing dev_fwnode_const just for
this. devices are seldom if ever const anyway.
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi
^ permalink raw reply
* Re: [PATCH v5 2/4] clk: meson-axg: add clocks dt-bindings required header
From: Rob Herring @ 2017-12-07 22:10 UTC (permalink / raw)
To: Yixun Lan
Cc: Neil Armstrong, Jerome Brunet, Kevin Hilman, Mark Rutland,
Michael Turquette, Stephen Boyd, Carlo Caione, Qiufang Dai,
Jian Hu, linux-amlogic, devicetree, linux-clk, linux-arm-kernel,
linux-kernel
In-Reply-To: <20171207095300.15384-3-yixun.lan@amlogic.com>
On Thu, Dec 07, 2017 at 05:52:58PM +0800, Yixun Lan wrote:
> From: Qiufang Dai <qiufang.dai@amlogic.com>
>
> Add the required header for the clocks ID dt-bindings
> exported from various subsystem in the Meson-AXG SoC.
>
> Signed-off-by: Qiufang Dai <qiufang.dai@amlogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> ---
> include/dt-bindings/clock/axg-clkc.h | 71 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 71 insertions(+)
> create mode 100644 include/dt-bindings/clock/axg-clkc.h
Please add acks when posting new versions.
Rob
^ permalink raw reply
* Re: [RFC v2 2/2] dt-bindings: mailbox: Add Xilinx IPI Mailbox
From: Rob Herring @ 2017-12-07 22:14 UTC (permalink / raw)
To: Wendy Liang
Cc: jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w,
michal.simek-gjFFaj9aHVfQT0dZR+AlfA, mark.rutland-5wv7dgnIgG8,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Wendy Liang
In-Reply-To: <1512368735-27147-3-git-send-email-jliang-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
On Sun, Dec 03, 2017 at 10:25:35PM -0800, Wendy Liang wrote:
> Xilinx ZynqMP IPI(Inter Processor Interrupt) is a hardware block
> in ZynqMP SoC used for the communication between various processor
> systems.
>
> Signed-off-by: Wendy Liang <jliang-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> ---
> .../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt | 104 +++++++++++++++++++++
> 1 file changed, 104 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH V6 3/7] device property: Introduce a common API to fetch device match data
From: Rafael J. Wysocki @ 2017-12-07 22:19 UTC (permalink / raw)
To: Sakari Ailus
Cc: Sinan Kaya, dmaengine, Timur Tabi, devicetree@vger.kernel.org,
ACPI Devel Maling List, linux-arm-msm,
linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman,
Rafael J. Wysocki, Len Brown, Mika Westerberg, Sakari Ailus,
Dmitry Torokhov, Rob Herring, Kieran Bingham, open list
In-Reply-To: <20171207220642.qqiwf4vvk2gf42uf@valkosipuli.retiisi.org.uk>
On Thu, Dec 7, 2017 at 11:06 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> On Thu, Dec 07, 2017 at 03:17:52PM -0500, Sinan Kaya wrote:
>> On 12/7/2017 7:40 AM, Sakari Ailus wrote:
>> > On Tue, Dec 05, 2017 at 12:04:48PM -0500, Sinan Kaya wrote:
>> >> @@ -101,6 +103,8 @@ struct fwnode_operations {
>> >> (*graph_get_port_parent)(struct fwnode_handle *fwnode);
>> >> int (*graph_parse_endpoint)(const struct fwnode_handle *fwnode,
>> >> struct fwnode_endpoint *endpoint);
>> >> + void *(*get_match_data)(const struct fwnode_handle *fwnode,
>> >> + struct device *dev);
>> >
>> > You can make dev const, too.
>> >
>>
>> done, I couldn't change device_get_match_data() parameter const due to
>> dev_fwnode() function.
>>
>> from /local/mnt/workspace/projects/caf/kernel/drivers/base/property.c:13:
>>
>> /local/mnt/workspace/projects/caf/kernel/drivers/base/property.c:1341:39: warning: passing argument 1 of 'dev_fwnode' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>> return fwnode_call_ptr_op(dev_fwnode(dev), device_get_match_data,
>
> Right. Makes sense.
>
> I guess it's not perhaps worth it introducing dev_fwnode_const just for
> this. devices are seldom if ever const anyway.
They cannot be const. Had they been const, it wouldn't have been
possible to register them even. :-)
^ permalink raw reply
* Re: [PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860
From: Rob Herring @ 2017-12-07 22:42 UTC (permalink / raw)
To: Dan Murphy
Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds
In-Reply-To: <20171205204327.12111-2-dmurphy@ti.com>
gOn Tue, Dec 05, 2017 at 02:43:22PM -0600, Dan Murphy wrote:
> Update the lp8860 bindings to fix various issues
> found. Add address-cells and size-cells, rename
> enable-gpio to enable-gpios, update the node name
> to the device name and indent the node example.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v2 - New patch
>
> .../devicetree/bindings/leds/leds-lp8860.txt | 28 ++++++++++++----------
> 1 file changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> index aad38dd94d4b..1b2fab05ec6a 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> @@ -6,24 +6,28 @@ current sinks that can be controlled by a PWM input
> signal, a SPI/I2C master, or both.
>
> Required properties:
> - - compatible:
> + - compatible :
> "ti,lp8860"
> - - reg - I2C slave address
> - - label - Used for naming LEDs
> + - reg : I2C slave address
> + - label : Used for naming LEDs
> + - #address-cells : 1
> + - #size-cells : 0
>
> Optional properties:
> - - enable-gpio - gpio pin to enable/disable the device.
> - - supply - "vled" - LED supply
> + - enable-gpios : gpio pin to enable/disable the device.
Needs to state active high or low.
> + - supply : "vled" - LED supply
"vled-supply : ..."
>
> Example:
>
> -leds: leds@6 {
> - compatible = "ti,lp8860";
> - reg = <0x2d>;
> - label = "display_cluster";
> - enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> - vled-supply = <&vbatt>;
> -}
> + lp8860@2d {
leds@2d
There's not really any point in adding the indentation.
> + compatible = "ti,lp8860";
> + #address-cells: 1
> + #size-cells: 0
s/:/=/
Though, these aren't necessary without any child nodes. Is there more
than 1 LED channel/driver?
> + reg = <0x2d>;
> + label = "display_cluster";
> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> + vled-supply = <&vbatt>;
> + }
>
> For more product information please see the link below:
> http://www.ti.com/product/lp8860-q1
> --
> 2.15.0.124.g7668cbc60
>
^ permalink raw reply
* Re: [PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860
From: Rob Herring @ 2017-12-07 22:43 UTC (permalink / raw)
To: Dan Murphy
Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds
In-Reply-To: <20171205204327.12111-2-dmurphy@ti.com>
On Tue, Dec 05, 2017 at 02:43:22PM -0600, Dan Murphy wrote:
> Update the lp8860 bindings to fix various issues
> found. Add address-cells and size-cells, rename
> enable-gpio to enable-gpios, update the node name
> to the device name and indent the node example.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v2 - New patch
>
> .../devicetree/bindings/leds/leds-lp8860.txt | 28 ++++++++++++----------
> 1 file changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> index aad38dd94d4b..1b2fab05ec6a 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> @@ -6,24 +6,28 @@ current sinks that can be controlled by a PWM input
> signal, a SPI/I2C master, or both.
>
> Required properties:
> - - compatible:
> + - compatible :
> "ti,lp8860"
> - - reg - I2C slave address
> - - label - Used for naming LEDs
> + - reg : I2C slave address
> + - label : Used for naming LEDs
> + - #address-cells : 1
> + - #size-cells : 0
This should be added in the next patch when you have child nodes.
Rob
^ permalink raw reply
* Re: [PATCH v2 2/6] dt: bindings: lp8860: Update DT label binding
From: Rob Herring @ 2017-12-07 22:45 UTC (permalink / raw)
To: Dan Murphy
Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds
In-Reply-To: <20171205204327.12111-3-dmurphy@ti.com>
On Tue, Dec 05, 2017 at 02:43:23PM -0600, Dan Murphy wrote:
> Update the lp8860 label binding to the LED
> standard as documented in
>
> Documentation/devicetree/bindings/leds/common.txt
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v2 - Added reg to child node and made it required
>
> Documentation/devicetree/bindings/leds/leds-lp8860.txt | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> index 1b2fab05ec6a..22b594d95162 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> @@ -9,7 +9,6 @@ Required properties:
> - compatible :
> "ti,lp8860"
> - reg : I2C slave address
> - - label : Used for naming LEDs
> - #address-cells : 1
> - #size-cells : 0
>
> @@ -17,6 +16,12 @@ Optional properties:
> - enable-gpios : gpio pin to enable/disable the device.
> - supply : "vled" - LED supply
>
> +Required child properties:
> + - reg : 0
> +
> +Optional child properties:
> + - label : see Documentation/devicetree/bindings/leds/common.txt
> +
> Example:
>
> lp8860@2d {
> @@ -24,9 +29,12 @@ Example:
> #address-cells: 1
> #size-cells: 0
> reg = <0x2d>;
> - label = "display_cluster";
> enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> vled-supply = <&vbatt>;
> + display_cluster: display_cluster@0 {
led@0 {
Do you really need a (dts) label here?
> + reg=<0>;
spaces around the '='.
> + label = "display_cluster";
> + };
> }
>
> For more product information please see the link below:
> --
> 2.15.0.124.g7668cbc60
>
^ permalink raw reply
* Re: [PATCH v2 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860
From: Rob Herring @ 2017-12-07 22:46 UTC (permalink / raw)
To: Dan Murphy
Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds
In-Reply-To: <20171205204327.12111-5-dmurphy@ti.com>
On Tue, Dec 05, 2017 at 02:43:25PM -0600, Dan Murphy wrote:
> Add a default trigger optional node to the child node.
> This will allow the driver to set the trigger for a backlight.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v2 - Moved binding changes to first patch in the series.
>
> Documentation/devicetree/bindings/leds/leds-lp8860.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> index 22b594d95162..3452c9c10499 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> @@ -21,6 +21,8 @@ Required child properties:
>
> Optional child properties:
> - label : see Documentation/devicetree/bindings/leds/common.txt
> + - linux,default-trigger : (optional)
You already said this is optional.
> + see Documentation/devicetree/bindings/leds/common.txt
>
> Example:
>
> @@ -34,6 +36,7 @@ Example:
> display_cluster: display_cluster@0 {
> reg=<0>;
> label = "display_cluster";
> + linux,default-trigger = "backlight";
> };
> }
>
> --
> 2.15.0.124.g7668cbc60
>
^ permalink raw reply
* Re: [PATCH v8 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver
From: Rob Herring @ 2017-12-07 22:49 UTC (permalink / raw)
To: Dan Murphy
Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds
In-Reply-To: <20171205204630.12267-1-dmurphy@ti.com>
On Tue, Dec 05, 2017 at 02:46:29PM -0600, Dan Murphy wrote:
> This adds the devicetree bindings for the LM3692x
> I2C LED string driver.
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v8 - Added address-cells and size-cells as well as child node reg - https://patchwork.kernel.org/patch/10091259/
> v7 - No changes - https://patchwork.kernel.org/patch/10087475/
> v6 - No changes -https://patchwork.kernel.org/patch/10085567/
> v5 - No Changes - https://patchwork.kernel.org/patch/10081071/
> v4 - Fix example node, added trigger entry, removed ambiguous x for compatible and
> added common.txt pointer for label - https://patchwork.kernel.org/patch/10060107
> v3 - No changes
> v2 - No changes - https://patchwork.kernel.org/patch/10056677/
>
> .../devicetree/bindings/leds/leds-lm3692x.txt | 47 ++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3692x.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
> new file mode 100644
> index 000000000000..84f69342d879
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
> @@ -0,0 +1,47 @@
> +* Texas Instruments - LM3692x Highly Efficient White LED Driver
> +
> +The LM3692x is an ultra-compact, highly efficient,
> +white-LED driver designed for LCD display backlighting.
> +
> +The main difference between the LM36922 and LM36923 is the number of
> +LED strings it supports. The LM36922 supports two strings while the LM36923
> +supports three strings.
> +
> +Required properties:
> + - compatible:
> + "ti,lm36922"
> + "ti,lm36923"
> + - reg : I2C slave address
> + - #address-cells : 1
> + - #size-cells : 0
> +
> +Optional properties:
> + - label : see Documentation/devicetree/bindings/leds/common.txt
Should be a child prop.
> + - enable-gpios : gpio pin to enable/disable the device.
> + - vled-supply : LED supply
> + - linux,default-trigger : (optional)
> + see Documentation/devicetree/bindings/leds/common.txt
Ditto.
> +
> +Required child properties:
> + - reg : 0
> +
> +Example:
> +
> +lm3692x@36 {
leds@36
It looks like you could just add the compatible strings to the existing
binding you're modifying?
> + compatible = "ti,lm3692x";
> + reg = <0x36>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> + vled-supply = <&vbatt>;
> +
> + backlight: backlight@0 {
> + reg = <0>;
> + label = "backlight_cluster";
> + linux,default-trigger = "backlight";
> + };
> +}
> +
> +For more product information please see the link below:
> +http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf
> --
> 2.15.0.124.g7668cbc60
>
^ permalink raw reply
* Re: [PATCH] dt-bindings: at24/eeprom: add an undocumented compatible string
From: Rob Herring @ 2017-12-07 22:50 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Mark Rutland, Wolfram Sang, Divagar Mohandass,
Javier Martinez Canillas, David Lechner, devicetree, linux-kernel
In-Reply-To: <20171206101219.14011-1-brgl@bgdev.pl>
On Wed, Dec 06, 2017 at 11:12:19AM +0100, Bartosz Golaszewski wrote:
> The "atmel,sdp" compatible is reported by checkpatch as undocumented.
>
> Add it to the device tree bindings document for at24.
>
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> ---
> Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH v8 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver
From: Dan Murphy @ 2017-12-07 23:04 UTC (permalink / raw)
To: Rob Herring
Cc: mark.rutland-5wv7dgnIgG8, rpurdie-Fm38FmjxZ/leoWH0uzbU5w,
jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w, pavel-+ZI9xUNit7I,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-leds-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20171207224938.6nvy63ghxe5vwvk4@rob-hp-laptop>
Rob
On 12/07/2017 04:49 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 02:46:29PM -0600, Dan Murphy wrote:
>> This adds the devicetree bindings for the LM3692x
>> I2C LED string driver.
>>
>> Acked-by: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
>> Signed-off-by: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org>
>> ---
>>
>> v8 - Added address-cells and size-cells as well as child node reg - https://patchwork.kernel.org/patch/10091259/
>> v7 - No changes - https://patchwork.kernel.org/patch/10087475/
>> v6 - No changes -https://patchwork.kernel.org/patch/10085567/
>> v5 - No Changes - https://patchwork.kernel.org/patch/10081071/
>> v4 - Fix example node, added trigger entry, removed ambiguous x for compatible and
>> added common.txt pointer for label - https://patchwork.kernel.org/patch/10060107
>> v3 - No changes
>> v2 - No changes - https://patchwork.kernel.org/patch/10056677/
>>
>> .../devicetree/bindings/leds/leds-lm3692x.txt | 47 ++++++++++++++++++++++
>> 1 file changed, 47 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3692x.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
>> new file mode 100644
>> index 000000000000..84f69342d879
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
>> @@ -0,0 +1,47 @@
>> +* Texas Instruments - LM3692x Highly Efficient White LED Driver
>> +
>> +The LM3692x is an ultra-compact, highly efficient,
>> +white-LED driver designed for LCD display backlighting.
>> +
>> +The main difference between the LM36922 and LM36923 is the number of
>> +LED strings it supports. The LM36922 supports two strings while the LM36923
>> +supports three strings.
>> +
>> +Required properties:
>> + - compatible:
>> + "ti,lm36922"
>> + "ti,lm36923"
>> + - reg : I2C slave address
>> + - #address-cells : 1
>> + - #size-cells : 0
>> +
>> +Optional properties:
>> + - label : see Documentation/devicetree/bindings/leds/common.txt
>
> Should be a child prop.
Thanks I forgot to move this to Optional Child Properties.
>
>> + - enable-gpios : gpio pin to enable/disable the device.
>> + - vled-supply : LED supply
>> + - linux,default-trigger : (optional)
>> + see Documentation/devicetree/bindings/leds/common.txt
>
> Ditto.
Ack
>
>> +
>> +Required child properties:
>> + - reg : 0
>> +
>> +Example:
>> +
>> +lm3692x@36 {
>
> leds@36
Rob why does this need to be leds? Is this because it would be a child of an I2C node?
Jacek
Would this not cause and issue for your proposal to take the parent node name as part of the LED label?
Dan
>
> It looks like you could just add the compatible strings to the existing
> binding you're modifying?
>
>> + compatible = "ti,lm3692x";
>> + reg = <0x36>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> + vled-supply = <&vbatt>;
>> +
>> + backlight: backlight@0 {
>> + reg = <0>;
>> + label = "backlight_cluster";
>> + linux,default-trigger = "backlight";
>> + };
>> +}
>> +
>> +For more product information please see the link below:
>> +http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf
>> --
>> 2.15.0.124.g7668cbc60
>>
--
------------------
Dan Murphy
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [PATCH v2] dt-bindings: Add an enable method to RISC-V
From: Palmer Dabbelt @ 2017-12-07 23:05 UTC (permalink / raw)
To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, patches-q3qR2WxjNRFS9aJRtSZj7A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Palmer Dabbelt
RISC-V doesn't currently specify a mechanism for enabling or disabling
CPUs. Instead, we assume that all CPUs are enabled on boot, and if
someone wants to save power we instead put a CPU to sleep via a WFI
loop. Future systems may have an explicit mechanism for putting a CPU
to sleep, so we're standardizing the device tree entry for when that
happens.
We're not defining a spin-table based interface to the firmware, as the
plan is to handle this entirely within the kernel instead.
CC: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Signed-off-by: Palmer Dabbelt <palmer-SpMDHPYPyPbQT0dZR+AlfA@public.gmane.org>
---
Documentation/devicetree/bindings/riscv/cpus.txt | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/riscv/cpus.txt b/Documentation/devicetree/bindings/riscv/cpus.txt
index adf7b7af5dc3..68f88eacc594 100644
--- a/Documentation/devicetree/bindings/riscv/cpus.txt
+++ b/Documentation/devicetree/bindings/riscv/cpus.txt
@@ -82,6 +82,15 @@ described below.
Value type: <string>
Definition: Contains the RISC-V ISA string of this hart. These
ISA strings are defined by the RISC-V ISA manual.
+ - cpu-enable-method:
+ Usage: optional
+ Value type: <stringlist>
+ Definition: When absent, default is either "always-disabled"
+ "always-enabled", depending on the current state
+ of the CPU.
+ Must be one of:
+ * "always-disabled": This CPU cannot be enabled.
+ * "always-enabled": This CPU cannot be disabled.
Example: SiFive Freedom U540G Development Kit
---------------------------------------------
--
2.13.6
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* Re: [PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860
From: Dan Murphy @ 2017-12-07 23:07 UTC (permalink / raw)
To: Rob Herring
Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds
In-Reply-To: <20171207224229.wd6nc4ukiksebxw4@rob-hp-laptop>
Rob
Thanks
On 12/07/2017 04:42 PM, Rob Herring wrote:
> gOn Tue, Dec 05, 2017 at 02:43:22PM -0600, Dan Murphy wrote:
>> Update the lp8860 bindings to fix various issues
>> found. Add address-cells and size-cells, rename
>> enable-gpio to enable-gpios, update the node name
>> to the device name and indent the node example.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>
>> v2 - New patch
>>
>> .../devicetree/bindings/leds/leds-lp8860.txt | 28 ++++++++++++----------
>> 1 file changed, 16 insertions(+), 12 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> index aad38dd94d4b..1b2fab05ec6a 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> @@ -6,24 +6,28 @@ current sinks that can be controlled by a PWM input
>> signal, a SPI/I2C master, or both.
>>
>> Required properties:
>> - - compatible:
>> + - compatible :
>> "ti,lp8860"
>> - - reg - I2C slave address
>> - - label - Used for naming LEDs
>> + - reg : I2C slave address
>> + - label : Used for naming LEDs
>> + - #address-cells : 1
>> + - #size-cells : 0
>>
>> Optional properties:
>> - - enable-gpio - gpio pin to enable/disable the device.
>> - - supply - "vled" - LED supply
>> + - enable-gpios : gpio pin to enable/disable the device.
>
> Needs to state active high or low.
Ack
>
>> + - supply : "vled" - LED supply
>
> "vled-supply : ..."
>
Ack
>>
>> Example:
>>
>> -leds: leds@6 {
>> - compatible = "ti,lp8860";
>> - reg = <0x2d>;
>> - label = "display_cluster";
>> - enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> - vled-supply = <&vbatt>;
>> -}
>> + lp8860@2d {
>
> leds@2d
>
> There's not really any point in adding the indentation.
OK I was just following convention of other child node LED bindings
I can remove the indents.
>
>> + compatible = "ti,lp8860";
>
>> + #address-cells: 1
>> + #size-cells: 0
>
> s/:/=/
>
> Though, these aren't necessary without any child nodes. Is there more
> than 1 LED channel/driver?
>
Yes this device can be used to drive at least 4 different LED strings as well
I will be adding this feature once I get this driver and binding cleaned up.
Dan
>> + reg = <0x2d>;
>> + label = "display_cluster";
>> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> + vled-supply = <&vbatt>;
>> + }
>>
>> For more product information please see the link below:
>> http://www.ti.com/product/lp8860-q1
>> --
>> 2.15.0.124.g7668cbc60
>>
--
------------------
Dan Murphy
^ permalink raw reply
* Re: [PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860
From: Dan Murphy @ 2017-12-07 23:08 UTC (permalink / raw)
To: Rob Herring
Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds
In-Reply-To: <20171207224347.hrqwygbm2xb7lzbs@rob-hp-laptop>
Rob
On 12/07/2017 04:43 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 02:43:22PM -0600, Dan Murphy wrote:
>> Update the lp8860 bindings to fix various issues
>> found. Add address-cells and size-cells, rename
>> enable-gpio to enable-gpios, update the node name
>> to the device name and indent the node example.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>
>> v2 - New patch
>>
>> .../devicetree/bindings/leds/leds-lp8860.txt | 28 ++++++++++++----------
>> 1 file changed, 16 insertions(+), 12 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> index aad38dd94d4b..1b2fab05ec6a 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> @@ -6,24 +6,28 @@ current sinks that can be controlled by a PWM input
>> signal, a SPI/I2C master, or both.
>>
>> Required properties:
>> - - compatible:
>> + - compatible :
>> "ti,lp8860"
>> - - reg - I2C slave address
>> - - label - Used for naming LEDs
>> + - reg : I2C slave address
>> + - label : Used for naming LEDs
>> + - #address-cells : 1
>> + - #size-cells : 0
>
> This should be added in the next patch when you have child nodes.
>
Ack
> Rob
>
--
------------------
Dan Murphy
^ permalink raw reply
* Re: [PATCH v2 2/6] dt: bindings: lp8860: Update DT label binding
From: Dan Murphy @ 2017-12-07 23:09 UTC (permalink / raw)
To: Rob Herring
Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds
In-Reply-To: <20171207224526.5gj5pywp4cvhnpvf@rob-hp-laptop>
Rob
On 12/07/2017 04:45 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 02:43:23PM -0600, Dan Murphy wrote:
>> Update the lp8860 label binding to the LED
>> standard as documented in
>>
>> Documentation/devicetree/bindings/leds/common.txt
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>
>> v2 - Added reg to child node and made it required
>>
>> Documentation/devicetree/bindings/leds/leds-lp8860.txt | 12 ++++++++++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> index 1b2fab05ec6a..22b594d95162 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> @@ -9,7 +9,6 @@ Required properties:
>> - compatible :
>> "ti,lp8860"
>> - reg : I2C slave address
>> - - label : Used for naming LEDs
>> - #address-cells : 1
>> - #size-cells : 0
>>
>> @@ -17,6 +16,12 @@ Optional properties:
>> - enable-gpios : gpio pin to enable/disable the device.
>> - supply : "vled" - LED supply
>>
>> +Required child properties:
>> + - reg : 0
>> +
>> +Optional child properties:
>> + - label : see Documentation/devicetree/bindings/leds/common.txt
>> +
>> Example:
>>
>> lp8860@2d {
>> @@ -24,9 +29,12 @@ Example:
>> #address-cells: 1
>> #size-cells: 0
>> reg = <0x2d>;
>> - label = "display_cluster";
>> enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> vled-supply = <&vbatt>;
>> + display_cluster: display_cluster@0 {
>
> led@0 {
>
> Do you really need a (dts) label here?
We will when I add LED string support.
>
>> + reg=<0>;
>
> spaces around the '='.
Ack
>
>> + label = "display_cluster";
>> + };
>> }
>>
>> For more product information please see the link below:
>> --
>> 2.15.0.124.g7668cbc60
>>
--
------------------
Dan Murphy
^ permalink raw reply
* Devicetree Specification prerelease v0.2-pre2
From: Grant Likely @ 2017-12-07 23:12 UTC (permalink / raw)
To: devicetree-spec-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Hi everyone,
Quick note to say progress is being made on the devicetree
specification again. We've just tagged v0.2-pre2 in preparation for a
v0.2 release before the end of the 2017. You can find the new release
pdf here:
https://github.com/devicetree-org/devicetree-specification/releases
Most of the changes are cosmetic, but there are a few content changes.
You can expect a lot more content changes to go in the v0.3 sometime
early 2018.
7f8e2bd Add more recommended generic node names
ef302c9 Describe interrupts-extended property
4fac2e2 Document additional "phy-connection-type" values
418a599 Add items to Devicetree Source Format chapter
Please take a look and comment. Also, anyone wanting to help improve
the document can find the source here:
https://github.com/devicetree-org/devicetree-specification
g.
^ permalink raw reply
* Re: [PATCH v3 06/12] dt-bindings: Document the Rockchip ISP1 bindings
From: Rob Herring @ 2017-12-07 23:20 UTC (permalink / raw)
To: Jacob Chen
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
mchehab-DgEjT+Ai2ygdnm+yROfE0A,
linux-media-u79uwXL29TY76Z2rM5mHXA,
sakari.ailus-VuQAYsv1563Yd54FQh9/CA,
hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w, tfiga-F7+t8E8rja9g9hUCZPvPmw,
zhengsq-TNX95d0MmH7DzftRWevZcw,
laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw,
zyc-TNX95d0MmH7DzftRWevZcw,
eddie.cai.linux-Re5JQEeQqe8AvxtiuMwx3w,
jeffy.chen-TNX95d0MmH7DzftRWevZcw,
allon.huang-TNX95d0MmH7DzftRWevZcw,
devicetree-u79uwXL29TY76Z2rM5mHXA, heiko-4mtYJXux2i+zQB+pC5nmwQ,
Joao.Pinto-HKixBCOQz3hWk0Htik3J/w,
Luis.Oliveira-HKixBCOQz3hWk0Htik3J/w,
Jose.Abreu-HKixBCOQz3hWk0Htik3J/w, Jacob Chen
In-Reply-To: <20171206111939.1153-7-jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org>
On Wed, Dec 06, 2017 at 07:19:33PM +0800, Jacob Chen wrote:
> From: Jacob Chen <jacob2.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>
> Add DT bindings documentation for Rockchip ISP1
>
> Signed-off-by: Jacob Chen <jacob2.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
> .../devicetree/bindings/media/rockchip-isp1.txt | 57 ++++++++++++++++++++++
> 1 file changed, 57 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/rockchip-isp1.txt
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.txt b/Documentation/devicetree/bindings/media/rockchip-isp1.txt
> new file mode 100644
> index 000000000000..0971ed94ed69
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.txt
> @@ -0,0 +1,57 @@
> +Rockchip SoC Image Signal Processing unit v1
> +----------------------------------------------
> +
> +Rockchip ISP1 is the Camera interface for the Rockchip series of SoCs
> +which contains image processing, scaling, and compression funcitons.
> +
> +Required properties:
> + - compatible: value should be one of the following
> + "rockchip,rk3288-cif-isp";
> + "rockchip,rk3399-cif-isp";
> + - reg : offset and length of the register set for the device.
> + - interrupts: should contain ISP interrupt.
> + - clocks: phandle to the required clocks.
> + - clock-names: required clock name.
> + - iommus: required a iommu node.
> +
> +The device node should contain one 'port' child node with child 'endpoint'
> +nodes, according to the bindings defined in Documentation/devicetree/bindings/
> +media/video-interfaces.txt.
> +
> +For sensor with a parallel video bus, it could be linked directly to the isp.
> +For sensor with a MIPI CSI-2 video bus, it should be linked through the
> +MIPI-DPHY, which is defined in rockchip-mipi-dphy.txt.
As I mentioned on the last version, you need to list that there are 2
endpoints for the port and what their assignment is.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v9 01/13] Documentation: Add SLIMbus summary
From: Srinivas Kandagatla @ 2017-12-07 23:22 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Mark Brown, Greg Kroah-Hartman, alsa-devel, sdharia, Rob Herring,
Mark Rutland, pombredanne, j.neuschaefer, linux-arm-msm,
devicetree, linux-kernel, linux-doc
In-Reply-To: <20171207103253.25834a68@lwn.net>
Thankyou for taking time to review the patch,
On 07/12/17 17:32, Jonathan Corbet wrote:
> On Thu, 7 Dec 2017 10:27:08 +0000
> srinivas.kandagatla@linaro.org wrote:
>
> A couple of overall comments...
>
>> Documentation/driver-api/index.rst | 1 +
>> Documentation/driver-api/slimbus/index.rst | 15 ++++
>> Documentation/driver-api/slimbus/summary.rst | 106 +++++++++++++++++++++++++++
>> 3 files changed, 122 insertions(+)
>> create mode 100644 Documentation/driver-api/slimbus/index.rst
>> create mode 100644 Documentation/driver-api/slimbus/summary.rst
>
> Do we really need a separate subdirectory for a single file?
>
May be not, TBH, I did take some inspiration from soundwire patches.
I can drop that in next version. We can think of adding directory if we
end up adding more apis for the new features in future.
> It seems you have kerneldoc comments for your data structures and at least
> some of your exported symbols. If you really want to document this stuff
> well, I'd suggest finishing out those comments, then pulling them into the
> documentation in the appropriate places.
Am sure all the exported symbols have kernel doc, I will pull them into
relevant sub sections.
Do you think something like this http://paste.ubuntu.com/26135862/ makes
sense?
thanks,
srini
>
> Thanks,
>
> jon
>
^ permalink raw reply
* Re: [PATCH v3 07/12] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings
From: Rob Herring @ 2017-12-07 23:26 UTC (permalink / raw)
To: Jacob Chen
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
mchehab-DgEjT+Ai2ygdnm+yROfE0A,
linux-media-u79uwXL29TY76Z2rM5mHXA,
sakari.ailus-VuQAYsv1563Yd54FQh9/CA,
hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w, tfiga-F7+t8E8rja9g9hUCZPvPmw,
zhengsq-TNX95d0MmH7DzftRWevZcw,
laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw,
zyc-TNX95d0MmH7DzftRWevZcw,
eddie.cai.linux-Re5JQEeQqe8AvxtiuMwx3w,
jeffy.chen-TNX95d0MmH7DzftRWevZcw,
allon.huang-TNX95d0MmH7DzftRWevZcw,
devicetree-u79uwXL29TY76Z2rM5mHXA, heiko-4mtYJXux2i+zQB+pC5nmwQ,
Joao.Pinto-HKixBCOQz3hWk0Htik3J/w,
Luis.Oliveira-HKixBCOQz3hWk0Htik3J/w,
Jose.Abreu-HKixBCOQz3hWk0Htik3J/w, Jacob Chen
In-Reply-To: <20171206111939.1153-8-jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org>
On Wed, Dec 06, 2017 at 07:19:34PM +0800, Jacob Chen wrote:
> From: Jacob Chen <jacob2.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>
> Add DT bindings documentation for Rockchip MIPI D-PHY RX
>
> Signed-off-by: Jacob Chen <jacob2.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
> .../bindings/media/rockchip-mipi-dphy.txt | 71 ++++++++++++++++++++++
> 1 file changed, 71 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/rockchip-mipi-dphy.txt
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip-mipi-dphy.txt b/Documentation/devicetree/bindings/media/rockchip-mipi-dphy.txt
> new file mode 100644
> index 000000000000..cef9450db051
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/rockchip-mipi-dphy.txt
> @@ -0,0 +1,71 @@
> +Rockchip SoC MIPI RX D-PHY
> +-------------------------------------------------------------
> +
> +Required properties:
> +
> +- compatible: value should be one of the following
> + "rockchip,rk3288-mipi-dphy";
> + "rockchip,rk3399-mipi-dphy";
Drop the ';'
> +- rockchip,grf: GRF regs.
> +- bus-width : maximum number of data lanes supported (SoC specific);
> +- clocks : list of clock specifiers, corresponding to entries in
> + clock-names property;
> +- clock-names: required clock name.
> +
> +The device node should contain two 'port' child node, according to the bindings
> +defined in Documentation/devicetree/bindings/media/video-interfaces.txt.
> +The first port should be connected to sensor nodes, and the second port should be
> +connected to isp node. The following are properties specific to those nodes.
Need to list how many endpoints if there are more than 1.
> +
> +endpoint node
> +-------------
> +
> +- data-lanes : (required) an array specifying active physical MIPI-CSI2
> + data input lanes and their mapping to logical lanes; the
> + array's content is unused, only its length is meaningful;
> +
> +Device node example
> +-------------------
> +
> + mipi_dphy_rx0: mipi-dphy-rx0 {
> + compatible = "rockchip,rk3399-mipi-dphy";
> + clocks = <&cru SCLK_MIPIDPHY_REF>,
> + <&cru SCLK_DPHY_RX0_CFG>,
> + <&cru PCLK_VIO_GRF>;
> + clock-names = "dphy-ref", "dphy-cfg", "grf";
> + power-domains = <&power RK3399_PD_VIO>;
> + bus-width = <4>;
rockchip,grf?
No other registers? Can you just make this a child of the grf block with
a proper reg property for the range of dphy registers?
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mipi_in_wcam: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&wcam_out>;
> + data-lanes = <1 2>;
> + };
> + mipi_in_ucam: endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&ucam_out>;
> + data-lanes = <1>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dphy_rx0_out: endpoint@0 {
> + reg = <0>;
Don't need reg and everything associated with it if there's only 1
endpoint.
> + remote-endpoint = <&isp0_mipi_in>;
> + };
> + };
> + };
> + };
> \ No newline at end of file
Please fix.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v3 2/4] regulator: bindings: Add properties for coupled regulators
From: Rob Herring @ 2017-12-07 23:30 UTC (permalink / raw)
To: Maciej Purski
Cc: Mark Brown, linux-kernel, devicetree, Liam Girdwood, Mark Rutland,
Marek Szyprowski, Bartlomiej Zolnierkiewicz
In-Reply-To: <1512639975-22241-3-git-send-email-m.purski@samsung.com>
On Thu, Dec 07, 2017 at 10:46:13AM +0100, Maciej Purski wrote:
> Some regulators require keeping their voltage spread below defined
> max_spread.
>
> Add properties to provide information on regulators' coupling.
>
> Signed-off-by: Maciej Purski <m.purski@samsung.com>
> ---
> Documentation/devicetree/bindings/regulator/regulator.txt | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH v6 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs
From: Rob Herring @ 2017-12-07 23:35 UTC (permalink / raw)
To: Li Wei
Cc: mark.rutland, xuwei5, catalin.marinas, will.deacon, vinholikatti,
jejb, martin.petersen, khilman, arnd, gregory.clement,
thomas.petazzoni, yamada.masahiro, riku.voipio, treding, krzk,
eric, devicetree, linux-kernel, linux-arm-kernel, linux-scsi,
zangleigang, gengjianfeng, guodong.xu, zhangfei.gao, fengbaopeng
In-Reply-To: <20171207102026.14977-3-liwei213@huawei.com>
On Thu, Dec 07, 2017 at 06:20:23PM +0800, Li Wei wrote:
> add ufs node document for Hisilicon.
>
> Signed-off-by: Li Wei <liwei213@huawei.com>
> ---
Version history?
> Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ufs/ufs-hisi.txt
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> new file mode 100644
> index 000000000000..73e10698960e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> @@ -0,0 +1,38 @@
> +* Hisilicon Universal Flash Storage (UFS) Host Controller
> +
> +UFS nodes are defined to describe on-chip UFS hardware macro.
> +Each UFS Host Controller should have its own node.
> +
> +Required properties:
> +- compatible : compatible list, contains one of the following -
> + "hisilicon,hi3660-ufs", "jedec,ufs-1.1" for hisi ufs
> + host controller present on Hi36xx chipset.
> +- reg : should contain UFS register address space & UFS SYS CTRL register address,
> +- interrupt-parent : interrupt device
> +- interrupts : interrupt number
> +- clocks : List of phandle and clock specifier pairs
> +- clock-names : List of clock input name strings sorted in the same
> + order as the clocks property. "ref_clk", "phy_clk" is optional
> +- resets : reset node register, one reset the clk and the other reset the controller
> +- reset-names : describe reset node register
> +
> +Example:
> +
> + ufs: ufs@ff3b0000 {
> + compatible = "hisilicon,hi3660-ufs", "jedec,ufs-1.1";
> + /* 0: HCI standard */
> + /* 1: UFS SYS CTRL */
> + reg = <0x0 0xff3b0000 0x0 0x1000>,
> + <0x0 0xff3b1000 0x0 0x1000>;
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&crg_ctrl HI3660_CLK_GATE_UFSIO_REF>,
> + <&crg_ctrl HI3660_CLK_GATE_UFSPHY_CFG>;
> + clock-names = "ref_clk", "phy_clk";
> + freq-table-hz = <0 0>, <0 0>;
? Not documented.
> + /* offset: 0x84; bit: 12 */
> + /* offset: 0x84; bit: 7 */
> + resets = <&crg_rst 0x84 12>,
> + <&crg_rst 0x84 7>;
> + reset-names = "rst", "assert";
> + };
> --
> 2.15.0
>
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox