* Re: [PATCH v3 4/4] soc: amlogic: meson-ee-pwrc: add support for the Meson GX SoCs
From: Neil Armstrong @ 2020-05-13 14:19 UTC (permalink / raw)
To: Martin Blumenstingl, robh+dt, khilman, linux-amlogic, devicetree
Cc: linux-arm-kernel, linux-kernel
In-Reply-To: <20200420202612.369370-5-martin.blumenstingl@googlemail.com>
On 20/04/2020 22:26, Martin Blumenstingl wrote:
> Add support for the Meson GX SoCs to the meson-ee-pwrc driver.
>
> The power domains on the GX SoCs are very similar to G12A. The only
> known differences so far are:
> - The GX SoCs do not have the HHI_VPU_MEM_PD_REG2 register (for the
> VPU power-domain)
> - The GX SoCs have an additional reset line called "dvin"
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/soc/amlogic/meson-ee-pwrc.c | 26 ++++++++++++++++++++++++--
> 1 file changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/amlogic/meson-ee-pwrc.c b/drivers/soc/amlogic/meson-ee-pwrc.c
> index b30868da456a..a90572cb9c82 100644
> --- a/drivers/soc/amlogic/meson-ee-pwrc.c
> +++ b/drivers/soc/amlogic/meson-ee-pwrc.c
> @@ -16,6 +16,7 @@
> #include <linux/clk.h>
> #include <dt-bindings/power/meson8-power.h>
> #include <dt-bindings/power/meson-g12a-power.h>
> +#include <dt-bindings/power/meson-gxbb-power.h>
> #include <dt-bindings/power/meson-sm1-power.h>
>
> /* AO Offsets */
> @@ -73,7 +74,7 @@ struct meson_ee_pwrc_domain_data {
>
> /* TOP Power Domains */
>
> -static struct meson_ee_pwrc_top_domain g12a_pwrc_vpu = {
> +static struct meson_ee_pwrc_top_domain gxbb_pwrc_vpu = {
I thing it could be renamed gx_pwrc_vpu, but it's not a strong one
> .sleep_reg = AO_RTI_GEN_PWR_SLEEP0,
> .sleep_mask = BIT(8),
> .iso_reg = AO_RTI_GEN_PWR_SLEEP0,
> @@ -138,6 +139,12 @@ static struct meson_ee_pwrc_mem_domain g12a_pwrc_mem_vpu[] = {
> VPU_HHI_MEMPD(HHI_MEM_PD_REG0),
> };
>
> +static struct meson_ee_pwrc_mem_domain gxbb_pwrc_mem_vpu[] = {
> + VPU_MEMPD(HHI_VPU_MEM_PD_REG0),
> + VPU_MEMPD(HHI_VPU_MEM_PD_REG1),
> + VPU_HHI_MEMPD(HHI_MEM_PD_REG0),
> +};
> +
> static struct meson_ee_pwrc_mem_domain meson8_pwrc_mem_eth[] = {
> { HHI_MEM_PD_REG0, GENMASK(3, 2) },
> };
> @@ -223,11 +230,17 @@ static struct meson_ee_pwrc_mem_domain sm1_pwrc_mem_audio[] = {
> static bool pwrc_ee_get_power(struct meson_ee_pwrc_domain *pwrc_domain);
>
> static struct meson_ee_pwrc_domain_desc g12a_pwrc_domains[] = {
> - [PWRC_G12A_VPU_ID] = VPU_PD("VPU", &g12a_pwrc_vpu, g12a_pwrc_mem_vpu,
> + [PWRC_G12A_VPU_ID] = VPU_PD("VPU", &gxbb_pwrc_vpu, g12a_pwrc_mem_vpu,
> pwrc_ee_get_power, 11, 2),
> [PWRC_G12A_ETH_ID] = MEM_PD("ETH", meson8_pwrc_mem_eth),
> };
>
> +static struct meson_ee_pwrc_domain_desc gxbb_pwrc_domains[] = {
> + [PWRC_GXBB_VPU_ID] = VPU_PD("VPU", &gxbb_pwrc_vpu, gxbb_pwrc_mem_vpu,
> + pwrc_ee_get_power, 12, 2),
> + [PWRC_GXBB_ETHERNET_MEM_ID] = MEM_PD("ETH", meson8_pwrc_mem_eth),
> +};
> +
> static struct meson_ee_pwrc_domain_desc meson8_pwrc_domains[] = {
> [PWRC_MESON8_VPU_ID] = VPU_PD("VPU", &meson8_pwrc_vpu,
> meson8_pwrc_mem_vpu, pwrc_ee_get_power,
> @@ -514,6 +527,11 @@ static struct meson_ee_pwrc_domain_data meson_ee_g12a_pwrc_data = {
> .domains = g12a_pwrc_domains,
> };
>
> +static struct meson_ee_pwrc_domain_data meson_ee_gxbb_pwrc_data = {
> + .count = ARRAY_SIZE(gxbb_pwrc_domains),
> + .domains = gxbb_pwrc_domains,
> +};
> +
> static struct meson_ee_pwrc_domain_data meson_ee_m8_pwrc_data = {
> .count = ARRAY_SIZE(meson8_pwrc_domains),
> .domains = meson8_pwrc_domains,
> @@ -542,6 +560,10 @@ static const struct of_device_id meson_ee_pwrc_match_table[] = {
> .compatible = "amlogic,meson8m2-pwrc",
> .data = &meson_ee_m8b_pwrc_data,
> },
> + {
> + .compatible = "amlogic,meson-gxbb-pwrc",
> + .data = &meson_ee_gxbb_pwrc_data,
> + },
> {
> .compatible = "amlogic,meson-g12a-pwrc",
> .data = &meson_ee_g12a_pwrc_data,
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply
* Re: [PATCH 2/2] arm64: dts: allwinner: h6: Enable CPU opp tables for Tanix TX6
From: Maxime Ripard @ 2020-05-13 14:20 UTC (permalink / raw)
To: Clément Péron
Cc: Chen-Yu Tsai, Rob Herring, linux-arm-kernel, devicetree,
linux-kernel, linux-sunxi, Jernej Škrabec
In-Reply-To: <20200508191035.24276-2-peron.clem@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
On Fri, May 08, 2020 at 09:10:35PM +0200, Clément Péron wrote:
> Enable CPU opp tables for Tanix TX6.
>
> Also add the fixed regulator that provided vdd-cpu-gpu required for
> CPU opp tables.
>
> This voltage has been found using a voltmeter and could be wrong.
>
> Tested-by: Jernej Škrabec <jernej.skrabec@gmail.com>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
Applied both, thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply
* Re: [RFC PATCH] dt-bindings: display: ti,tfp410.txt: convert to yaml
From: Ricardo Cañuelo @ 2020-05-13 14:20 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Tomi Valkeinen, robh+dt, kernel, devicetree, dri-devel,
linux-arm-kernel, jason
In-Reply-To: <20200513140832.GI5945@pendragon.ideasonboard.com>
Hi Laurent,
On mié 13-05-2020 17:08:32, Laurent Pinchart wrote:
> The driver doesn't apply any setting to the device :-) The ti,deskew
> property is meant to report the deskew settings selected by the chip's
> configuration pins, not to set a value to be programmed to the device.
Oh, I see, thanks for clarifying it.
> Would you like to send a patch, or should I do so ?
I can take care of it, I'll try to have a new series by tomorrow.
Cheers,
Ricardo
^ permalink raw reply
* Re: [PATCH v2 5/5] ramoops: add max_reason optional field to ramoops DT node
From: Kees Cook @ 2020-05-13 14:21 UTC (permalink / raw)
To: Rob Herring
Cc: Pavel Tatashin, jmorris, sashal, linux-kernel, pmladek,
sergey.senozhatsky, rostedt, anton, ccross, tony.luck, devicetree
In-Reply-To: <20200513024230.GA3514@bogus>
On Tue, May 12, 2020 at 09:42:30PM -0500, Rob Herring wrote:
> On Tue, May 05, 2020 at 11:45:10AM -0400, Pavel Tatashin wrote:
> > Currently, it is possible to dump kmsges for panic, or oops.
> > With max_reason it is possible to dump messages for other
> > kmesg_dump events, for example reboot, halt, shutdown, kexec.
> >
> > Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
> > ---
> > .../devicetree/bindings/reserved-memory/ramoops.txt | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/reserved-memory/ramoops.txt b/Documentation/devicetree/bindings/reserved-memory/ramoops.txt
> > index 0eba562fe5c6..886cff15d822 100644
> > --- a/Documentation/devicetree/bindings/reserved-memory/ramoops.txt
> > +++ b/Documentation/devicetree/bindings/reserved-memory/ramoops.txt
> > @@ -30,7 +30,7 @@ Optional properties:
> > - ecc-size: enables ECC support and specifies ECC buffer size in bytes
> > (defaults to 0: no ECC)
> >
> > -- record-size: maximum size in bytes of each dump done on oops/panic
> > +- record-size: maximum size in bytes of each kmsg dump.
> > (defaults to 0: disabled)
> >
> > - console-size: size in bytes of log buffer reserved for kernel messages
> > @@ -45,7 +45,13 @@ Optional properties:
> > - unbuffered: if present, use unbuffered mappings to map the reserved region
> > (defaults to buffered mappings)
> >
> > -- no-dump-oops: if present, only dump panics (defaults to panics and oops)
> > +- max_reason: maximum reason for kmsg dump. Defaults to 2 (dump oops and
>
> max-reason
Thanks! I caught this in later versions, so it's correct now. :)
-Kees
--
Kees Cook
^ permalink raw reply
* Re: [PATCH v3 0/6] allow ramoops to collect all kmesg_dump events
From: Pavel Tatashin @ 2020-05-13 14:35 UTC (permalink / raw)
To: Kees Cook
Cc: Petr Mladek, Anton Vorontsov, Colin Cross, Tony Luck,
Jonathan Corbet, Rob Herring, Benson Leung,
Enric Balletbo i Serra, Sergey Senozhatsky, Steven Rostedt,
James Morris, Sasha Levin, Linux Doc Mailing List, LKML,
devicetree
In-Reply-To: <202005130045.EF013D12E@keescook>
> > + reason: panic, oops, emergency, shutdown (ordered by severity)
> > + handling: restart, halt, poweroff
> >
> > Or we might just replace KMSG_DUMP_RESTART, KMSG_DUMP_HALT,
> > KMSG_DUMP_POWEROFF with a single KMSG_DUMP_SHUTDOWN.
> >
> > Then the max reason variable would make sense.
>
> That would work for me, yeah. Pavel, is that enough granularity for you?
>
Yes, I like the second approach: where we combine all shutdown type
events into a single type.
max_reason will have 4 levels:
KMSG_DUMP_PANIC,
KMSG_DUMP_OOPS,
KMSG_DUMP_EMERG,
KMSG_DUMP_SHUTDOWN,
If needed it is possible to determine from dmesg logs what kind of
shutdown was taken, because there is a message logged right before
every kmsg_dump() for these events:
249 if (!cmd)
250 pr_emerg("Restarting system\n");
251 else
252 pr_emerg("Restarting system with command '%s'\n", cmd);
253 kmsg_dump(KMSG_DUMP_RESTART);
276 pr_emerg("System halted\n");
277 kmsg_dump(KMSG_DUMP_HALT);
294 pr_emerg("Power down\n");
295 kmsg_dump(KMSG_DUMP_POWEROFF);
Kees, I will submit a new series with these changes soon.
Thank you,
Pasha
^ permalink raw reply
* Re: [PATCH] i2c: pxa: implement generic i2c bus recovery
From: Wolfram Sang @ 2020-05-13 14:42 UTC (permalink / raw)
To: Andrew Lunn
Cc: Russell King, linux-i2c, devicetree, Gregory Clement,
Jason Cooper, linux-arm-kernel, Rob Herring,
Sebastian Hesselbarth, Vladimir Vid
In-Reply-To: <20200513131843.GB499265@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
On Wed, May 13, 2020 at 03:18:43PM +0200, Andrew Lunn wrote:
> On Wed, May 13, 2020 at 10:33:12AM +0100, Russell King wrote:
> > Implement generic GPIO-based I2C bus recovery for the PXA I2C driver.
>
> Hi Russell
>
> I assume this is going to be merged via i2c? So Wolfram Sang? He is
> not on To: or Cc:
But I read the i2c list :) I know some maintainers request CC, but I am
fine as long as it is on the list.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply
* Re: [PATCH 17/17] spi: dw: Use regset32 DebugFS method to create a registers file
From: Andy Shevchenko @ 2020-05-13 14:41 UTC (permalink / raw)
To: Serge Semin
Cc: Serge Semin, Mark Brown, Georgy Vlasov, Ramil Zaripov,
Alexey Malahov, Thomas Bogendoerfer, Paul Burton, Ralf Baechle,
Arnd Bergmann, Allison Randal, Gareth Williams, Rob Herring,
linux-mips, devicetree, fengsheng, Phil Edworthy, Thomas Gleixner,
Xinwei Kong, Aditya Pakki, wuxu.wu, Charles Keepax, Jarkko Nikula,
Linus Walleij, linux-spi, linux-kernel
In-Reply-To: <20200513124422.z6ctlmvipwer45q4@mobilestation>
On Wed, May 13, 2020 at 03:44:22PM +0300, Serge Semin wrote:
> On Fri, May 08, 2020 at 10:30:27PM +0300, Andy Shevchenko wrote:
> > On Fri, May 08, 2020 at 04:29:42PM +0300, Serge Semin wrote:
> > > DebugFS kernel interface provides a dedicated method to create the
> > > registers dump file. Use it instead of creating a generic DebugFS
> > > file with manually written read callback function.
> > > +#define DW_SPI_DBGFS_REG(_name, _off) \
> > > +{ \
> > > + .name = _name, \
> > > + .offset = _off \
> >
> > Leave comma here.
>
> don't see a point.
It will help in case if this getting extended. Also slightly better to
distinguish between terminator type of members vs. data structures.
> > > }
> > > + struct debugfs_regset32 regset;
> >
> > I'm wondering why we need it here and not simple on the stack?
>
> Please see the way the DebugFS regset work. A prompt: how does the DebugFS
> core get to know what is a base address of the registers? =)
If they have a member in the struct which passed thru private pointer of inode.
But I see your point.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply
* [PATCH 07/15] ARM: dts: stm32: update led nodes names for stm32f769-disco
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Update led nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32f769-disco.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/stm32f769-disco.dts b/arch/arm/boot/dts/stm32f769-disco.dts
index 1626e00bb2cb..0ce7fbc20fa4 100644
--- a/arch/arm/boot/dts/stm32f769-disco.dts
+++ b/arch/arm/boot/dts/stm32f769-disco.dts
@@ -66,11 +66,11 @@
leds {
compatible = "gpio-leds";
- green {
+ led-green {
gpios = <&gpioj 5 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
};
- red {
+ led-red {
gpios = <&gpioj 13 GPIO_ACTIVE_HIGH>;
};
};
--
2.15.0
^ permalink raw reply related
* [PATCH 09/15] ARM: dts: stm32: remove useless interrupt-names property on stm32f743
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Driver doesn't use interrupt's name to get it so remove it from
the node.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32h743.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/stm32h743.dtsi b/arch/arm/boot/dts/stm32h743.dtsi
index 05eb02e6d083..e1de90ade786 100644
--- a/arch/arm/boot/dts/stm32h743.dtsi
+++ b/arch/arm/boot/dts/stm32h743.dtsi
@@ -487,7 +487,6 @@
assigned-clock-parents = <&rcc LSE_CK>;
interrupt-parent = <&exti>;
interrupts = <17 IRQ_TYPE_EDGE_RISING>;
- interrupt-names = "alarm";
st,syscfg = <&pwrcfg 0x00 0x100>;
status = "disabled";
};
--
2.15.0
^ permalink raw reply related
* [PATCH 12/15] ARM: dts: stm32: Add missing #address and #size cells on spi node for stm32mp151
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Add the missing #address-cells and #size-cells to spi node.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
index 3ea05ba48215..5484ef81c5a8 100644
--- a/arch/arm/boot/dts/stm32mp151.dtsi
+++ b/arch/arm/boot/dts/stm32mp151.dtsi
@@ -1324,6 +1324,8 @@
dma-names = "tx", "rx";
clocks = <&rcc QSPI_K>;
resets = <&rcc QSPI_R>;
+ #address-cells = <1>;
+ #size-cells = <0>;
status = "disabled";
};
--
2.15.0
^ permalink raw reply related
* [PATCH 01/15] ARM: dts: stm32: remove useless interrupt-names property on stm32f429
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Driver doesn't use interrupt's name to get it so remove it from
the node.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32f429.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
index d7770699feb5..3537430fd4a3 100644
--- a/arch/arm/boot/dts/stm32f429.dtsi
+++ b/arch/arm/boot/dts/stm32f429.dtsi
@@ -322,7 +322,6 @@
assigned-clock-parents = <&rcc 1 CLK_LSE>;
interrupt-parent = <&exti>;
interrupts = <17 1>;
- interrupt-names = "alarm";
st,syscfg = <&pwrcfg 0x00 0x100>;
status = "disabled";
};
--
2.15.0
^ permalink raw reply related
* [PATCH 15/15] dt-bindings: usb: dwc2: Fix issues for stm32mp15x SoC
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Correct the compatible list for stm32mp15x SoC.
Fix the name of the stm32mp15x dedicated supply to be aligned with
what the driver use.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 0d6d850a7f17..1357b861310d 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -44,7 +44,9 @@ properties:
- const: st,stm32f4x9-hsotg
- const: st,stm32f7-hsotg
- const: st,stm32mp15-fsotg
- - const: st,stm32mp15-hsotg
+ - items:
+ - const: st,stm32mp15-hsotg
+ - const: snps,dwc2
- const: samsung,s3c6400-hsotg
reg:
@@ -90,7 +92,7 @@ properties:
vusb_a-supply:
description: phandle to voltage regulator of analog section.
- vusb33d-supply:
+ usb33d-supply:
description: reference to the VBUS and ID sensing comparators supply, in
order to perform OTG operation, used on STM32MP15 SoCs.
--
2.15.0
^ permalink raw reply related
* Re: [PATCH 2/3] pinctrl: mchp-sgpio: Add pinctrl driver for Microsemi Serial GPIO
From: Randy Dunlap @ 2020-05-13 15:01 UTC (permalink / raw)
To: Lars Povlsen, SoC Team, Linus Walleij
Cc: Microchip Linux Driver Support, devicetree, linux-gpio,
linux-arm-kernel, linux-kernel, Alexandre Belloni
In-Reply-To: <20200513141134.25819-3-lars.povlsen@microchip.com>
On 5/13/20 7:11 AM, Lars Povlsen wrote:
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 834c59950d1cf..2b0e9021fd7e0 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -396,6 +396,23 @@ config PINCTRL_OCELOT
> select OF_GPIO
> select REGMAP_MMIO
>
> +config PINCTRL_MSCC_SGPIO
> + bool "Pinctrl driver for Microsemi Serial GPIO"
> + depends on OF
> + depends on HAS_IOMEM
> + select GPIOLIB
> + select GENERIC_PINCONF
> + select GENERIC_PINCTRL_GROUPS
> + select GENERIC_PINMUX_FUNCTIONS
> + select OF_GPIO
> + help
> + Support for the VCoreIII SoC serial GPIO device. By using a
Line above should be indented with one tab + 2 spaces...
like the lines below.
> + serial interface, the SIO controller significantly extends
> + the number of available GPIOs with a minimum number of
> + additional pins on the device. The primary purpose of the
> + SIO controller is to connect control signals from SFP
> + modules and to act as an LED controller.
> +
thanks.
--
~Randy
^ permalink raw reply
* [PATCH 05/15] ARM: dts: stm32: remove useless interrupt-names property on stm32f746
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Driver doesn't use interrupt's name to get it so remove it from
the node.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32f746.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index 93c063796780..5d69a0c653eb 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -304,7 +304,6 @@
assigned-clock-parents = <&rcc 1 CLK_LSE>;
interrupt-parent = <&exti>;
interrupts = <17 1>;
- interrupt-names = "alarm";
st,syscfg = <&pwrcfg 0x00 0x100>;
status = "disabled";
};
--
2.15.0
^ permalink raw reply related
* [PATCH 00/15] Fix STM32 DT issues on v5.7-rc4
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
This series fixes issues hight lighted by dtbs_check on STM32 devicetrees.
The patches has been developped on top of v5.7-rc4 tag.
Benjamin Gaignard (15):
ARM: dts: stm32: remove useless interrupt-names property on stm32f429
ARM: dts: stm32: update pwm pinctrl node names for stm32f4
ARM: dts: stm32: update led nodes names for stm32f249-disco
ARM: dts: stm32: update led nodes names for stm32f469-disco
ARM: dts: stm32: remove useless interrupt-names property on stm32f746
ARM: dts: stm32: update led nodes names for stm32f429-eval
ARM: dts: stm32: update led nodes names for stm32f769-disco
ARM: dts: stm32: update led nodes names for stm32f746-eval
ARM: dts: stm32: remove useless interrupt-names property on stm32f743
ARM: dts: stm32: Update nodes names for stm32h743 pinctrl
ARM: dts: stm32: Update nodes names for stm32mp15 pinctrl
ARM: dts: stm32: Add missing #address and #size cells on spi node for
stm32mp151
ARM: dts: stm32: update led nodes names for stm32f746-eval
dt-bindings: pinctrl: stm32: Add missing interrupts property
dt-bindings: usb: dwc2: Fix issues for stm32mp15x SoC
.../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 3 +++
Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++--
arch/arm/boot/dts/stm32429i-eval.dts | 8 ++++----
arch/arm/boot/dts/stm32746g-eval.dts | 8 ++++----
arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 4 ++--
arch/arm/boot/dts/stm32f429-disco.dts | 4 ++--
arch/arm/boot/dts/stm32f429.dtsi | 1 -
arch/arm/boot/dts/stm32f469-disco.dts | 8 ++++----
arch/arm/boot/dts/stm32f746.dtsi | 1 -
arch/arm/boot/dts/stm32f769-disco.dts | 4 ++--
arch/arm/boot/dts/stm32h743-pinctrl.dtsi | 10 +++++-----
arch/arm/boot/dts/stm32h743.dtsi | 1 -
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 6 +++---
arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 2 +-
15 files changed, 36 insertions(+), 32 deletions(-)
--
2.15.0
^ permalink raw reply
* [PATCH 06/15] ARM: dts: stm32: update led nodes names for stm32f429-eval
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Update led nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32429i-eval.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
index c27fa355e5ab..4115e7e2b739 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -104,17 +104,17 @@
leds {
compatible = "gpio-leds";
- green {
+ led-green {
gpios = <&gpiog 6 1>;
linux,default-trigger = "heartbeat";
};
- orange {
+ led-orange {
gpios = <&gpiog 7 1>;
};
- red {
+ led-red {
gpios = <&gpiog 10 1>;
};
- blue {
+ led-blue {
gpios = <&gpiog 12 1>;
};
};
--
2.15.0
^ permalink raw reply related
* [PATCH 10/15] ARM: dts: stm32: Update nodes names for stm32h743 pinctrl
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Fix the nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32h743-pinctrl.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/stm32h743-pinctrl.dtsi b/arch/arm/boot/dts/stm32h743-pinctrl.dtsi
index e44e7baa3f17..fa5dcb6a5fdd 100644
--- a/arch/arm/boot/dts/stm32h743-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32h743-pinctrl.dtsi
@@ -163,7 +163,7 @@
#interrupt-cells = <2>;
};
- i2c1_pins_a: i2c1@0 {
+ i2c1_pins_a: i2c1-0 {
pins {
pinmux = <STM32_PINMUX('B', 6, AF4)>, /* I2C1_SCL */
<STM32_PINMUX('B', 7, AF4)>; /* I2C1_SDA */
@@ -173,7 +173,7 @@
};
};
- ethernet_rmii: rmii@0 {
+ ethernet_rmii: rmii-0 {
pins {
pinmux = <STM32_PINMUX('G', 11, AF11)>,
<STM32_PINMUX('G', 13, AF11)>,
@@ -256,7 +256,7 @@
};
};
- usart1_pins: usart1@0 {
+ usart1_pins: usart1-0 {
pins1 {
pinmux = <STM32_PINMUX('B', 14, AF4)>; /* USART1_TX */
bias-disable;
@@ -269,7 +269,7 @@
};
};
- usart2_pins: usart2@0 {
+ usart2_pins: usart2-0 {
pins1 {
pinmux = <STM32_PINMUX('D', 5, AF7)>; /* USART2_TX */
bias-disable;
@@ -282,7 +282,7 @@
};
};
- usbotg_hs_pins_a: usbotg-hs@0 {
+ usbotg_hs_pins_a: usbotg-hs-0 {
pins {
pinmux = <STM32_PINMUX('H', 4, AF10)>, /* ULPI_NXT */
<STM32_PINMUX('I', 11, AF10)>, /* ULPI_DIR> */
--
2.15.0
^ permalink raw reply related
* [PATCH 08/15] ARM: dts: stm32: update led nodes names for stm32f746-eval
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Update led nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32746g-eval.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/stm32746g-eval.dts b/arch/arm/boot/dts/stm32746g-eval.dts
index 4ea3f98dd275..ca8c192449ee 100644
--- a/arch/arm/boot/dts/stm32746g-eval.dts
+++ b/arch/arm/boot/dts/stm32746g-eval.dts
@@ -66,17 +66,17 @@
leds {
compatible = "gpio-leds";
- green {
+ led-green {
gpios = <&gpiof 10 1>;
linux,default-trigger = "heartbeat";
};
- orange {
+ led-orange {
gpios = <&stmfx_pinctrl 17 1>;
};
- red {
+ led-red {
gpios = <&gpiob 7 1>;
};
- blue {
+ led-blue {
gpios = <&stmfx_pinctrl 19 1>;
};
};
--
2.15.0
^ permalink raw reply related
* [PATCH 11/15] ARM: dts: stm32: Update nodes names for stm32mp15 pinctrl
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Fix the nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
index 73c07f0dfad2..e87a59cd9d48 100644
--- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
@@ -6,7 +6,7 @@
#include <dt-bindings/pinctrl/stm32-pinfunc.h>
&pinctrl {
- adc1_in6_pins_a: adc1-in6 {
+ adc1_in6_pins_a: adc1-in6-0 {
pins {
pinmux = <STM32_PINMUX('F', 12, ANALOG)>;
};
@@ -58,13 +58,13 @@
};
};
- dac_ch1_pins_a: dac-ch1 {
+ dac_ch1_pins_a: dac-ch1-0 {
pins {
pinmux = <STM32_PINMUX('A', 4, ANALOG)>;
};
};
- dac_ch2_pins_a: dac-ch2 {
+ dac_ch2_pins_a: dac-ch2-0 {
pins {
pinmux = <STM32_PINMUX('A', 5, ANALOG)>;
};
--
2.15.0
^ permalink raw reply related
* [PATCH 04/15] ARM: dts: stm32: update led nodes names for stm32f469-disco
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Update led nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32f469-disco.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/stm32f469-disco.dts b/arch/arm/boot/dts/stm32f469-disco.dts
index 9397db0c43de..2e1b3bbbe4b5 100644
--- a/arch/arm/boot/dts/stm32f469-disco.dts
+++ b/arch/arm/boot/dts/stm32f469-disco.dts
@@ -89,17 +89,17 @@
leds {
compatible = "gpio-leds";
- green {
+ led-green {
gpios = <&gpiog 6 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};
- orange {
+ led-orange {
gpios = <&gpiod 4 GPIO_ACTIVE_LOW>;
};
- red {
+ led-red {
gpios = <&gpiod 5 GPIO_ACTIVE_LOW>;
};
- blue {
+ led-blue {
gpios = <&gpiok 3 GPIO_ACTIVE_LOW>;
};
};
--
2.15.0
^ permalink raw reply related
* [PATCH 02/15] ARM: dts: stm32: update pwm pinctrl node names for stm32f4
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Rename pwm pinctrl nodes name to matching with yaml bindings
requirements.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
index 392fa143ce07..031caaf40e89 100644
--- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
@@ -257,7 +257,7 @@
};
};
- pwm1_pins: pwm-1 {
+ pwm1_pins: pwm1-0 {
pins {
pinmux = <STM32_PINMUX('A', 8, AF1)>, /* TIM1_CH1 */
<STM32_PINMUX('B', 13, AF1)>, /* TIM1_CH1N */
@@ -265,7 +265,7 @@
};
};
- pwm3_pins: pwm-3 {
+ pwm3_pins: pwm3-0 {
pins {
pinmux = <STM32_PINMUX('B', 4, AF2)>, /* TIM3_CH1 */
<STM32_PINMUX('B', 5, AF2)>; /* TIM3_CH2 */
--
2.15.0
^ permalink raw reply related
* [PATCH 03/15] ARM: dts: stm32: update led nodes names for stm32f249-disco
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Update led nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32f429-disco.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/stm32f429-disco.dts b/arch/arm/boot/dts/stm32f429-disco.dts
index 30c0f6717871..b39a2b24d7b0 100644
--- a/arch/arm/boot/dts/stm32f429-disco.dts
+++ b/arch/arm/boot/dts/stm32f429-disco.dts
@@ -70,10 +70,10 @@
leds {
compatible = "gpio-leds";
- red {
+ led-red {
gpios = <&gpiog 14 0>;
};
- green {
+ led-green {
gpios = <&gpiog 13 0>;
linux,default-trigger = "heartbeat";
};
--
2.15.0
^ permalink raw reply related
* [PATCH 14/15] dt-bindings: pinctrl: stm32: Add missing interrupts property
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Driver use interrupt-parent field so update the bindings to allow it.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
index 46a0478cb924..5abdabafb8a0 100644
--- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
@@ -36,6 +36,9 @@ properties:
pins-are-numbered: true
hwlocks: true
+ interrupts:
+ maxItems: 1
+
st,syscfg:
allOf:
- $ref: "/schemas/types.yaml#/definitions/phandle-array"
--
2.15.0
^ permalink raw reply related
* [PATCH 13/15] ARM: dts: stm32: update led nodes names for stm32f746-eval
From: Benjamin Gaignard @ 2020-05-13 14:59 UTC (permalink / raw)
To: linus.walleij, robh+dt, mcoquelin.stm32, alexandre.torgue, gregkh
Cc: linux-gpio, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel, linux-usb, Benjamin Gaignard
In-Reply-To: <20200513145935.22493-1-benjamin.gaignard@st.com>
Update led nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
index d946e0a02f5c..aa47be06cd7a 100644
--- a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
@@ -62,7 +62,7 @@
led {
compatible = "gpio-leds";
- blue {
+ led-blue {
label = "heartbeat";
gpios = <&gpiod 11 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
--
2.15.0
^ permalink raw reply related
* Re: [PATCH 01/10] spi: dw: Add support for polled operation via no IRQ specified in DT
From: Andy Shevchenko @ 2020-05-13 14:55 UTC (permalink / raw)
To: Lars Povlsen
Cc: Mark Brown, SoC Team, Microchip Linux Driver Support, linux-spi,
devicetree, Linux Kernel Mailing List, linux-arm Mailing List,
Alexandre Belloni
In-Reply-To: <20200513140031.25633-2-lars.povlsen@microchip.com>
On Wed, May 13, 2020 at 5:03 PM Lars Povlsen <lars.povlsen@microchip.com> wrote:
>
> With this change a SPI controller can be added without having a IRQ
> associated, and causing all transfers to be polled. For SPI controllers
> without DMA, this can significantly improve performance by less
> interrupt handling overhead.
...
> +#define VALID_IRQ(i) (i >= 0)
drivers/rtc/rtc-cmos.c:95:#define is_valid_irq(n) ((n) > 0)
Candidate to be in include/linux/irq.h ?
...
> + if (VALID_IRQ(dws->irq))
> + free_irq(dws->irq, master);
Isn't free_irq() aware of invalid ones (not found IRQ in the tree or
any other backend container won't do anything)?
> err_free_master:
> spi_controller_put(master);
> return ret;
> --
> 2.26.2
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox