Re: [PATCH v6 11/11] arm64: dts: qcom: ipq5210: Add random number generator node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: child node inserted out of unit-address order
--

commit 2020cb31990e9e26b7fe5e1e8919a503b1184e3a
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

arm64: dts: qcom: ipq5210: Add random number generator node

Add random generator node for the RNG block present in IPQ5210.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> index 23a2e27b70fa3..4795de0c8baaf 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> @@ -198,6 +198,13 @@ soc@0 {
>  		dma-ranges = <0 0 0 0 0x10 0>;
>  		ranges = <0 0 0 0 0x10 0>;
>  
> +		rng: rng@4c3000 {
> +			compatible = "qcom,ipq5210-trng", "qcom,trng";
> +			reg = <0x0 0x004c3000 0x0 0x1000>;
> +			clocks = <&gcc GCC_QRNG_AHB_CLK>;
> +			clock-names = "core";
> +		};
> +
>  		qusb_phy_0: phy@7b000 {

[Severity: Low]
This isn't a bug, but does the placement of rng@4c3000 violate the Device Tree
convention for node ordering?

Standard DT convention requires child nodes under a common bus to be sorted in
ascending numerical order of their unit-address. Since 0x4c3000 is greater
than 0x7b000, should the rng@4c3000 node be positioned lower in the soc@0
node list?

>  			compatible = "qcom,ipq5210-qusb2-phy", "qcom,ipq6018-qusb2-phy";
>  			reg = <0x0 0x0007b000 0x0 0x180>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-08-dts-v6-0-f9c4ec8664d8@oss.qualcomm.com?part=11