Re: [PATCH v6 03/11] arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant DT file

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: redundant property duplication in flash@0 node
--

commit 730037c043b086f6324dee42a3f417cb7d8c240b
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant DT file

This commit adds a new Device Tree file for the NAND variant of the
IPQ5210 RDP504 board. It also updates the Makefile to include the new
dtb target.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts
> new file mode 100644
> index 0000000000000..8b7106cbd7c6d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts
> @@ -0,0 +1,29 @@
[ ... ]
> +&qpic_nand {
> +	status = "okay";
> +
> +	flash@0 {
> +		compatible = "spi-nand";
> +		reg = <0>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		nand-ecc-engine = <&qpic_nand>;
> +		nand-ecc-strength = <4>;
> +		nand-ecc-step-size = <512>;

[Severity: Low]
This isn't a bug, but should these properties be omitted here?

They appear to be identical to the ones already present in the included
ipq5210-rdp504-common.dtsi. Re-declaring them verbatim in the flash@0 node
creates duplicate definitions where future updates in the common .dtsi could
be silently overridden.

Could this node just contain the new spi-rx-bus-width and spi-tx-bus-width
properties instead?

> +		spi-rx-bus-width = <4>;
> +		spi-tx-bus-width = <4>;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-08-dts-v6-0-f9c4ec8664d8@oss.qualcomm.com?part=3