Re: [PATCH 07/24] clk: zte: Add ZX279128S CRM clock and reset driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mm: memory leak of 'rst' on reset_controller_register() failure
--

commit 89917541059d6bdb4e5407b41363569ca035d1d3
Author: Navid Ghahremani <ghahramani.navid@gmail.com>

clk: zte: Add ZX279128S CRM clock and reset driver

This commit adds the ZTE zx279128s CRM clock and reset driver. It reads the
bootloader PLL and bus setup, and provides peripheral gates, muxes, dividers
and USB resets.

> diff --git a/drivers/clk/zte/clk-zx279128s.c b/drivers/clk/zte/clk-zx279128s.c
> new file mode 100644
> index 0000000000000..1282d17fcfaff
> --- /dev/null
> +++ b/drivers/clk/zte/clk-zx279128s.c
> @@ -0,0 +1,460 @@

[ ... ]

> +static int __init zx_top_reset_init(struct device_node *np,
> +				    void __iomem *base)
> +{
> +	struct reset_simple_data *rst;
> +
> +	rst = kzalloc_obj(*rst);
> +	if (!rst)
> +		return -ENOMEM;
> +
> +	spin_lock_init(&rst->lock);
> +	rst->membase = base;
> +	rst->active_low = true;
> +	rst->status_active_low = true;
> +	rst->rcdev.ops = &reset_simple_ops;
> +	rst->rcdev.owner = THIS_MODULE;
> +	rst->rcdev.nr_resets = TOP_NUM_RESETS;
> +	rst->rcdev.of_node = np;
> +
> +	return reset_controller_register(&rst->rcdev);
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[Severity: Low]
Does this code leak the memory allocated for rst if
reset_controller_register() fails? It returns the error code directly
but fails to free the locally allocated rst object.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261010130024.177503-1-ghahramani.navid@gmail.com?part=7